* bug#16796: 24.3.50; global value of after-change-functions reset without error
@ 2014-02-18 17:43 Michael Heerdegen
2016-09-08 23:47 ` Alex
0 siblings, 1 reply; 4+ messages in thread
From: Michael Heerdegen @ 2014-02-18 17:43 UTC (permalink / raw
To: 16796
Hello,
I'm working on a package that needs to install a function in (the global
binding of) `after-change-functions'.
I experience that the global value of `after-change-functions' is
randomly reset to nil, without any error involved or any error message
being printed. I invested lots of time to preclude any error.
I installed a timer that frequently checks whether
`after-change-functions' had been reset. A good situation to provoke
the reset was completing with helm and just typing in the minibuffer.
At random locations, the reset happened. Note that there is no error
involved, nor does helm touch `after-change-functions'.
Here is a different example that "works" from emacs -Q:
--8<---------------cut here---------------start------------->8---
(progn
(defun foo (&rest _) ())
(add-hook 'after-change-functions 'foo)
(defun complain ()
(when (not (memq 'foo (default-value 'after-change-functions)))
(message "Why does this happen?")
(cancel-timer complain-timer)))
(defvar complain-timer
(run-with-idle-timer .03 .03 #'complain))
(require 'cl-lib)
(global-set-key
[f9]
(lambda () (interactive)
(completing-read
"Hit tab and C-g: "
(cl-loop for i from 1 to 100000
collect (format "%d" i))))))
--8<---------------cut here---------------end--------------->8---
Hit f9 and C-g one or two times. I get "Why does this happen?", but not
always. If I repeat the test several times, I'll always happen sooner
or later.
Here is the response I got from Kalle Olavi Niemitalo in emacs dev:
I debugged this a bit, with my custom Emacs 23.0.51. I don't
know how much this machinery has changed in later versions.
Emacs set Vquit_flag at:
handle_interrupt
tty_read_avail_input
read_avail_input
handle_async_input
input_available_signal
<signal handler called>
mark_object
Fgarbage_collect
Ffuncall
run_hook_list_with_args
signal_after_change
Fadd_text_properties
Fput_text_property
Fdisplay_completion_list
internal_with_output_to_temp_buffer
Fminibuffer_completion_help
do_completion
Fminibuffer_complete
Ffuncall
Fcall_interactively
After Fgarbage_collect returned, Ffuncall called funcall_lambda,
in which the QUIT macro detected the non-nil value of Vquit_flag
and called Fsignal (Qquit, Qnil). Because the quit was signaled
within signal_after_change, after-change-functions were not
restored.
I don't see any reasonable way to prevent after-change-functions
from being reset like this.
Thanks! Kalle, does that mean that it won't be possible to fix this,
and that I shouldn't rely on `after-change-functions' being kept?
Do you know whether the buffer local binding is "safe"?
Perhaps you could change your Emacs to break when the reset
happens, and always run it in a debugger. Make
signal_before_change and signal_after_change maintain some kind
of flag or nesting counter, and set conditional breakpoints in
Fthrow and Fsignal. That will get a false positive if the error
is caught within the hook; but I don't think it happens often.
Uff, I'm afraid I must say that this is a bit above my (zerop) C skills.
Thanks,
Michael.
In GNU Emacs 24.3.50.6 (x86_64-unknown-linux-gnu, GTK+ Version 3.8.6)
of 2014-02-12 on drachen
Windowing system distributor `The X.Org Foundation', version 11.0.11405000
System Description: Debian GNU/Linux testing (jessie)
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#16796: 24.3.50; global value of after-change-functions reset without error
2014-02-18 17:43 bug#16796: 24.3.50; global value of after-change-functions reset without error Michael Heerdegen
@ 2016-09-08 23:47 ` Alex
2016-09-08 23:55 ` Michael Heerdegen
0 siblings, 1 reply; 4+ messages in thread
From: Alex @ 2016-09-08 23:47 UTC (permalink / raw
To: Michael Heerdegen; +Cc: 16796
Michael Heerdegen <michael_heerdegen@web.de> writes:
> Hello,
>
> I'm working on a package that needs to install a function in (the global
> binding of) `after-change-functions'.
>
> I experience that the global value of `after-change-functions' is
> randomly reset to nil, without any error involved or any error message
> being printed. I invested lots of time to preclude any error.
>
> I installed a timer that frequently checks whether
> `after-change-functions' had been reset. A good situation to provoke
> the reset was completing with helm and just typing in the minibuffer.
> At random locations, the reset happened. Note that there is no error
> involved, nor does helm touch `after-change-functions'.
>
>
> Here is a different example that "works" from emacs -Q:
>
> (progn
>
> (defun foo (&rest _) ())
>
> (add-hook 'after-change-functions 'foo)
>
> (defun complain ()
> (when (not (memq 'foo (default-value 'after-change-functions)))
> (message "Why does this happen?")
> (cancel-timer complain-timer)))
>
> (defvar complain-timer
> (run-with-idle-timer .03 .03 #'complain))
>
> (require 'cl-lib)
> (global-set-key
> [f9]
> (lambda () (interactive)
> (completing-read
> "Hit tab and C-g: "
> (cl-loop for i from 1 to 100000
> collect (format "%d" i))))))
>
> Hit f9 and C-g one or two times. I get "Why does this happen?", but not
> always. If I repeat the test several times, I'll always happen sooner
> or later.
I can reproduce this on 24.5 but not in 25.1. Can you reproduce this on 25.1
or up?
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#16796: 24.3.50; global value of after-change-functions reset without error
2016-09-08 23:47 ` Alex
@ 2016-09-08 23:55 ` Michael Heerdegen
2016-09-09 0:19 ` Alex
0 siblings, 1 reply; 4+ messages in thread
From: Michael Heerdegen @ 2016-09-08 23:55 UTC (permalink / raw
To: Alex; +Cc: 16796
Alex <agrambot@gmail.com> writes:
> > (progn
> >
> > (defun foo (&rest _) ())
> >
> > (add-hook 'after-change-functions 'foo)
> >
> > (defun complain ()
> > (when (not (memq 'foo (default-value 'after-change-functions)))
> > (message "Why does this happen?")
> > (cancel-timer complain-timer)))
> >
> > (defvar complain-timer
> > (run-with-idle-timer .03 .03 #'complain))
> >
> > (require 'cl-lib)
> > (global-set-key
> > [f9]
> > (lambda () (interactive)
> > (completing-read
> > "Hit tab and C-g: "
> > (cl-loop for i from 1 to 100000
> > collect (format "%d" i))))))
> >
> > Hit f9 and C-g one or two times. I get "Why does this happen?", but not
> > always. If I repeat the test several times, I'll always happen sooner
> > or later.
>
> I can reproduce this on 24.5 but not in 25.1. Can you reproduce this
> on 25.1 or up?
No, seems I can't reproduce it with 25.1. I guess we can close this and
cross our fingers.
Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#16796: 24.3.50; global value of after-change-functions reset without error
2016-09-08 23:55 ` Michael Heerdegen
@ 2016-09-09 0:19 ` Alex
0 siblings, 0 replies; 4+ messages in thread
From: Alex @ 2016-09-09 0:19 UTC (permalink / raw
To: Michael Heerdegen; +Cc: 16796
close 16796 25.1
quit
Michael Heerdegen <michael_heerdegen@web.de> writes:
> No, seems I can't reproduce it with 25.1. I guess we can close this and
> cross our fingers.
>
> Michael.
Great, I'll close this then.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-09 0:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-18 17:43 bug#16796: 24.3.50; global value of after-change-functions reset without error Michael Heerdegen
2016-09-08 23:47 ` Alex
2016-09-08 23:55 ` Michael Heerdegen
2016-09-09 0:19 ` Alex
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.