From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters Date: Fri, 28 Oct 2016 22:06:55 -0400 Message-ID: <87r36zrjr4.fsf@users.sourceforge.net> References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> <87insdpp45.wl-domenechjosel@gmail.com> <87wpgtqt92.fsf@users.sourceforge.net> <87a8dp0x6v.wl-domenechjosel@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1477706840 21677 195.159.176.226 (29 Oct 2016 02:07:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 29 Oct 2016 02:07:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 24620@debbugs.gnu.org, Michael Albinus To: =?UTF-8?Q?Jos=C3=A9?= L. =?UTF-8?Q?Dom=C3=A9nech?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 29 04:07:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0J36-00040E-Kr for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Oct 2016 04:07:08 +0200 Original-Received: from localhost ([::1]:52848 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0J39-00015r-7G for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Oct 2016 22:07:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0J33-000154-9g for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2016 22:07:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0J30-0005TB-4q for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2016 22:07:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47337) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c0J30-0005T4-05 for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2016 22:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c0J2z-0008T9-Li for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2016 22:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Oct 2016 02:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24620 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24620-submit@debbugs.gnu.org id=B24620.147770678132499 (code B ref 24620); Sat, 29 Oct 2016 02:07:01 +0000 Original-Received: (at 24620) by debbugs.gnu.org; 29 Oct 2016 02:06:21 +0000 Original-Received: from localhost ([127.0.0.1]:34500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0J2L-0008S1-IB for submit@debbugs.gnu.org; Fri, 28 Oct 2016 22:06:21 -0400 Original-Received: from mail-it0-f45.google.com ([209.85.214.45]:36433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0J2K-0008Rh-0L; Fri, 28 Oct 2016 22:06:20 -0400 Original-Received: by mail-it0-f45.google.com with SMTP id m138so6428949itm.1; Fri, 28 Oct 2016 19:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=7xsUPdM9EsMxX//8gqOTnl+grE4ZZZ7g9PqlJ9Si1sU=; b=gnF2SigRejdbCa/ukfau6w2VPUGLtqtfFDUBxu518KlSRWuF6wll2zWi4cwpi3ev67 6FEKxnnVG3Z7vjFoj0bkHs+0nkiPhTZ+wQnH3zNHEFADzxiVInHsol7L9m/kKk166qDz RlKFmVVgkfPoj9p8geHaTwIqIeRLkKLG4/BQ7nZaJJJyUQl+FLWgmAfqswWjFyz+3AT0 okxTnlNMuJKE+IpPeY65Zmgt+GJwKeG3r0vrnaByPudkV/lMLhEjGePbA/XN9ZDEH302 RC7/ez3PhbU4y/ommAeucHyAP1QdvmIeB6IofuKguP/vEWInC4mDEqIdKIfacaN+jmai TPsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=7xsUPdM9EsMxX//8gqOTnl+grE4ZZZ7g9PqlJ9Si1sU=; b=Co4I+5mVi0wLF9yoFkmEon+83VAjjlu2VYIwXy5OymA1ojpd2FiXu2UiBowNJqoAhk Wzr59+ZkjIHMIVayTkkM9DYjB2icNQoARHuJX3anxBHkhI3rC9OTdDA1RApvh8e4q/r1 0syfODw1NvoIh4jot4AHvrsPvvrG3N4cExY454MQ+SmnZfHgv3shTvgi1rw5TWf3NCNp QvWxa6hBsU8aa0V+GJpg/i++sEe2CWjnYLbSLPUUJD5Eaz01m8I4YG/UkATx2XJbtHYE s1k/wZaELcTEiiGT6IsrBjiSDBli7k70DZeHCYIdzo8apJmBA2HfU04vAmLZgbHSvcIY Nvfg== X-Gm-Message-State: ABUngvcEdfTxhs+h8D4AV7iXJFC6eILcr4jyiqWym2cBB5WOVPXcTb5clVMq84rSMMGB7g== X-Received: by 10.107.34.144 with SMTP id i138mr12726711ioi.197.1477706774597; Fri, 28 Oct 2016 19:06:14 -0700 (PDT) Original-Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id x69sm4112387ite.10.2016.10.28.19.06.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 28 Oct 2016 19:06:14 -0700 (PDT) In-Reply-To: <87a8dp0x6v.wl-domenechjosel@gmail.com> ("=?UTF-8?Q?Jos=C3=A9?= L. =?UTF-8?Q?Dom=C3=A9nech?="'s message of "Fri, 28 Oct 2016 09:06:32 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125098 Archived-At: tags 24620 patch quit Jos=C3=A9 L. Dom=C3=A9nech writes: > On Fri, 28 Oct 2016 01:14:49 +0200, > npostavs@users.sourceforge.net wrote: >>=20 >>=20 >> That looks pretty good. I think it would be even nicer to use the >> `format-spec' function instead of calling `replace-regexp-in-string' >> twice. >>=20 >>=20 > Here are the changes: > > --- dired-aux.orig.el 2016-10-27 15:50:50.428634418 +0200 > +++ dired-aux.el 2016-10-28 09:01:08.413024427 +0200 > @@ -1012,11 +1012,15 @@ > (t > (when (zerop > (dired-shell-command > - (replace-regexp-in-string > - "%o" out-file > - (replace-regexp-in-string > - "%i" (mapconcat #'file-name-nondirectory in-files "= ") > - (cdr rule))))) > + (format-spec > + (cdr rule) > + (list (cons ?o (shell-quote-argument out-file)) > + (cons ?i > + (mapconcat > + (lambda (filename) > + (shell-quote-argument > + (file-name-nondirectory filename))) > + in-files " ")))))) > (message "Compressed %d file(s) to %s" > (length in-files) > (file-name-nondirectory out-file))))))) > > Diff finished. Fri Oct 28 09:01:25 2016 Looks good. Would you like to try writing a commit message too? (see "Commit messages" in CONTRIBUTE). Just a minor style suggestion: In cases like these, I like to use the backquote syntax instead of explicit (list (cons ...)) because it saves a bit of indentation. Have you signed copyrigh assignment for Emacs? This patch is small enough to merge anyway, but if you'll be writing more patches in the future, consider filling out the form at git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.prog= ram to get the process started.