From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#21804: 25.0.50; file-notify-tests failure on Cygwin Date: Fri, 30 Dec 2016 20:16:17 +0100 Message-ID: <87r34pjkhq.fsf@gmx.de> References: <563634F7.2070606@cornell.edu> <8737wpipy8.fsf@gmx.de> <87a8qv6lu2.fsf@gmx.de> <5639818A.5090307@cornell.edu> <87ziyugoqr.fsf@gmx.de> <563A3890.6030707@cornell.edu> <87si4lhaeq.fsf@gmx.de> <563ACB3F.5080709@cornell.edu> <87y4ecnrpp.fsf@gmx.de> <87r34tmv9m.fsf@gmx.de> <87h95pp6dd.fsf@gmx.de> <87zijek10s.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1483125439 19113 195.159.176.226 (30 Dec 2016 19:17:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 30 Dec 2016 19:17:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 21804@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 30 20:17:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cN2fs-0003Wy-4a for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Dec 2016 20:17:08 +0100 Original-Received: from localhost ([::1]:41218 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cN2fx-0006kg-2k for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Dec 2016 14:17:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cN2fq-0006kY-Ob for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2016 14:17:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cN2fm-0003rM-Iq for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2016 14:17:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45218) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cN2fm-0003rE-F7 for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2016 14:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cN2fm-00086E-AJ for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2016 14:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Dec 2016 19:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21804 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21804-submit@debbugs.gnu.org id=B21804.148312539231091 (code B ref 21804); Fri, 30 Dec 2016 19:17:02 +0000 Original-Received: (at 21804) by debbugs.gnu.org; 30 Dec 2016 19:16:32 +0000 Original-Received: from localhost ([127.0.0.1]:60617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cN2fI-00085P-Hq for submit@debbugs.gnu.org; Fri, 30 Dec 2016 14:16:32 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:65231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cN2fG-00085D-RH for 21804@debbugs.gnu.org; Fri, 30 Dec 2016 14:16:31 -0500 Original-Received: from detlef.gmx.de ([93.197.216.210]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MX1hk-1bzxuo0qRQ-00W0aC; Fri, 30 Dec 2016 20:16:18 +0100 In-Reply-To: (Ken Brown's message of "Thu, 29 Dec 2016 15:33:15 -0500") X-Provags-ID: V03:K0:Z3efCQLM2jG6n31d34FsL/E+vrSvtrAIpSjvldsoOB5Is46ve7X H23qbP22I9/I4v+5sUZuwxHLmEzniAUswjLjokCV1E2GAOXdOLSRBjpaesZVL1inYuRRo+o SncHS3+fJUvm1Fmgjq+Qm/gsp8vLrOag0ZHSMFL5OEivxmSZtHoDkQhyPUio+u6KEWw9jfv ooYDP1DrbYoxq8cxGFNoQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:lws5VS1LJaM=:L20TpT3L77/cAR6ew0wEch KBLnruvXGXyqeYKm9QWRyUPDWqc60Ud+5lxQE5YoJQcLKMcWBWAdq3LzSU1gLTM2HxQOCZ9KJ a3hitCjNtM1fHPyEvmiDSTQYEQkiTuBv1YZ+q1AjcK9DCGLuIW04/Ue8oN4seOm4Sx7kVE80W WJsNP/XjFu3Z69UbICvRS+UmXB7/S2QgEC2z6qCMCFvnjw5NrlyUOFFE0LdwAc7LXFSDV4UaR Gd0u3NAbJzx0oN6GJFLmfqwiplc2bIIZMjd4OoFAYUUO+jrMmz7ZmcONWgtnH0E6MQuj2CADp i6yCLkYMIgt10zmV/kdAO1rgA/Bs/bIUd4zfaOsVxX1nH8L3ekFHeb1YFGkUdrjzQXcUcrp8K BUZXwsL+pPQeFA+6F2jvF/FJW2/TFheTrBG+WoEum6YWXJaNqdfTfoqO0TA/JC7W00mjZJRBK h8sQT/lOAXTtOCMhz8v/QFKWiCQJHM6wWFBKvf4B1PEvtK15i0ZFJSlw22URhcV/fMn7/Mfjp Efdpg/EfJI3/0e2EPYIYuHGtSHqxnNfxHthLZs/AHgC1vUENfTcaax5R6EV6UAd35OIwfpRMw uizIYAv5dX0U5J4qs7h69RqFQhDtuWBhMTLgRUiFiXIRGhpkUd3LZUv/8IW18WJC7cCuNBkjw qT+eA2ecVmWjvt7hzfCfo/rOTu4Xn8rfaGPAvfkNB++j446N934Nvim3qHNoiTPPuZsoXAl9I WMaxs6H2QmuHWI9mLQwQT7KC1eo0UTd3Hk+cEorTXoND6Q8aSoFgVpMw933fL/VBomMQTVXC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127592 Archived-At: Ken Brown writes: > Hi Michael, Hi Ken, >> Ken Brown writes: >> I've added the new function Fgfile_monitor_name to gfilenotify.c. It >> tells us the name of the used monitor. In my case (GNU/Linux), it is >> GInotifyFileMonitor. In your case it is GPollFileMonitor. > > Actually it turns out to be GFamFileMonitor on my system, presumably > because I have the gamin package installed. I'm going to see if I can > figure out how GFamFileMonitor works. Next time I have access to a cygwin machine I'll check. However, I wonder whether we need to respect the polling period then. According to , FAM does not poll. > As a quick check, however, I applied the following patch... > > --- a/test/lisp/filenotify-tests.el > +++ b/test/lisp/filenotify-tests.el > @@ -73,7 +73,8 @@ file-notify--test-read-event > ;; gio/gpollfilemonitor.c declares POLL_TIME_SECS 5. So we must > ;; wait at least this time. > ((and (string-equal (file-notify--test-library) "gfilenotify") > - (string-equal (file-notify--test-monitor) "GPollFileMonitor")) > + (or (string-equal (file-notify--test-monitor) "GPollFileMonitor") > + (string-equal (file-notify--test-monitor) "GFamFileMonitor"))) > 7) > ((file-remote-p temporary-file-directory) 0.1) > (t 0.01)))) > > ...and all the inexpensive tests passed. I'll keep playing with this. It's OK for me if you commit this patch. You know cygwin behaviour much better then I do. > Best regards, > > Ken Best regards, Michael.