From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#25391: 24.5; ffap-guesser "stack overflow in regexp matcher" error may crash emacs. Date: Tue, 10 Jan 2017 15:42:22 +0100 Message-ID: <87r34bx9gx.fsf@gmail.com> References: <87vatqc8j1.fsf@gmail.com> <87y3yl1tdp.fsf@users.sourceforge.net> <8760lp8nqv.fsf@gmail.com> <87lgul167v.fsf@users.sourceforge.net> <87y3yk67l8.fsf@gmail.com> <87eg0b1qfj.fsf@users.sourceforge.net> <87mveztmd4.fsf@gmail.com> <8760ln11f3.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1484059396 5536 195.159.176.226 (10 Jan 2017 14:43:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 10 Jan 2017 14:43:16 +0000 (UTC) User-Agent: mu4e 0.9.19; emacs 24.5.1 Cc: 25391@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 10 15:43:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQxdm-0000lH-HN for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Jan 2017 15:43:10 +0100 Original-Received: from localhost ([::1]:47705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQxdq-0000ki-QC for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Jan 2017 09:43:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQxdh-0000jJ-NP for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2017 09:43:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQxde-0005yE-Kz for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2017 09:43:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33086) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cQxde-0005y9-HD for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2017 09:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cQxde-0003C5-5S for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2017 09:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Jan 2017 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25391 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25391-submit@debbugs.gnu.org id=B25391.148405935312239 (code B ref 25391); Tue, 10 Jan 2017 14:43:02 +0000 Original-Received: (at 25391) by debbugs.gnu.org; 10 Jan 2017 14:42:33 +0000 Original-Received: from localhost ([127.0.0.1]:48485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQxdB-0003BL-Ju for submit@debbugs.gnu.org; Tue, 10 Jan 2017 09:42:33 -0500 Original-Received: from mail-wm0-f45.google.com ([74.125.82.45]:35819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQxd9-0003B2-I2 for 25391@debbugs.gnu.org; Tue, 10 Jan 2017 09:42:31 -0500 Original-Received: by mail-wm0-f45.google.com with SMTP id a197so130220094wmd.0 for <25391@debbugs.gnu.org>; Tue, 10 Jan 2017 06:42:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=0Dn5i5cRdYpRGRiwL8aq40+Wy9dQhZVW9F0sV+JEPDo=; b=JqE7L0tm1ZSmFcP8Vp9SxXxaGCCY2QfFpJJDcxJ3LiGS3lFzrWtpbc/NuSa6SYXV9Z MsPZ9SHFRVhSOfjxAT4uyBrv90s70fwovhmKHqOElDzIUE6GKoGM8wdSSJGTXugOU68x ajXrVutcc5UhscvG02eDXcjgakVt+i/HyWA91KLPH5YABkiGyY++t0VINPuyc3PJdt0a 27AnFF7eJ5+xjiCgBkPz4O2TqZUWVN7GVW212CZQDA/rCyGuAMDyTQQuMlWxadFaGyyf 13deftguS6JG8tD8QHxXNMW1RUMZB0EHd6DqsVY0eTJA2CwqRKhEkdw7hx2H6Z0UqM2r 8rOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=0Dn5i5cRdYpRGRiwL8aq40+Wy9dQhZVW9F0sV+JEPDo=; b=qHllCNXsSWcThJ24/EmIpfcaPu+73ElbDFfPftoi1dBl4l6ukftls9OO35tzieBXuk x4RkokKXqv2dCmZ3v53k+liLrPjVulV9HX/NgIYDlJC0tKVM6CZ9gAG6xAiFNvA+/FDC XGhoGqWgM4ftuq12UM7bg3qF4OnTUrMavRIhTQMrAMIHY621MVBqvu1hUiS5x7e0FqJD caFcU2HPZ3TrDlBgRdhjEER70vUCDcrctizkfOAo8sppS0Nd1ZMg3nhxqi6ad3bUDxtq XH7kZrtbFqlVygi2jgDPrAqbD8D0Q6dr1sEozlI5n/z7HhcZHrOWlwHwLpSH7hkY9+uP eIEw== X-Gm-Message-State: AIkVDXJYtlw6VFsYqf2NCZA4Ddaea2IHqMbuqJ2JRhr+rSygnNQQaUdszXO+xMR4ud4kEA== X-Received: by 10.28.66.7 with SMTP id p7mr2212588wma.64.1484059345740; Tue, 10 Jan 2017 06:42:25 -0800 (PST) Original-Received: from dell-14z ([37.164.114.18]) by smtp.gmail.com with ESMTPSA id c187sm4108488wmd.13.2017.01.10.06.42.24 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 10 Jan 2017 06:42:24 -0800 (PST) In-reply-to: <8760ln11f3.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127960 Archived-At: npostavs@users.sourceforge.net writes: > Yes, although that's also true before my patch. So `ffap-gopher-regexp' > never actually supported being changed. I'm not sure if it's a good > idea to add support for that. I think it is, gopher is not widely used AFAIK, and allowing disabling it would avoid needless search in most cases, thus it make it consistent with other ffap* fns that can be disabled; I have a lot of complains at helm with ffap annoyances and having more flexibility on this is interesting. > + (when (stringp ffap-gopher-regexp) That's what I expected. Thanks. -- Thierry