From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: 25482@debbugs.gnu.org
Subject: bug#25482: Fwd: Re: bug#25482: 26.0.50; Allow setting `query-replace-from-to-separator` to nil
Date: Fri, 20 Jan 2017 06:42:10 +0100 [thread overview]
Message-ID: <87r33yb83x.fsf@gmail.com> (raw)
In-Reply-To: <871svzzcn4.fsf@gmail.com>
Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> Sorry, I don't think I follow: you should be able to set this variable
>> to " -> ", a string, to get the old behavior and avoid non-ASCII
>> strings in your minibuffer-history.
>
> No, you don't have the same behavior, you endup with a non ascii string
> which goes to minibuffer-history, so the behavior is not as emacs-24.5
> if you set this variable to " -> ".
>
>> So why did you need the value of nil?
>
> Because when it is nil the string is not added to history, just like in
> 24.5.
>
>>> + (when (stringp query-replace-from-to-separator)
>>> + (setq query-replace-from-to-separator
>>> + (propertize (if (char-displayable-p
>>> + (string-to-char query-replace-from-to-separator))
>>
>> This doesn't look right: string-to-char will return the blank
>> character, which is the first character of " → ", and I don't think
>> you meant that.
>
> Yes, you are right, thanks, however see how the actual code is wrong,
> what if someone set the separator to another unicode string.
>
>> In any case, this looks more complex than it has to be, because you
>> for some reason want to have the nil value. Please elaborate on the
>> need for that.
>
> To retrieve the same behavior as in emacs-24.5, see above.
--
Thierry
next prev parent reply other threads:[~2017-01-20 5:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 8:18 bug#25482: 26.0.50; Allow setting `query-replace-from-to-separator` to nil Thierry Volpiatto
2017-01-19 16:01 ` Eli Zaretskii
2017-01-20 5:54 ` Thierry Volpiatto
[not found] ` <87vatac0a2.fsf@gmail.com>
2017-01-20 5:42 ` Thierry Volpiatto [this message]
2017-01-20 7:56 ` Eli Zaretskii
2017-01-20 11:35 ` Thierry Volpiatto
2017-01-20 13:06 ` Eli Zaretskii
2017-01-20 15:16 ` Thierry Volpiatto
2017-01-22 19:06 ` Eli Zaretskii
2017-01-22 20:14 ` Thierry Volpiatto
2017-01-22 20:32 ` Eli Zaretskii
2017-01-23 8:13 ` Thierry Volpiatto
2017-01-28 6:50 ` Thierry Volpiatto
2017-01-28 7:31 ` Eli Zaretskii
2017-01-28 10:43 ` Thierry Volpiatto
2017-01-28 11:01 ` Eli Zaretskii
2017-01-28 11:23 ` Thierry Volpiatto
2017-01-28 13:50 ` Eli Zaretskii
2017-01-28 16:46 ` Thierry Volpiatto
[not found] ` <87k29ey93n.fsf@mail.linkov.net>
2017-01-29 3:42 ` Eli Zaretskii
2017-01-30 0:16 ` Juri Linkov
2017-02-13 0:37 ` Juri Linkov
2017-02-13 2:24 ` Glenn Morris
2017-02-13 3:04 ` Glenn Morris
2017-02-13 5:51 ` Eli Zaretskii
2017-02-14 0:04 ` Juri Linkov
2017-02-14 0:24 ` Drew Adams
2017-02-18 10:45 ` Eli Zaretskii
2017-02-13 5:53 ` Thierry Volpiatto
2017-02-16 20:43 ` Juri Linkov
2017-01-21 10:05 ` Thierry Volpiatto
2017-01-21 10:24 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r33yb83x.fsf@gmail.com \
--to=thierry.volpiatto@gmail.com \
--cc=25482@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.