all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master c8ee570: Suppress undesired error messages in filenotify-tests.el
Date: Wed, 08 Feb 2017 19:00:02 +0100	[thread overview]
Message-ID: <87r3387ecd.fsf@gmx.de> (raw)
In-Reply-To: <5fh944r37s.fsf@fencepost.gnu.org> (Glenn Morris's message of "Wed, 08 Feb 2017 12:40:07 -0500")

Glenn Morris <rgm@gnu.org> writes:

>> --- a/test/lisp/filenotify-tests.el
>> +++ b/test/lisp/filenotify-tests.el
>> @@ -665,6 +665,9 @@ delivered."
>>  (setq auto-revert-notify-exclude-dir-regexp "nothing-to-be-excluded"
>>        auto-revert-remote-files t
>>        auto-revert-stop-on-user-input nil)
>> +;; In the remote case, `vc-refresh-state' returns undesired error
>> +;; messages.  Let's suppress them.
>> +(defalias 'vc-refresh-state 'ignore)
>
>
> Hi - this means that loading filenotify-tests.el breaks Emacs VC normal
> operation for the rest of the session, which seems undesirable. Is there
> an alternative solution?

I'm aware of the problem. I've tried to use `cl-letf' in the
test. Unfortunately, this doesn't work, because the revert is called
when an event arrives; the `cl-letf' settings do not work there.

Hmmm. Usually, the test is not called by average Emacs users, so I
believe it would be acceptable. If not, we must find something else.

Best regards, Michael.



  reply	other threads:[~2017-02-08 18:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170207204223.17232.75787@vcs0.savannah.gnu.org>
     [not found] ` <20170207204224.F29C22301C@vcs0.savannah.gnu.org>
2017-02-08 17:40   ` master c8ee570: Suppress undesired error messages in filenotify-tests.el Glenn Morris
2017-02-08 18:00     ` Michael Albinus [this message]
2017-02-08 18:35       ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3387ecd.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.