From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jarno Malmari Newsgroups: gmane.emacs.devel Subject: Re: Refactor digest authentication in url-auth Date: Sun, 05 Mar 2017 17:54:01 +0200 Message-ID: <87r32bhg86.fsf@vabi> References: <1487106777-17025-1-git-send-email-jarno@malmari.fi> <834lzrrbwu.fsf@gnu.org> <837f4esla4.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1488729282 11215 195.159.176.226 (5 Mar 2017 15:54:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 5 Mar 2017 15:54:42 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 05 16:54:39 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckYUU-0002FI-IO for ged-emacs-devel@m.gmane.org; Sun, 05 Mar 2017 16:54:34 +0100 Original-Received: from localhost ([::1]:39346 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckYUa-0003vx-Ox for ged-emacs-devel@m.gmane.org; Sun, 05 Mar 2017 10:54:40 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckYTd-0003e4-IB for emacs-devel@gnu.org; Sun, 05 Mar 2017 10:53:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckYTY-00087n-NS for emacs-devel@gnu.org; Sun, 05 Mar 2017 10:53:41 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47829) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ckYTY-00086V-IW for emacs-devel@gnu.org; Sun, 05 Mar 2017 10:53:36 -0500 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 738CF20655 for ; Sun, 5 Mar 2017 10:53:34 -0500 (EST) Original-Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Sun, 05 Mar 2017 10:53:34 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=malmari.fi; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=pbcRHSB2uuWXSuevnMQc3A2yRJI=; b=UZweIl UYhCwgWvtS/DtTBVTIOdrqLTni9xvhkE4j7FT9zn788d+a8WTowRgdg0H45bANAv l72vW0lB6/2/ais/YvQ2P5p6ysc21yGRA8Vmdn6fdzQF0D7z/dbDplrxYhxU5FkR rkb1zsbneHKhsF4IhjSL01gneEsgBgdm3vd98= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=pbcRHSB2uuWXSu evnMQc3A2yRJI=; b=QEk6jgkxpn+C7CSOPcd7dJ/UNC4YfhHYBJJLLwr5UHKpPM Tsh7QGdJaR7WjWZGpeJj+1J6QPfDeKGOMWH8cT3q45qS2ZKpP6waH73ZeI2AJqg3 fvoYqyoF2V91k8W1cWZAe4W/XOnhU/L/WkAw60aiJ6cEWVqattj+jCxwfz2iI= X-ME-Sender: X-Sasl-enc: AQ19sBY3oBGBWBmKNawiuRlhivXOoC2OlHtzu+M0hTYn 1488729212 Original-Received: from vabi (a88-113-156-118.elisa-laajakaista.fi [88.113.156.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 26B847E31E for ; Sun, 5 Mar 2017 10:53:32 -0500 (EST) In-Reply-To: <837f4esla4.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Feb 2017 10:54:27 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212769 Archived-At: Eli Zaretskii writes: For what it's worth I'd consider the refactoring patch (PATCH 1/2) quite safe to merge in and would suggest prioritizing reviewing efforts on the latter patch (PATCH 2/2) that contains the actual QOP feature. > Ping! > >> Date: Sat, 18 Feb 2017 13:11:45 +0200 >> From: Eli Zaretskii >> Cc: emacs-devel@gnu.org >> >> > From: Jarno Malmari >> > Cc: eliz@gnu.org >> > Date: Tue, 14 Feb 2017 23:12:55 +0200 >> > >> > Here's a revised patch set for the earlier digest auth work. >> > >> > * Changed comments to follow gnu coding standards: two spaces between >> > sentences, capital letter at beginning, period at the end, and the >> > like >> > >> > * Removed bunch of references to RFC 2617 from docstrings. Still to >> > understand what's being done requires you to pick that up, but >> > mentioning it repeatedly doesn't help too much. >> > >> > * Changed the format of commit messages. >> > >> > * There were talk about what to call the "path component of an URI". >> > Is it file-name part, directory, path, or URI path. I tried avoiding >> > mentioning it but a few references remains and I ended up choosing >> > "directory" since that's what's used in functions used here, namely: >> > >> > (url-file-directory (url-filename url)) >> > >> > The `url-file-directory' is defined in url-util with docstring: >> > >> > "Return the directory part of FILE, for a URL." >> > >> > Patches that follows: >> > [PATCH 1/2] Refactor digest authentication in url-auth >> > [PATCH 2/2] Initial implementation for HTTP Digest qop for url >> >> Thanks. >> >> Could someone familiar with url-auth.el please review these?