From: Jarno Malmari <jarno@malmari.fi>
To: emacs-devel@gnu.org
Subject: Re: Refactor digest authentication in url-auth
Date: Sun, 05 Mar 2017 17:54:01 +0200 [thread overview]
Message-ID: <87r32bhg86.fsf@vabi> (raw)
In-Reply-To: <837f4esla4.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Feb 2017 10:54:27 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
For what it's worth I'd consider the refactoring patch (PATCH 1/2) quite
safe to merge in and would suggest prioritizing reviewing efforts on the
latter patch (PATCH 2/2) that contains the actual QOP feature.
> Ping!
>
>> Date: Sat, 18 Feb 2017 13:11:45 +0200
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: emacs-devel@gnu.org
>>
>> > From: Jarno Malmari <jarno@malmari.fi>
>> > Cc: eliz@gnu.org
>> > Date: Tue, 14 Feb 2017 23:12:55 +0200
>> >
>> > Here's a revised patch set for the earlier digest auth work.
>> >
>> > * Changed comments to follow gnu coding standards: two spaces between
>> > sentences, capital letter at beginning, period at the end, and the
>> > like
>> >
>> > * Removed bunch of references to RFC 2617 from docstrings. Still to
>> > understand what's being done requires you to pick that up, but
>> > mentioning it repeatedly doesn't help too much.
>> >
>> > * Changed the format of commit messages.
>> >
>> > * There were talk about what to call the "path component of an URI".
>> > Is it file-name part, directory, path, or URI path. I tried avoiding
>> > mentioning it but a few references remains and I ended up choosing
>> > "directory" since that's what's used in functions used here, namely:
>> >
>> > (url-file-directory (url-filename url))
>> >
>> > The `url-file-directory' is defined in url-util with docstring:
>> >
>> > "Return the directory part of FILE, for a URL."
>> >
>> > Patches that follows:
>> > [PATCH 1/2] Refactor digest authentication in url-auth
>> > [PATCH 2/2] Initial implementation for HTTP Digest qop for url
>>
>> Thanks.
>>
>> Could someone familiar with url-auth.el please review these?
next prev parent reply other threads:[~2017-03-05 15:54 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 12:25 url-digest-auth QOP implementation Jarno Malmari
2015-05-10 17:10 ` Lars Magne Ingebrigtsen
2015-05-11 19:17 ` Patches for qop=auth implementation for url-digest-auth Jarno Malmari
2015-05-11 19:17 ` [PATCH 1/3] Test for url-auth Jarno Malmari
2015-05-11 19:17 ` [PATCH 2/3] Refactor digest authentication in url-auth Jarno Malmari
2015-05-11 19:17 ` [PATCH 3/3] Initial implementation for HTTP Digest qop for url Jarno Malmari
2015-05-18 15:47 ` Patches for qop=auth implementation for url-digest-auth Lars Magne Ingebrigtsen
2015-05-26 17:13 ` Jarno Malmari
2015-08-08 8:14 ` Jarno Malmari
2015-08-30 11:52 ` Lars Magne Ingebrigtsen
2015-08-30 16:17 ` [PATCH 1/3] Test for url-auth Jarno Malmari
2015-08-30 16:17 ` [PATCH 2/3] Refactor digest authentication in url-auth Jarno Malmari
2015-08-30 16:17 ` [PATCH 3/3] Initial implementation for HTTP Digest qop for url Jarno Malmari
2016-02-07 5:35 ` [PATCH 1/3] Test for url-auth Lars Ingebrigtsen
2016-02-07 15:57 ` Eli Zaretskii
2016-02-08 4:57 ` Lars Ingebrigtsen
2016-02-08 5:29 ` Lars Ingebrigtsen
2016-09-08 19:51 ` Jarno Malmari
2016-09-08 19:51 ` [PATCH 1/3] Revert parts of url-auth test Jarno Malmari
2016-09-08 19:51 ` [PATCH 2/3] Refactor digest authentication in url-auth Jarno Malmari
2016-09-08 19:51 ` [PATCH 3/3] Initial implementation for HTTP Digest qop for url Jarno Malmari
2016-11-12 22:03 ` [PATCH 1/3] Test for url-auth Jarno Malmari
2016-11-12 22:03 ` [PATCH 1/2] Refactor digest authentication in url-auth Jarno Malmari
2016-11-12 22:03 ` [PATCH 2/2] Initial implementation for HTTP Digest qop for url Jarno Malmari
2016-11-13 11:36 ` [PATCH 1/3] Test for url-auth Jarno Malmari
2016-11-13 11:36 ` [PATCH 1/2] Refactor digest authentication in url-auth Jarno Malmari
2016-11-13 15:53 ` Eli Zaretskii
2016-11-13 21:57 ` Jarno Malmari
2016-11-14 3:42 ` Eli Zaretskii
2016-11-14 4:34 ` Yuri Khan
2016-11-14 15:28 ` Eli Zaretskii
2017-02-14 21:12 ` Jarno Malmari
2017-02-14 21:12 ` [PATCH 1/2] " Jarno Malmari
2017-02-14 21:12 ` [PATCH 2/2] Initial implementation for HTTP Digest qop for url Jarno Malmari
2017-02-18 11:11 ` Refactor digest authentication in url-auth Eli Zaretskii
2017-02-25 8:54 ` Eli Zaretskii
2017-03-05 15:54 ` Jarno Malmari [this message]
2017-03-05 16:06 ` Eli Zaretskii
2017-03-11 10:08 ` Eli Zaretskii
2017-03-25 16:08 ` Eli Zaretskii
2017-03-27 19:47 ` Jarno Malmari
2017-03-27 19:47 ` [PATCH 1/2] " Jarno Malmari
2017-03-27 19:47 ` [PATCH 2/2] Initial implementation for HTTP Digest qop for url Jarno Malmari
2017-04-01 6:24 ` Refactor digest authentication in url-auth Eli Zaretskii
2016-11-13 11:36 ` [PATCH 2/2] Initial implementation for HTTP Digest qop for url Jarno Malmari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r32bhg86.fsf@vabi \
--to=jarno@malmari.fi \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.