From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] [debbugs] Add mu4e support. Date: Fri, 28 Apr 2017 15:22:01 +0200 Message-ID: <87r30cwtty.fsf@detlef> References: <87y3ursale.fsf@elephly.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1493385798 14472 195.159.176.226 (28 Apr 2017 13:23:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 28 Apr 2017 13:23:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Ricardo Wurmus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 28 15:23:13 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d45rd-0003dP-CT for ged-emacs-devel@m.gmane.org; Fri, 28 Apr 2017 15:23:13 +0200 Original-Received: from localhost ([::1]:37100 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d45rj-0003Yo-5W for ged-emacs-devel@m.gmane.org; Fri, 28 Apr 2017 09:23:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d45qj-0003Xk-9P for emacs-devel@gnu.org; Fri, 28 Apr 2017 09:22:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d45qf-0002BB-Av for emacs-devel@gnu.org; Fri, 28 Apr 2017 09:22:17 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:63229) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d45qe-00028c-W1 for emacs-devel@gnu.org; Fri, 28 Apr 2017 09:22:13 -0400 Original-Received: from detlef.gmx.de ([212.91.249.215]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LvUwp-1e2y3V3BNz-010aeQ; Fri, 28 Apr 2017 15:22:02 +0200 In-Reply-To: <87y3ursale.fsf@elephly.net> (Ricardo Wurmus's message of "Sun, 23 Apr 2017 12:05:17 +0200") X-Provags-ID: V03:K0:V7LyYNZa0UjrdJVLhJyGgC3HXHwfvcNI+mGrTZM0AjCMwyAwz/d 8k4FfnidI0YzD7B8+5v5xV2Qml6ghdNVyIC4hjxJmBbMagqT9IKaPwSP3URf5JVSxI05uw/ G34jjjWN8DSKUhXt21QNJ1KfM4dav/+hrMwl1e7fPmwyx2yh7NYlHju6hJ/+FCJExIY8Tf0 YjuP6IgOeFCq7hwkVndjg== X-UI-Out-Filterresults: notjunk:1;V01:K0:zUEqPWckpdY=:eJxrp1GJJBqdWdbCjrZo7j B978WJx2zcRGVfCQ1ylTuFQh4t9WvFgkWgHJkrSMnLUp97dLX7yO9PwYe9sdpxnj85FjBPeYq Xj4tWwYtqo6oGEBAJKN/1C+DUL6t+sOp7wCK2NubkOxDymBMXOhOJcO7uf0YKeC4WNKH0SOa6 DhQqh8z7vjSwUdN/nzVRs7oLWNXB648at96Vh52oFTc7nomqCVfiK9MVg0HOc8P9TTpcR8Qp8 0KhCEnf0SzRbCI00qFjIZ2G5xWINORcEHvfMeX54j2HKb5fazbX1T2+a9CaicWZUB30Olc28p cFvOdm+ifCG+7pYUiaJPK78PLh9R6GM+oGVAzvlnEvqm/fE/yXNi/jhcDKpvEbaO9mTFFeCjF np7ZweblhkCpm2xhjH8imJ/gKtr77qF+48Oh/D89/2S9vQ8JWD7z7BSRKloKyWxk1rFqQk3s6 f2RjhTusiaS+p3iZVTzeh/jlwOpq76VyYVWagaE04AgEbJBV5Wu8HHIwTu+6wzFch/eB1cZEt Emu0BOHZVKOGnW4j0gJqpxhUR3TiC0qf2yAvMgvSsW0XjWFYKboqlulAu+XzP4d4sBo6rKNhi sgXbBbBmH9HDpWU9mb1YTrfGWpnE+weDlYeDaPfASW6tP94/jAdpMOad17scoCyZin9bJxUls m1BiQm0jEX6ZNlAABOWWP3wl4yJwemkHody5R9wXNll53wXcEI/5cj70BX+Rr4Zj0yHPn0GZN 96TXWCxLqFgM5FiJAJAe4HloIxf/QuYa6RbU56a8HhZUiuv8OZWsaquiyZ3Lzm9NqS0aHMz3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.21 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214388 Archived-At: Ricardo Wurmus writes: > Hi, Hi Ricardo, > this patch is for the debbugs.el EPLA package. It adds the mail client > =E2=80=9Cmu4e=E2=80=9D as a debbugs-gnu mail backend. > > When =E2=80=9Cdebbugs-gnu-mail-backend=E2=80=9D is set to =E2=80=9C'mu4e= =E2=80=9D, visiting a bug will > download the bug=E2=80=99s mbox file, turn it into a separate Maildir tre= e under > =E2=80=9Cmu4e-maildir=E2=80=9D called =E2=80=9Cemacs-debbugs.1234=E2=80= =9D where =E2=80=9C1234=E2=80=9D is the bug id, > runs =E2=80=9Cmu index=E2=80=9D (synchronously) to update the mail databa= se, and then > shows the emails as usual with mu4e. > > I=E2=80=99ve been using this patch for a while with satisfactory results. I've played with this. First of all, I had to install mu 0.9.9.5 from the source tarball; I didn't find it as package. I've compiled it, there were errors in compiling mu and warnings in compiling mu4e. Well, I don't care too much; I don't want to use it myself. After applying your patch to debbugs-gnu.el, there are further warnings: --8<---------------cut here---------------start------------->8--- In toplevel form: packages/debbugs/debbugs-gnu.el:1346:1:Warning: Unused lexical argument =E2=80=98merged=E2=80=99 In debbugs-read-emacs-bug-with-mu4e: packages/debbugs/debbugs-gnu.el:1354:27:Warning: reference to free variable =E2=80=98mu4e-maildir=E2=80=99 packages/debbugs/debbugs-gnu.el:1366:13:Warning: assignment to free variable =E2=80=98start=E2=80=99 packages/debbugs/debbugs-gnu.el:1369:15:Warning: assignment to free variable =E2=80=98end=E2=80=99 packages/debbugs/debbugs-gnu.el:1374:57:Warning: reference to free variable =E2=80=98start=E2=80=99 packages/debbugs/debbugs-gnu.el:1371:21:Warning: reference to free variable =E2=80=98end=E2=80=99 --8<---------------cut here---------------end--------------->8--- And indeed, after setting debbugs-gnu-mail-backend to 'mu4e, I've got the error debbugs-gnu-select-report: Symbol=E2=80=99s value as variable is void: mu4e= -maildir So I've loaded mu4e.el. Now I get the error debbugs-read-emacs-bug-with-mu4e: Wrong number of arguments: #[(&optional e= xpr prompt edit ignore-history) "=C3=84 The rest of the backtrace cannot be added to this email due to non-ASCII characters. Some comments to your code: > +(defun debbugs-read-emacs-bug-with-mu4e (id status merged) > + "Read email exchange for debbugs bug ID. > +STATUS is the bug's status list. > +MERGED is the list of bugs merged with this one." > + (let* ((bug-str (number-to-string id)) > + (tmpdir "/tmp") Pls use temporary-file-directory. > + (mbox (concat tmpdir "/bug-" bug-str ".mbox")) > + (subdir (concat "/emacs-debbugs." bug-str)) > + (maildir (concat mu4e-maildir subdir))) > + ;; Create temporary maildir structure > + (dolist (dir '("cur" "new" "tmp")) > + (make-directory (concat maildir "/" dir) t)) Please use expand-file-name where appropriate. Could you, pls, try to fix these problems? And don't forget the contribution to debbugs-ug.texi. > Ricardo Best regards, Michael.