all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 26969@debbugs.gnu.org, Justin Burkett <justin@burkett.cc>
Subject: bug#26969: 26.0.50; diff-changed invisible by default
Date: Mon, 22 May 2017 23:19:02 +0300	[thread overview]
Message-ID: <87r2zgzlu1.fsf@localhost> (raw)
In-Reply-To: <jwvmvabmh59.fsf@ceviche> (Stefan Monnier's message of "Wed, 17 May 2017 15:12:50 -0400")

> Nowadays the `diff-changed` face is defined to be "invisible" (i.e. the
> text is displayed identically with or without that face).
> IOW it can only be used as a parent of diff-added or diff-removed (or
> some other such face).
>
> This is a bad idea since in cases such as vdiff.el where some changes
> are neither additions nor removals, it would make sense to highlight the
> buffer as just "changed" and using that face is a natural choice.
>
> I suggest the patch below for that.  It is designed such that it should
> make no visible difference to users of diff-added and diff-removed since
> these faces override the parts that are set by my patch in diff-changed.

This might break a fragile condition in ‘diff-use-changed-face’
that was created to support backward-compatibility of previously
customized faces.  But maybe it's time to simplify the logic
of diff face definitions.

> Another option would be to introduce a new face (not sure how to call
> it, maybe diff-unspecified-change, maybe?) which inherits from
> diff-changed as well.

Then authors of external packages have to wait for the next Emacs release
to start using it.

>  (defface diff-changed
> -  '((t nil))
> +  '((((class color) (min-colors 88) (background light))
> +     :background "grey90")
> +    (((class color) (min-colors 88) (background dark))
> +     :background "grey20")
> +    (((class color))
> +     :foreground "grey"))

I wonder why grey?  It used to be yellow.





  reply	other threads:[~2017-05-22 20:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17 19:12 bug#26969: 26.0.50; diff-changed invisible by default Stefan Monnier
2017-05-22 20:19 ` Juri Linkov [this message]
2017-05-22 22:10   ` Stefan Monnier
2020-08-24 15:10 ` Lars Ingebrigtsen
2021-08-13 13:37   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2zgzlu1.fsf@localhost \
    --to=juri@linkov.net \
    --cc=26969@debbugs.gnu.org \
    --cc=justin@burkett.cc \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.