From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#25599: Why edit markers after insert? Date: Sun, 11 Jun 2017 14:10:08 -0400 Message-ID: <87r2yqv1j3.fsf@users.sourceforge.net> References: <28211825-9989-bd18-1f53-891506af9adf@yandex.ru> <8737en1xdg.fsf@linux-m68k.org> <13792565-9d57-7546-0a81-09aec09a7705@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1497204561 31343 195.159.176.226 (11 Jun 2017 18:09:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 11 Jun 2017 18:09:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 25599@debbugs.gnu.org, Andreas Schwab , nitish chandra To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 11 20:09:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dK7IY-0007er-3D for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Jun 2017 20:09:14 +0200 Original-Received: from localhost ([::1]:34847 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dK7Ia-0003Iq-G9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Jun 2017 14:09:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dK7IR-0003Ij-Mx for bug-gnu-emacs@gnu.org; Sun, 11 Jun 2017 14:09:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dK7IM-00026a-KT for bug-gnu-emacs@gnu.org; Sun, 11 Jun 2017 14:09:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38721) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dK7IM-00026R-Ga for bug-gnu-emacs@gnu.org; Sun, 11 Jun 2017 14:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dK7IM-0005VL-7z for bug-gnu-emacs@gnu.org; Sun, 11 Jun 2017 14:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Jun 2017 18:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25599-submit@debbugs.gnu.org id=B25599.149720452021131 (code B ref 25599); Sun, 11 Jun 2017 18:09:02 +0000 Original-Received: (at 25599) by debbugs.gnu.org; 11 Jun 2017 18:08:40 +0000 Original-Received: from localhost ([127.0.0.1]:41398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dK7I0-0005Uk-CO for submit@debbugs.gnu.org; Sun, 11 Jun 2017 14:08:40 -0400 Original-Received: from mail-it0-f52.google.com ([209.85.214.52]:37560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dK7Hx-0005UU-Qu for 25599@debbugs.gnu.org; Sun, 11 Jun 2017 14:08:38 -0400 Original-Received: by mail-it0-f52.google.com with SMTP id m47so13630886iti.0 for <25599@debbugs.gnu.org>; Sun, 11 Jun 2017 11:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Sen2zgBGudQT6aBOwUeYlgbzPdBD5yknsgf9aLVYhy4=; b=p8CsNVlxlnqatzQbu49dad152PthiOZHnpRY7TxNyfWozfGsPzr3pK1dM8bxMIUaiV pSy8syiNXoTN8B7dt33tIc307kaLtWbOoTg5gNtX+BuTFQgzwZoi5ESR2/2e7V6tgDC5 c7Zv1Y8atdBjaKj6nKXk6TfeZVfko76F2vBWnxi0iqDGIOZHFJK8OFdTKnfynbfFAbuR ntHjMAS/6Rg/6NYI3GV6JX7bVKlZeurrPGQXv0VmZMEOHdM1eHUx8+QVS9o+sgXS6L97 +kfnrS44yJlmZam4U5Od/GBjVJauSre6LWGaAHRJznvKHDkKiKflJ31xQ8z1gYd4kjky gNcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Sen2zgBGudQT6aBOwUeYlgbzPdBD5yknsgf9aLVYhy4=; b=BefIdtpsOAdzuJgTukWq28+UkhXRM4EzuVTNxHmcKiFZTHJ+wRdmBFow5Ko7mJNRcJ gVec9BQYCmXVCNrMXa3gON+v6U0QoloqqsoJZ+qjJMJ1daGPOxkDzayAord6tmvIsdHx c4Zwid49K675zZ4vLNFz+KJUb8rqSqHtZxTzYxEwaD3BIAm2m2c02y6/s090RXIXcWlN Lq02PcgLzVEXgHKgVN4H+xWMV3oPlO0oBCFJVvPtK1fDTkBw+suQEl73ag/IpCtGhOfO PFliRf++E6+yURBAFaXDxV6GVdnwL4GnRIbNd/Wn242D7kVaJydIDavCzAUH06opyEFq kRXQ== X-Gm-Message-State: AODbwcDAW5h2VfvSZE5LfLWh6lBMfdZy+tcYhNMCvpZJOuvu33CkM4/3 kpazXIoENETUte+S X-Received: by 10.36.25.193 with SMTP id b184mr8790528itb.75.1497204512003; Sun, 11 Jun 2017 11:08:32 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id f19sm3575824ioe.1.2017.06.11.11.08.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Jun 2017 11:08:30 -0700 (PDT) In-Reply-To: <13792565-9d57-7546-0a81-09aec09a7705@yandex.ru> (Dmitry Gutov's message of "Sun, 14 May 2017 04:12:58 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133478 Archived-At: Dmitry Gutov writes: > On 09.03.2017 21:39, nitish chandra wrote: >> The problem is being caused by insert invalidating some of the >> markers. So before adjusting the markers, we can check if the marker >> is valid or not. Following is a patch that does this. > > Thanks, Nitish. The patch works for me. > > Could someone else more familiar with undo give a second opinion, please? Not that I'm very familiar with the undo code, but the patch seems obviously correct to me. + ;; insert might have invalidated some of the + ;; markers. We update only the currently valid + ;; markers. See bug#25599 I would augment the comment to specifically mention modification hooks though (missing double spacing too).