From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#23561: epg tests are (almost) always skipped Date: Thu, 29 Jun 2017 23:38:47 -0400 Message-ID: <87r2y2kuuw.fsf@users.sourceforge.net> References: <4nwpmtfb9p.fsf@fencepost.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1498793893 16316 195.159.176.226 (30 Jun 2017 03:38:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 30 Jun 2017 03:38:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: Daiki Ueno , 23561@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 30 05:38:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQmkw-0003qa-6a for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Jun 2017 05:38:06 +0200 Original-Received: from localhost ([::1]:42352 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQml1-0005uW-9G for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 Jun 2017 23:38:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQmkv-0005tn-JM for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2017 23:38:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dQmks-0003MT-HR for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2017 23:38:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42640) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dQmks-0003MG-D5 for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2017 23:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dQmkr-0006Nb-Rr for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2017 23:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Jun 2017 03:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23561 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23561-submit@debbugs.gnu.org id=B23561.149879384024473 (code B ref 23561); Fri, 30 Jun 2017 03:38:01 +0000 Original-Received: (at 23561) by debbugs.gnu.org; 30 Jun 2017 03:37:20 +0000 Original-Received: from localhost ([127.0.0.1]:45317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQmkB-0006Ma-P5 for submit@debbugs.gnu.org; Thu, 29 Jun 2017 23:37:20 -0400 Original-Received: from mail-it0-f44.google.com ([209.85.214.44]:38423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQmk9-0006MH-Px; Thu, 29 Jun 2017 23:37:18 -0400 Original-Received: by mail-it0-f44.google.com with SMTP id k192so18088093ith.1; Thu, 29 Jun 2017 20:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ubo7ifhao6hn3Kj+trrg8vx6wTxau9ohoQIqzAnlXks=; b=BAOKQzZD5kJjx2UNMMMeAmuGnRi83Odktfgjx+veY+Fnnis8rGD4T6xyluRvUHlG+h GitNAo7sbyKNBy8QAYm2iDGoPdd4oQoeKQezBvzlJ3fxHlXiV0zHWFtugJsRr4QnZp8w YBoKTFvmOqeVpa9XSfDM3Y1fFmOvYp2RlnaJ3L6V9nkAcYZZyweNsPSkdhfkF8E+vLew A4Q44B6rQdGnfjQ/ng7seWwF+NXploQHVLOC+NQhJp1ax9++N6XMv575pSZEt7oNaE+1 AJZjy6NRg7ikV5qr6aANqYQxiZEwspO96TrrMf0Umczk8t9Df4r6zDeyzjFvdJeD6IcI 0Owg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=ubo7ifhao6hn3Kj+trrg8vx6wTxau9ohoQIqzAnlXks=; b=Y9gGglr2QxCwOXaL41q4hJeVIeAX5y7dXClPNLpYwn1XvQ+Xul9KxgvFqfU02h07WD G+wmeSlUDhLYEfgxXK6oN26zh90rbgq9kMDQgyYAe7Qtk1f7PVlOl/FqcY2YgwrhOLeE ad14d3YzAMkGoIVXHhw1qPeUOAprh526VuVjpYt3wXCvwC8HUJ2QlKHVbCRgmiuEMC+O Bfd0AotpwiieoRr5ZIsepPvdbMgxcI6Lxv4VSrnCNN/reZ/osqIB8t9RbGUo0UgraECG zOUDgMwkWi5elfXAGZL++iYarTg8715w1NIM3ZaZKmdbXpOD9BAApnMiXQDIpSTnDM7G JIxw== X-Gm-Message-State: AKS2vOyNkQNVTe8gtXmFvK7RxIbrtbglm90+fOpGcwITWvuee04EiSz0 PkxF7ug5jJ08E5wV X-Received: by 10.36.92.143 with SMTP id q137mr17866750itb.23.1498793832085; Thu, 29 Jun 2017 20:37:12 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 94sm3692674ior.0.2017.06.29.20.37.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Jun 2017 20:37:11 -0700 (PDT) In-Reply-To: (Glenn Morris's message of "Wed, 25 May 2016 13:07:35 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134048 Archived-At: --=-=-= Content-Type: text/plain tags 23561 + patch quit Glenn Morris writes: > Thanks. Works for me on RHEL 7.2, but on hydra the tests are still skipped. > > From previous investigation, they have a "gpg2" binary that is 2.0.27 > and a "gpg" one that is 1.4 (?). Since Bug#23619 is fixed, I think it's just a matter of removing the check for gpg 1.4.3, I'll push the following in a couple of days if there are no objections. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Don-t-skip-epg-tests-Bug-23561.patch Content-Description: patch >From 67b8a8abc33e694ca275dff3586b605a89f07c62 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Thu, 29 Jun 2017 23:28:15 -0400 Subject: [PATCH] Don't skip epg tests (Bug#23561) * test/lisp/epg-tests.el (with-epg-tests): Ignore REQUIRE-PASSPHRASE parameter, since we supply the passphrase via pinentry-program for all GPG versions (as of 2017-02-28 "Fix epg-tests with dummy-pinentry program (Bug#23619)"). (epg-tests-program-alist-for-passphrase-callback): Remove. --- test/lisp/epg-tests.el | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/test/lisp/epg-tests.el b/test/lisp/epg-tests.el index 9dd093e792..36db478801 100644 --- a/test/lisp/epg-tests.el +++ b/test/lisp/epg-tests.el @@ -30,17 +30,8 @@ (defvar epg-tests-data-directory (expand-file-name "data/epg" (getenv "EMACS_TEST_DIRECTORY")) "Directory containing epg test data.") -(defconst epg-tests-program-alist-for-passphrase-callback - '((OpenPGP - nil - ("gpg" . "1.4.3")))) - -(defun epg-tests-find-usable-gpg-configuration (&optional require-passphrase) - (epg-find-configuration - 'OpenPGP - 'no-cache - (if require-passphrase - epg-tests-program-alist-for-passphrase-callback))) +(defun epg-tests-find-usable-gpg-configuration (&optional _require-passphrase) + (epg-find-configuration 'OpenPGP 'no-cache)) (defun epg-tests-passphrase-callback (_c _k _d) ;; Need to create a copy here, since the string will be wiped out -- 2.11.1 --=-=-=--