From: npostavs@users.sourceforge.net
To: Glenn Morris <rgm@gnu.org>
Cc: Daiki Ueno <ueno@gnu.org>, 23561@debbugs.gnu.org
Subject: bug#23561: epg tests are (almost) always skipped
Date: Thu, 29 Jun 2017 23:38:47 -0400 [thread overview]
Message-ID: <87r2y2kuuw.fsf@users.sourceforge.net> (raw)
In-Reply-To: <qpeg8qukvc.fsf@fencepost.gnu.org> (Glenn Morris's message of "Wed, 25 May 2016 13:07:35 -0400")
[-- Attachment #1: Type: text/plain, Size: 412 bytes --]
tags 23561 + patch
quit
Glenn Morris <rgm@gnu.org> writes:
> Thanks. Works for me on RHEL 7.2, but on hydra the tests are still skipped.
>
> From previous investigation, they have a "gpg2" binary that is 2.0.27
> and a "gpg" one that is 1.4 (?).
Since Bug#23619 is fixed, I think it's just a matter of removing the
check for gpg 1.4.3, I'll push the following in a couple of days if
there are no objections.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1495 bytes --]
From 67b8a8abc33e694ca275dff3586b605a89f07c62 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Thu, 29 Jun 2017 23:28:15 -0400
Subject: [PATCH] Don't skip epg tests (Bug#23561)
* test/lisp/epg-tests.el (with-epg-tests): Ignore REQUIRE-PASSPHRASE
parameter, since we supply the passphrase via pinentry-program for all
GPG versions (as of 2017-02-28 "Fix epg-tests with dummy-pinentry
program (Bug#23619)").
(epg-tests-program-alist-for-passphrase-callback): Remove.
---
test/lisp/epg-tests.el | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/test/lisp/epg-tests.el b/test/lisp/epg-tests.el
index 9dd093e792..36db478801 100644
--- a/test/lisp/epg-tests.el
+++ b/test/lisp/epg-tests.el
@@ -30,17 +30,8 @@ (defvar epg-tests-data-directory
(expand-file-name "data/epg" (getenv "EMACS_TEST_DIRECTORY"))
"Directory containing epg test data.")
-(defconst epg-tests-program-alist-for-passphrase-callback
- '((OpenPGP
- nil
- ("gpg" . "1.4.3"))))
-
-(defun epg-tests-find-usable-gpg-configuration (&optional require-passphrase)
- (epg-find-configuration
- 'OpenPGP
- 'no-cache
- (if require-passphrase
- epg-tests-program-alist-for-passphrase-callback)))
+(defun epg-tests-find-usable-gpg-configuration (&optional _require-passphrase)
+ (epg-find-configuration 'OpenPGP 'no-cache))
(defun epg-tests-passphrase-callback (_c _k _d)
;; Need to create a copy here, since the string will be wiped out
--
2.11.1
next prev parent reply other threads:[~2017-06-30 3:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 6:29 bug#23561: epg tests are (almost) always skipped Glenn Morris
2016-05-17 8:48 ` Daiki Ueno
2016-05-18 15:44 ` Glenn Morris
2016-05-19 1:40 ` Daiki Ueno
2016-05-19 9:12 ` Daiki Ueno
2016-05-25 17:07 ` Glenn Morris
2017-06-30 3:38 ` npostavs [this message]
2017-07-07 2:10 ` npostavs
2017-07-09 23:34 ` Glenn Morris
2017-07-11 2:04 ` npostavs
2017-07-23 5:02 ` npostavs
2018-07-13 12:25 ` Noam Postavsky
2018-07-13 16:54 ` Glenn Morris
2018-07-16 11:29 ` Noam Postavsky
2018-07-24 17:47 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2y2kuuw.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=23561@debbugs.gnu.org \
--cc=rgm@gnu.org \
--cc=ueno@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.