From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#27871: 26.0.50; Bad handling of unmounted directory Date: Sat, 23 Sep 2017 13:30:51 +0200 Message-ID: <87r2uxejo4.fsf@linux-m68k.org> References: <83a81lbswu.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1506166280 28594 195.159.176.226 (23 Sep 2017 11:31:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 23 Sep 2017 11:31:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) Cc: Philipp Stephani , 27871@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 23 13:31:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvieQ-0006o3-R1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Sep 2017 13:31:15 +0200 Original-Received: from localhost ([::1]:34504 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvieS-000164-Fc for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Sep 2017 07:31:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvieF-00015x-UX for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 07:31:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvieE-00081d-RN for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 07:31:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44878) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dvieE-00080o-OH for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 07:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dvieE-0004z7-1I for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 07:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Sep 2017 11:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27871-submit@debbugs.gnu.org id=B27871.150616625618788 (code B ref 27871); Sat, 23 Sep 2017 11:31:01 +0000 Original-Received: (at 27871) by debbugs.gnu.org; 23 Sep 2017 11:30:56 +0000 Original-Received: from localhost ([127.0.0.1]:53559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvie8-0004sh-Dt for submit@debbugs.gnu.org; Sat, 23 Sep 2017 07:30:56 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.9]:35036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvie7-0004qo-8W for 27871@debbugs.gnu.org; Sat, 23 Sep 2017 07:30:55 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3xzp7f00tsz1qs0B; Sat, 23 Sep 2017 13:30:53 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3xzp7d6b5mz1qqkB; Sat, 23 Sep 2017 13:30:53 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 9dWz0hqyOsWX; Sat, 23 Sep 2017 13:30:52 +0200 (CEST) X-Auth-Info: Asr2yjnOFfJKcMUAbQ1LPgf7eTqwtLUAKbxB35lmV5S6Wi4E/lUjoOYAdKyegO+v Original-Received: from igel.home (ppp-88-217-7-222.dynamic.mnet-online.de [88.217.7.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sat, 23 Sep 2017 13:30:52 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 1000) id 90FD32C39A8; Sat, 23 Sep 2017 13:30:51 +0200 (CEST) X-Yow: A shapely CATHOLIC SCHOOLGIRL is FIDGETING inside my costume.. In-Reply-To: <83a81lbswu.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 23 Sep 2017 13:39:29 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137274 Archived-At: On Sep 23 2017, Eli Zaretskii wrote: >> +/* Return the current working directory. The result should be freed >> + with 'free'. Return NULL on errors. */ >> +char * >> +emacs_get_current_dir_name (void) >> +{ >> + char *dir = emacs_get_current_dir_name_1 (); >> + if (dir == NULL) >> + return NULL; >> + /* On Linux, getcwd and get_current_dir_name return a string >> + starting with "(unreachable)" if the current directory doesn't >> + exist, e.g. because it was unmounted. Treat that as an error. >> + See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27871. */ >> + const char *prefix = "(unreachable)"; >> + size_t dir_len = strlen (dir); >> + size_t prefix_len = strlen (prefix); >> + if (dir_len >= prefix_len && strncmp (dir, prefix, prefix_len) == 0) >> + { >> + errno = ENOTCONN; >> + return NULL; > > What if there's a directory called literally "(unreachable)SOMETHING"? An absolute file name cannot start with "(unreachable)". Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."