From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29854: 25.3; Eshell buffer editing gets slower as colored output grows Date: Tue, 02 Jan 2018 08:50:51 -0500 Message-ID: <87r2r8s72c.fsf@users.sourceforge.net> References: <87vagt6a7d.fsf@gmail.com> <87mv1ytjpg.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1514900965 23637 195.159.176.226 (2 Jan 2018 13:49:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 Jan 2018 13:49:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 29854@debbugs.gnu.org To: Pierre Neidhardt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 02 14:49:21 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWMwJ-0005J0-8U for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jan 2018 14:49:11 +0100 Original-Received: from localhost ([::1]:43459 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWMyI-00027m-GR for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jan 2018 08:51:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWMyA-00026e-97 for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 08:51:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWMy7-0005z5-4x for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 08:51:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51924) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWMy6-0005yR-W2 for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 08:51:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eWMy6-0005sQ-Iw for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 08:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jan 2018 13:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29854 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29854-submit@debbugs.gnu.org id=B29854.151490106122583 (code B ref 29854); Tue, 02 Jan 2018 13:51:02 +0000 Original-Received: (at 29854) by debbugs.gnu.org; 2 Jan 2018 13:51:01 +0000 Original-Received: from localhost ([127.0.0.1]:60605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWMy5-0005sB-6I for submit@debbugs.gnu.org; Tue, 02 Jan 2018 08:51:01 -0500 Original-Received: from mail-it0-f53.google.com ([209.85.214.53]:46715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWMy3-0005rx-6h for 29854@debbugs.gnu.org; Tue, 02 Jan 2018 08:50:59 -0500 Original-Received: by mail-it0-f53.google.com with SMTP id c16so14638704itc.5 for <29854@debbugs.gnu.org>; Tue, 02 Jan 2018 05:50:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=xBvM9YW/K7uazyEOJU/ei0HQgxdZLbI6oME+v2Avjtk=; b=j9DAM6SU0/KgjTDCTjZFhzUZizYPofR8kYPYAUeOBwTkqI9mTuFs2eihS5d/Ffydje qRqVTEBBb0a5bw4Ic+Ck3wBCOEQ49Exv9K1YTFbm9q8TkzF885tFGVC+DUofGWsudiMP cLSyeLOXNF8sedV1Kj4UGb1M48+oaU4eBAQ2LZtD4wBfEiGIoks+QnZhFmI84plL7Rec BHcRRSXY7GvhroOuO0klpB9oRWG9aT9mXkylOuMmea92JJRVvVuC4B02r5HZNbO4Jwgj 7TO0E2YTZA4XIXxKMYr3ULznYqUxxibm2X8ITaQzWZWneVLCHPlC5ryJ0oTC3115svkF Mvrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=xBvM9YW/K7uazyEOJU/ei0HQgxdZLbI6oME+v2Avjtk=; b=ZFvAC/U6BSkbr0wNhbDFtLF4jyQcfOq2GtVzRxX6w+FInxhiwWfl8c/dz0tRdXKXpv lGVCVLa7qprW06NoGk2KqhF1rAEKMn3W32OgcrWIJ4KaD2VaFrZ6K6EBSTYL8VUsd2eU I6cvr+fld1URpwAlO6TijdF1zF8d0kjXdRz05DdDswUWKoOl1BVZOp3NErt9Ba1jLeER KBPo2aFj54y8wNg8u6UgmB1866b7daI2XqHd5RaHWf5hcgAwpXShEa5ESwID0eIqNXOM b8atwCci3leCJO1x9R0rjt8Qzc/1OPYRLZXR0QeqP+bv+5WBlnvg6JWntpl76Aj2+/U3 BAIg== X-Gm-Message-State: AKGB3mK6+g9X+SdjRXhoHDsFgfH94CTfVPTWpi0dTfVby5VD/JFz6KVV lN4HLR9URNGLvMnaFvDQk1Qihg== X-Google-Smtp-Source: ACJfBoslnGC1mGBdNQFRb+Sr5vAHgMYtk7x28PRt59VMU2Q5vVPVFAWvH5hwsGE2i6ngW0K5MLBWtA== X-Received: by 10.36.9.133 with SMTP id 127mr63524377itm.69.1514901053405; Tue, 02 Jan 2018 05:50:53 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 72sm4692552itg.0.2018.01.02.05.50.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Jan 2018 05:50:52 -0800 (PST) In-Reply-To: (Pierre Neidhardt's message of "Tue, 2 Jan 2018 13:40:00 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141711 Archived-At: Pierre Neidhardt writes: > The patch does not seem to do it.=C2=A0 Unless load order matters? Load order should not matter. > The redifinition of `ansi-color-apply-face-function` works however, > plus it comes at the bonus of making Eshell an order of magnitude > faster! > I haven't tested estensively yet, but it seems to be a much better > default. Aha, maybe it's not a question of markers, but rather another case of Bug#26051 "overlays may make emacs very slow". (anyway, ansi-color-apply-to-region doesn't set markers per colour boundary; it's just 1 or 2 markers per call (eshell calls it once per ~4096 bytes)) The question is then whether there is some case where using overlays is necessary, or is it just a pessimization? For reference, I took the text property using definition from man.el (so it at least works for that case): (defun Man-fontify-manpage () [...] (let ((ansi-color-apply-face-function (lambda (beg end face) (when face (put-text-property beg end 'face face))))