From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#29799: 24.5; cl-loop guard clause missing Date: Mon, 08 Jan 2018 19:20:35 +0900 Message-ID: <87r2r0ird8.fsf@gmail.com> References: <87d138beur.fsf@gmail.com> <874lo5tfpl.fsf@users.sourceforge.net> <871sj9tcdb.fsf@users.sourceforge.net> <87lghfqlh0.fsf@gmail.com> <87shbjqezn.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1515406757 20007 195.159.176.226 (8 Jan 2018 10:19:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 8 Jan 2018 10:19:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: 29799-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 08 11:19:13 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYUWL-0004ei-FS for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Jan 2018 11:19:09 +0100 Original-Received: from localhost ([::1]:53765 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYUYK-0005qm-UA for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Jan 2018 05:21:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYUYF-0005pF-7S for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2018 05:21:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYUYA-0000Wy-AT for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2018 05:21:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59780) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eYUYA-0000Wj-4m for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2018 05:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eYUY9-0008QN-VP for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2018 05:21:01 -0500 Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jan 2018 10:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 29799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 29799@debbugs.gnu.org, tino.calancha@gmail.com, tino.calancha@gmail.com Original-Received: via spool by 29799-done@debbugs.gnu.org id=D29799.151540685132341 (code D ref 29799); Mon, 08 Jan 2018 10:21:01 +0000 Original-Received: (at 29799-done) by debbugs.gnu.org; 8 Jan 2018 10:20:51 +0000 Original-Received: from localhost ([127.0.0.1]:40226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYUXz-0008PZ-FD for submit@debbugs.gnu.org; Mon, 08 Jan 2018 05:20:51 -0500 Original-Received: from mail-wr0-f179.google.com ([209.85.128.179]:45891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYUXx-0008PN-OE for 29799-done@debbugs.gnu.org; Mon, 08 Jan 2018 05:20:50 -0500 Original-Received: by mail-wr0-f179.google.com with SMTP id o15so10148142wrf.12 for <29799-done@debbugs.gnu.org>; Mon, 08 Jan 2018 02:20:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=mHNReOvDCrZsI+5TdDppxhc3T4rTXs9txHAnsVTm4P0=; b=XD4tzH7cFtbkA8JAIlCOuhIs1M2bNlHc7yCw2Z9ax0sCIFV1JR89T3p+NjgWC4HwMl dgpLqTdy67n+denUrS8Uiyhy763WZg5Iax87InqhdujJXWrCepDzLbYv2psxgTcNvRW8 Hd19DV8QQida246XT6mOH3axdN2YhG3QcvvFwSxrZxuQuexahe13Nj2kt7XDYYsZhFQP TFfm4nNBshJIXUVBl8QbojYESi43x8diqk/TnBgXiQALQgFo+eCYGnibPuCytpBYOWBv lObk6SSPGHpYn0C8OXTSudMKRdPCXcNgYDWcTy84lGJpDfphH60kCg/SxaLyebQekn6q vx1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=mHNReOvDCrZsI+5TdDppxhc3T4rTXs9txHAnsVTm4P0=; b=FKG5RaLMWzjX7o/o4CgYuJrbdK4g9ER87xBLiYrT2W40dPv7/rqkUnfbsvmkxwiFWF UyEGvSjdI7uG6K+KB1HPmNO5Mg35CjqtuOn69hgaVq+4tBVw7nbGrUYo7P7SXK9ntFNv mXcqKlaWxXa9kAaOsU0chbHNqHu23WGab0xJc31+M1HLQLy6iySZ2gc44sNcq0u6nn7i ciNaneXwLziHYU0DPvhsoIN6TocBci1VGcKgcdQAKQRF9VZRF5BDA0LOU4l4g66TW3Mg YerXQ59iL/+61vSiYYSA7rt2+dQdACHKR9mYgm6tho9D+A14PqsT1UOioHTLeGbKNr8X SYhg== X-Gm-Message-State: AKGB3mKksXsVEoTd10N7CAeDr80RQ5t4V0YDdDpilO/Uk860KULi6UIB 3a5qHStOodB4Vr2262n0ou/rpQ== X-Google-Smtp-Source: ACJfBouzukTgr1UwGRjWBz+M2hEXB8LAcxgnr1xgd9QMkJXENdu/qRtGHWi6wrIFiGZhJQR2AbCPgg== X-Received: by 10.223.160.242 with SMTP id n47mr10412447wrn.35.1515406843844; Mon, 08 Jan 2018 02:20:43 -0800 (PST) Original-Received: from calancha-pc (228.red-83-40-68.dynamicip.rima-tde.net. [83.40.68.228]) by smtp.gmail.com with ESMTPSA id x18sm4053296wrg.0.2018.01.08.02.20.42 for <29799-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Jan 2018 02:20:42 -0800 (PST) In-Reply-To: <87shbjqezn.fsf@users.sourceforge.net> (Noam Postavsky's message of "Sat, 06 Jan 2018 08:43:56 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141897 Archived-At: Noam Postavsky writes: > Tino Calancha writes: > >> Fix #Bug#29799 >> >> * lisp/emacs-lisp/cl-macs.el (cl--loop-guard-cond): New variable. >> (cl--parse-loop-clause): Set it non-nil if the loop contains >> a for/as clause. >> (cl-loop): After update the loop variable, update other variables >> only if cl--loop-guard-cond is non-nil. >> >> * test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs-loop-for-as-equals-and): >> New test. > > Looks good, but please add some more info to the summary line. Thank you very much. Extended the commit message with more detailed explanations. Fixed in master branch as commit 'cl-loop: Add missing guard condition' (a0365437c9ee308ad7978e436631020f513b25e7).