From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Pierre Téchoueyres" <pierre.techoueyres@free.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-sql.el: Improve Oracle connection and usage for ob-sql.
Date: Fri, 16 Mar 2018 23:03:00 +0100 [thread overview]
Message-ID: <87r2oj8yqz.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87bmfpdw74.fsf@killashandra.ballybran.fr> ("Pierre Téchoueyres"'s message of "Thu, 15 Mar 2018 19:34:39 +0100")
Hello,
pierre.techoueyres@free.fr (Pierre Téchoueyres) writes:
> So I attached two patches:
> - the first (0001-ORG-NEWS-...) correct the example in order to match to the code,
> - the second (0001-ob-sql.el...) correct the codein order to match to the example.
>
> Personnaly I prefer the last as it match better with the habits of
> thoses who uses Oracle's products (We talk almost ever in term of
> database than in term of servers).
>
> But it's up to you.
I applied the second patch, with a slight refactoring.
Thank you.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2018-03-16 22:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 19:51 [PATCH] ob-sql.el: Improve Oracle connection and usage for ob-sql Pierre Téchoueyres
2018-03-13 8:19 ` Nicolas Goaziou
2018-03-13 12:10 ` pierre.techoueyres
2018-03-13 19:51 ` Pierre Téchoueyres
2018-03-14 13:38 ` Nicolas Goaziou
2018-03-15 18:34 ` Pierre Téchoueyres
2018-03-16 22:03 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2oj8yqz.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=pierre.techoueyres@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.