From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#30874: 27.0.50; Emacs crashes Date: Tue, 03 Apr 2018 11:24:58 +0200 Message-ID: <87r2nwwsk5.fsf@gmail.com> References: <83vadoi2ia.fsf@gnu.org> <878taf2kj5.fsf@gmail.com> <83d0zqg8p8.fsf@gnu.org> <87o9ja230e.fsf@gmail.com> <83605ig2se.fsf@gnu.org> <87fu4m1tht.fsf@gmail.com> <878tae1nzu.fsf@gmail.com> <83lgeedxv7.fsf@gnu.org> <874ll128ww.fsf@gmail.com> <83efk3dvq0.fsf@gnu.org> <87po3mdfl8.fsf@gmail.com> <83sh8idd3p.fsf@gnu.org> <87woxtq282.fsf@gmail.com> <83po3l946g.fsf@gnu.org> <87o9j5pvk4.fsf@gmail.com> <83lge98ymi.fsf@gnu.org> <87in9cxsce.fsf@gmail.com> <834lkw8f5i.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1522747461 16516 195.159.176.226 (3 Apr 2018 09:24:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 3 Apr 2018 09:24:21 +0000 (UTC) Cc: 30874@debbugs.gnu.org, jsynacek@redhat.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 03 11:24:17 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3IAo-00048y-NB for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Apr 2018 11:24:14 +0200 Original-Received: from localhost ([::1]:46668 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3ICs-0008KQ-Bd for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Apr 2018 05:26:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3ICc-0008Ig-2a for bug-gnu-emacs@gnu.org; Tue, 03 Apr 2018 05:26:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f3ICY-00072O-Kf for bug-gnu-emacs@gnu.org; Tue, 03 Apr 2018 05:26:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56156) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f3ICY-000727-GO for bug-gnu-emacs@gnu.org; Tue, 03 Apr 2018 05:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f3ICY-0000vx-1Z for bug-gnu-emacs@gnu.org; Tue, 03 Apr 2018 05:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Apr 2018 09:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30874 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30874-submit@debbugs.gnu.org id=B30874.15227475083523 (code B ref 30874); Tue, 03 Apr 2018 09:26:01 +0000 Original-Received: (at 30874) by debbugs.gnu.org; 3 Apr 2018 09:25:08 +0000 Original-Received: from localhost ([127.0.0.1]:35820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3IBf-0000ul-Ut for submit@debbugs.gnu.org; Tue, 03 Apr 2018 05:25:08 -0400 Original-Received: from mail-wm0-f50.google.com ([74.125.82.50]:38113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3IBd-0000uC-KI for 30874@debbugs.gnu.org; Tue, 03 Apr 2018 05:25:05 -0400 Original-Received: by mail-wm0-f50.google.com with SMTP id i3so9771921wmf.3 for <30874@debbugs.gnu.org>; Tue, 03 Apr 2018 02:25:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=DTg6B752mhSKlybj+fzaEUy7hnaVaOoIQpEk5xDsO5Q=; b=PBUbPVNT6YjdSDXr3n9fQf/pAkY01QAjg7dWNj0SPvhmQ/dyvgBgaPH1cvzV/iPEDr pPTeOVP0QSwyvjSOgUGTMIsQMP4sy21WRf8iVzhWhd8jyGWNJAt1RqtpiGuuUVnl/GPi LGMg9EvDFDkGRdOsizyPY++IOJXI/13ohrD8T2eLcBFZY4DIMeWRn6DrU7GMsJuaZLd3 PkfN3SJ9KfDarvSNf8gNkzOnetSg0w9q7AIu98d+bnd8LwlLCyZjlDPidAU6JUUalJB0 jzHlsvz7JWiNl2dVokFu9mc6l2qdEBwTmmSXs8qOQ/9/G4YP0BLpI829/bmzbT1PVkiH omgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=DTg6B752mhSKlybj+fzaEUy7hnaVaOoIQpEk5xDsO5Q=; b=QCBtGgKJQfZuz15D45sCFrIaKMjVxdYOPCxws8BSaHj/8OhANn5fxDzV/4G+bTeRVi D/9i+xtRHF1oyhXh8t2BgYrHYR4RahxQWrIYtorQ78GJzz5QPRS4drH+AxqnFQ6mtq3B h7hCZTfv2vNl8dHl4f3dQjyR6AQbLV0wsz3SLAbxP496AKT9MmB00Kaqj/v158P4aaSS aQ3BVWl2Rjcrr1BdicvPsocNNxPksBzV5T5P9PW56y7PU31V/n9pYdhMLQSkkziSLL/Q BMvEEQcRm4ia/iB6SnJCrBW1zwI1xHsP94uoCJBDD4zx163JyQZmpoRsisGW24QyBZB6 FI9w== X-Gm-Message-State: AElRT7GXrkCWqbLmWG/NqTze6HHTi1YXTsa5xXKN4xXvfV4QzZKKLRQV kXKCs0J8wig/ojFPWtYOwc0= X-Google-Smtp-Source: AIpwx49JbNtTjYcB/2U4LLC81rg+2fiq4Pfrh1+xCQvz5UiWTaZL3Db5cSSmdV1EsvIvFXUB5lnCPg== X-Received: by 10.28.109.154 with SMTP id b26mr3037754wmi.99.1522747499937; Tue, 03 Apr 2018 02:24:59 -0700 (PDT) Original-Received: from rpluim ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id j76sm197631wmd.17.2018.04.03.02.24.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 03 Apr 2018 02:24:59 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <834lkw8f5i.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 31 Mar 2018 17:59:21 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144837 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Cc: 30874@debbugs.gnu.org, jsynacek@redhat.com >> Date: Sat, 31 Mar 2018 15:55:13 +0200 >>=20 >> I=CA=BCm testing the following, which fixes the 20890 crash for me when >> using Cairo. >>=20 >> diff --git i/src/ftfont.c w/src/ftfont.c >> index c2e093e633..89c07e1f21 100644 >> --- i/src/ftfont.c >> +++ w/src/ftfont.c >> @@ -1242,6 +1242,11 @@ ftfont_close (struct font *font) >> struct ftfont_info *ftfont_info =3D (struct ftfont_info *) font; >> Lisp_Object val, cache; >>=20=20 >> +#ifdef USE_CAIRO >> + /* Bug#20890 workaround. */ >> + if (gc_in_progress) >> + return; >> +#endif >> val =3D Fcons (font->props[FONT_FILE_INDEX], make_number (ftfont_info= ->index)); >> cache =3D ftfont_lookup_cache (val, FTFONT_CACHE_FOR_FACE); >> eassert (CONSP (cache)); > > This LGTM, thanks. > I=CA=BCll follow up in bug 20890. > > It can stay in ftfont.c, but please make the second hunk > unconditional, so that the variable is known and available in all the > builds, just say in the doc string that this variable has effect only > on the xftfont backend. I have bad experience with variables that are > only defined in some configurations: it means both trouble for users > who use more than one configuration and more maintenance headaches. > Come to think of it, maybe it's best to move DEFVAR_BOOL to font.c, > for that very reason. OK, adjusted accordingly. Robert