From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.help Subject: Re: Any way to control which articles Gnus summary shows by default? Date: Sun, 08 Apr 2018 08:03:43 -0700 Message-ID: <87r2npoi40.fsf@ericabrahamsen.net> References: <86lge3ric2.fsf@zoho.com> <87vad78nh2.fsf@web.de> <87sh8bsa2c.fsf@ericabrahamsen.net> <87in97jkzk.fsf@web.de> <87lge3ryvn.fsf@ericabrahamsen.net> <87sh8bm3u1.fsf@web.de> <874lkogzel.fsf@web.de> <87lge0pdfg.fsf@ericabrahamsen.net> <87efjsdxx0.fsf@ericabrahamsen.net> <87d0z9zss2.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1523199899 18757 195.159.176.226 (8 Apr 2018 15:04:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 8 Apr 2018 15:04:59 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: help-gnu-emacs@gnu.org To: Michael Heerdegen Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Sun Apr 08 17:04:55 2018 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f5BsE-0004lV-J4 for geh-help-gnu-emacs@m.gmane.org; Sun, 08 Apr 2018 17:04:54 +0200 Original-Received: from localhost ([::1]:60792 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5BuK-0006P4-9z for geh-help-gnu-emacs@m.gmane.org; Sun, 08 Apr 2018 11:07:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5Btk-0006OQ-Gi for help-gnu-emacs@gnu.org; Sun, 08 Apr 2018 11:06:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f5Bth-0003F0-Az for help-gnu-emacs@gnu.org; Sun, 08 Apr 2018 11:06:28 -0400 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:48410) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f5Bth-00037o-5y for help-gnu-emacs@gnu.org; Sun, 08 Apr 2018 11:06:25 -0400 Original-Received: from localhost (71-35-188-108.tukw.qwest.net [71.35.188.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id D9B33BE87D; Sun, 8 Apr 2018 15:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1523199977; bh=v8xduJmh6YBLjwvXRkAIGEvFfDM02OHHMeCv4U2LDLw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=yEwTeTzag7OLDZG3AMG6gnMebDZLXiwxwh4SZvtaOcLjzuzK5K/oH/Mqda35L+WvJ 6gy0tyf9O7M2lseFZbFJEBCyvU22/gcZV1+fW/QnsYOAL5qYPU2N6EsC2URInCqCIs 0bAA8qnM78UW4yggi15b+73aAZl48xJWlbQrBU8s= In-Reply-To: <87d0z9zss2.fsf@web.de> (Michael Heerdegen's message of "Sun, 08 Apr 2018 16:17:49 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 50.56.99.223 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.org gmane.emacs.help:116408 Archived-At: On 04/08/18 16:17 PM, Michael Heerdegen wrote: > Eric Abrahamsen writes: > >> > Thanks for the hint. I was setting the cleaned values for the >> > subtables, but not then re-setting the tables themselves: they were >> > getting fixed, then thrown away. I can't believe how long this is >> > taking to get right... I'll post to gnus.general again once I'm >> > confident (ha) I've got it fixed. >> >> Or maybe no, that's not what was happening. > > I'm not sure if that's not what is happening. > > AFAIU `eieio-persistent-read' reads the whole thing (database) at once. > That function calls `eieio-persistent-convert-list-to-object' on the > read value, which loops `eieio-persistent-validate/fix-slot-value' over > the slot values. The latter may only transform (quote SOMETHING) to > SOMETHING but doesn't look inside SOMETHING so the whole cleanup thing > isn't recursive. But AFAIU the Gnus registry is recursive enough to be > problematic in this regard. Yes, the whole problem arose from the fact that the write/restore process isn't recursive. In Emacs 26, the process needed to "look deeper" inside the objects, and I thought that in doing that I'd been careful to balance the write and restore process. Apparently I've still failed to get it right -- though now I'm only seeing quote accumulation in the secondary tables, not the main :data table. > BTW, why does writing to a file involve adding quotes before a list at > all? The reader doesn't need the lists been quoted, so why do we add > the quotes to the file just to remove them troublesomely after reading? The whole process is ad hoc and largely unnecessary. In #29541 I've started working on a more general solution that would be actually recursive, and also not work so hard. I've had second thoughts about the patch I posted there, but I think the general direction is correct. Anyway, the real solution is just to re-write the whole system, though I guess I'll need to fix this current bug, hopefully for a 26.X release. Eric