Re: [Emacs-diffs] master bb591f139f: Enhance CC Mode's fontification, etc., of unterminated strings.

[Michael Welsh Duggan <mwd@md5i.com>]

joaotavora@gmail.com (João Távora) writes:

> PS: you could also have used:
>
>    M-x ert-describe-test RET electric-pair-autowrapping-5-at-point-2-in-c++-mode-in-strings
>
> Which would have rendered a nice docstring
>
>     electric-pair-autowrapping-5-at-point-2-in-c++-mode-in-strings is a
>     test defined in `electric-tests.elc'.
>      
>     With |"foo"|, try input " at point 2. Should become |""foo""| and point at 3
>      
>     [back]
>
> Though, admittedly, this is misleading for the "autowrapping" tests,
> since it doesn't tell you about the "mark-sexp" region-making
> command. Also not immediatly clear perhaps it that the | are buffer
> boundaries.
>
> Ideally, it should read read
>
>   With |"foo"|, at point 2, (mark-sexp 1) and try input ".
>   Should become |""foo""| and point at 3
>
> I will try to fix this in master.
>
> Also M-x ert-find-test-other-window could have helped you, but it
> doesn't (brings me to the beginning of the file, which isn't helpful). I
> don't know why, does anyone?

Could the macros that generate the ert-deftest call not set
`definition-name' in the generated function's symbol property list that
leads back to `define-electric-pair-test`'s name element?  That might
help `find-function-search-for-symbol' find the correct location.

-- 
Michael Welsh Duggan
(md5i@md5i.com)