From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#31737: 26.1.50; Gnus does not use mailutils movemail Date: Thu, 14 Jun 2018 14:14:28 +0200 Message-ID: <87r2l9a7kr.fsf@gmail.com> References: <87sh5zk9br.fsf@gmail.com> <8736xzvgrg.fsf@yandex.com> <87o9gnk7vb.fsf@gmail.com> <831sdhuwc1.fsf@gnu.org> <87tvqdjmid.fsf@gmail.com> <83sh5xtaa5.fsf@gnu.org> <87602tjesm.fsf@gmail.com> <83muw5t78t.fsf@gnu.org> <871sddk9su.fsf@gmail.com> <83lgblqrir.fsf@gnu.org> <87sh5thu73.fsf@gmail.com> <83r2lcpwk3.fsf@gnu.org> <87o9gg7cue.fsf@yandex.com> <83lgbkoynn.fsf@gnu.org> <87efha93t6.fsf@gmail.com> <83d0wu4p0c.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528978391 16259 195.159.176.226 (14 Jun 2018 12:13:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 14 Jun 2018 12:13:11 +0000 (UTC) Cc: m43cap@yandex.com, larsi@gnus.org, 31737@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 14 14:13:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTR7f-000443-Ia for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jun 2018 14:13:03 +0200 Original-Received: from localhost ([::1]:40205 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTR9m-0002EH-PQ for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jun 2018 08:15:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTR9d-0002EB-OJ for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2018 08:15:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTR9a-0005QR-GR for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2018 08:15:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39494) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fTR9a-0005QJ-CA for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2018 08:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fTR9a-0008Cp-23 for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2018 08:15:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87sh5zk9br.fsf@gmail.com> Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jun 2018 12:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31737 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31737-submit@debbugs.gnu.org id=B31737.152897847731498 (code B ref 31737); Thu, 14 Jun 2018 12:15:02 +0000 Original-Received: (at 31737) by debbugs.gnu.org; 14 Jun 2018 12:14:37 +0000 Original-Received: from localhost ([127.0.0.1]:47391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTR9B-0008By-DH for submit@debbugs.gnu.org; Thu, 14 Jun 2018 08:14:37 -0400 Original-Received: from mail-wr0-f194.google.com ([209.85.128.194]:38619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTR9A-0008Bm-6L for 31737@debbugs.gnu.org; Thu, 14 Jun 2018 08:14:36 -0400 Original-Received: by mail-wr0-f194.google.com with SMTP id e18-v6so6200231wrs.5 for <31737@debbugs.gnu.org>; Thu, 14 Jun 2018 05:14:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:message-id:mime-version; bh=DE+dLZPW6j9CAuospRx8xmEviEpMgUF0OYu1/nR+k4A=; b=EvIliBt3QgjxB+w7QwNBve5rOoa/DWxCEqc/o5gJ9JvYkQSvIWMokD1csFdQS9XGHp 7RFtfEglfPYuN1hYn+u+pRc/D30KGA0PE6xaC7yKjv0fw7bfda41yfzyePhmnGDOwNpy SYgn9ui3oHYqs2LykVMtJd3qQYcGWytc+n3dg3QiQItziDMKL/ftnEp0m/NBLT9lvFoJ yLyxa/5fDSHSeSNQC91CNEXSvdQVVlva50+MUS/SAlznPEvNKvrRv7fiYUD02/ETmGQz AxnJOjsGXRll+gcgml0eF4iaGGGcZEYH8jSWoC0+7dwey4b8HiGykmVevFG50TwWqhSP bYdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:message-id:mime-version; bh=DE+dLZPW6j9CAuospRx8xmEviEpMgUF0OYu1/nR+k4A=; b=PcRw+I6C6ru3FAO8qOHp0OkpCPsAteM2GLVchoDNZQuHxb0TOw08Tfqh67OL+VF2ug zYeCOJ4KEoaZn/mFuUSaNlRP0rBYhgPTaMR22s+b95wo5cRNC7QIZZhsaCypXaaGA7S9 4YNZ/26JiPZcofmvI53EH388tWTo8fs5p+gddHFRHuFKCFm+tfcofYLUgxpjm0Z87jht 6/J6KVmYWnRCuUehGcrHGGvA2YEfjWAulptrpS86hq7IRemzFuB2Cfqs+s2/zd0uDcXl 0H1I1VNY407LVdykfge7Gh3LoZoSOa3c95olk8TKG9DC2/il5Zv5oGAE8hlcZW3FDUD/ CcdA== X-Gm-Message-State: APt69E1Sx2Q9J5X/76hGgIgS/mWOtcqyZigr56/FcD5VI8ze9JDtkOBS RX/bKIRwxRRNGjnFhwhtqgpSyFQ/OkA= X-Google-Smtp-Source: ADUXVKImnjHKLA7qjc62zTzTRxOq1vjO5m3colCiIs8I/0oQ9+CpYSkm9VmG7Jej1foakkU1iNY4eA== X-Received: by 2002:adf:99a7:: with SMTP id y36-v6mr2047147wrb.64.1528978470026; Thu, 14 Jun 2018 05:14:30 -0700 (PDT) Original-Received: from rpluim ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id w102-v6sm5129748wrc.23.2018.06.14.05.14.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Jun 2018 05:14:29 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147400 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Cc: Eli Zaretskii , Colin Baxter , 31737@debbugs.gnu.org >> Date: Wed, 13 Jun 2018 16:08:53 +0200 >> >> Eli, were you thinking that mail-source should duplicate the movemail >> detection logic in rmail? Or should it just assume Mailutils movemail >> and pass '--emacs'? > > The former. Something like this? Testing definitely required by someone who uses mailutils movemail for Gnus. Not sure this is emacs-26 material anymore. diff --git i/lisp/gnus/mail-source.el w/lisp/gnus/mail-source.el index d2850f4cee..99dc40c843 100644 --- i/lisp/gnus/mail-source.el +++ w/lisp/gnus/mail-source.el @@ -301,7 +301,7 @@ mail-source-idle-time-delay :group 'mail-source :type 'number) -(defcustom mail-source-movemail-program nil +(defcustom mail-source-movemail-program "movemail" "If non-nil, name of program for fetching new mail." :version "22.1" :group 'mail-source @@ -653,6 +653,12 @@ mail-source-delete-crash-box mail-source-delete-incoming mail-source-delete-old-incoming-confirm))))))) +(defun mail-source-movemail-variant-p (variants) + "Return t if the current movemail variant is any of VARIANTS. +See `rmail-movemail-variant-p' for details" + (let ((rmail-movemail-program mail-source-movemail-program)) + (rmail-movemail-variant-p variant))) + (defun mail-source-movemail (from to) "Move FROM to TO using movemail." (if (not (file-writable-p to)) @@ -682,13 +688,20 @@ mail-source-movemail (setq errors (generate-new-buffer " *mail source loss*")) (let ((default-directory "/")) (setq result + ;; call-proces looks in exec-path, which + ;; contains exec-directory, so will find + ;; Mailutils movemail if it exists, else it will + ;; find "our" movemail in exec-directory. + ;; Bug#31737 (apply 'call-process (append (list - (or mail-source-movemail-program - (expand-file-name "movemail" exec-directory)) - nil errors nil from to))))) + mail-source-movemail-program + nil errors nil) + (when (mail-source-movemail-variant-p 'mailutils) + (list "--emacs")) + (list from to))))) (when (file-exists-p to) (set-file-modes to mail-source-default-file-modes)) (if (and (or (not (buffer-modified-p errors))