From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate Date: Sun, 24 Jun 2018 16:46:02 -0400 Message-ID: <87r2kvq5f9.fsf@gmail.com> References: <87y3f5mq07.fsf@gmail.com> <87vaa8pap5.fsf@gmail.com> <87muvklysn.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1529873109 5746 195.159.176.226 (24 Jun 2018 20:45:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 24 Jun 2018 20:45:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 31951@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 24 22:45:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXBsf-0001Pe-E7 for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Jun 2018 22:45:05 +0200 Original-Received: from localhost ([::1]:43089 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXBum-0004lI-F5 for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Jun 2018 16:47:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXBud-0004lC-If for bug-gnu-emacs@gnu.org; Sun, 24 Jun 2018 16:47:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXBuY-0000UU-O0 for bug-gnu-emacs@gnu.org; Sun, 24 Jun 2018 16:47:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54486) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fXBuY-0000UN-Iq for bug-gnu-emacs@gnu.org; Sun, 24 Jun 2018 16:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fXBuX-0007J7-W6 for bug-gnu-emacs@gnu.org; Sun, 24 Jun 2018 16:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jun 2018 20:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31951 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31951-submit@debbugs.gnu.org id=B31951.152987317428036 (code B ref 31951); Sun, 24 Jun 2018 20:47:01 +0000 Original-Received: (at 31951) by debbugs.gnu.org; 24 Jun 2018 20:46:14 +0000 Original-Received: from localhost ([127.0.0.1]:34150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXBtm-0007I8-Fm for submit@debbugs.gnu.org; Sun, 24 Jun 2018 16:46:14 -0400 Original-Received: from mail-io0-f177.google.com ([209.85.223.177]:42192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXBti-0007Ht-Mh for 31951@debbugs.gnu.org; Sun, 24 Jun 2018 16:46:11 -0400 Original-Received: by mail-io0-f177.google.com with SMTP id r24-v6so10593549ioh.9 for <31951@debbugs.gnu.org>; Sun, 24 Jun 2018 13:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=h9pw2mMb3ceWxVnYrQP5rMuaNGCdO9FoicOa3BTvr50=; b=G6628hMlzzygNO57EBvV/hplz3/nns9zxHHXO1XO2MMO2ndHgB56kk0w0q7ZDJa8jR CjGHRgts9ofqgrEgIPsTkHourT1ciD8bkxHEFfYhMZdvnpRzn/IXRxrsqcUImTAySl4U 5NQCAJo76RDcIysnhqmN37loJq6i6XFFFJmrWAamwv/jer3Tkw0rGE7qvmOLFTa4nU+V I9fTm9xQnA1mEcJ4Nef7qW6EnO30VjSUiR13G+/1zOXL98hv75frku4siZ+tPPqSZTD8 R0kgYW1ANmJkEhnPb89IZmmHkqyUgAIAbker9orrj8xs2K8smdU56SknaArA789JsoPL o62A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=h9pw2mMb3ceWxVnYrQP5rMuaNGCdO9FoicOa3BTvr50=; b=NI5ZOFoTxg/lEX+l7B0zpnM4srgAEa0GEJ0ATdLfonXipAcI63LJA+hqrIxri5N3vy 8WwuJXSvo8Js0EmjvPkpmQZmeHhwEm7nQaGZp68OVFYk/o9FtyWBmgJSYakP6lwYKjaq 58FlJctMtU3dc8N8LVKuRXV0NjENY3B82IU/a3XddQnW4kERIpEO1JaQlyU4nESqDB+X PdfiDLSZRy4IcfnwhNT0mSGgLmShZRSokh4Z9n5Y8KYYkvcaHMqbARkaHbk+Sz/WmfW3 +UKMjM7tfnr+faRKSchBVXiN4OgKHOJM4plNJRkW9G+DVAMxcB2AGInjNvw1jCFKZnWE w2tA== X-Gm-Message-State: APt69E2VFuqHGpnLPWhvvgY2bmOrz9DK2NrwbIQZh4WhNcd7fRLWv7DG XjesMLRb0ClSsjVkoTmsm+d/Kw== X-Google-Smtp-Source: AAOMgpeEhUVyC3GYb4zHEcrN0wn8SWBPVAIgTIMA+Oe0ehLTw4WewkGRn/wtMdmEwmlcDBlKvRHZjQ== X-Received: by 2002:a5e:c00c:: with SMTP id u12-v6mr7874928iol.264.1529873164985; Sun, 24 Jun 2018 13:46:04 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i10-v6sm3263927itb.38.2018.06.24.13.46.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Jun 2018 13:46:04 -0700 (PDT) In-Reply-To: <87muvklysn.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 24 Jun 2018 21:22:48 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147800 Archived-At: Jo=C3=A3o T=C3=A1vora writes: >> (defun save-buffers-kill-emacs (&optional arg) >> [...] >> ;; Don't use save-some-buffers-default-predicate, because we want >> ;; to ask about all the buffers before killing Emacs. >> (save-some-buffers arg t) > > Right, but thats because, when killing Emacs, it is really the last > chance to save those buffers before they're potentially gone for good. Oh, I got mixed up by the comment in server-save-buffers-kill-terminal: ;; If client is bufferless, emulate a normal Emacs exit ;; and offer to save all buffers. Otherwise, offer to ;; save only the buffers belonging to the client. So I'd say your change is sensible, we should just update that comment to explain the differences in the "emulation".