From: "João Távora" <joaotavora@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 31951@debbugs.gnu.org, 31951-done@debbugs.gnu.org
Subject: bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate
Date: Wed, 27 Jun 2018 14:20:54 +0100 [thread overview]
Message-ID: <87r2ksl615.fsf@gmail.com> (raw)
In-Reply-To: <87d0wepb2u.fsf@gmail.com> (Noam Postavsky's message of "Mon, 25 Jun 2018 21:53:45 -0400")
Noam Postavsky <npostavs@gmail.com> writes:
> João Távora <joaotavora@gmail.com> writes:
>
>> I tried to make it terser, but couldn't.
>
> Hmm, maybe just concentrate on the save-some-buffers-default-predicate
> thing. I think the original comment pretty much redundantly repeats
> what the doc string (and the code itself) say.
>
> --- i/lisp/server.el
> +++ w/lisp/server.el
> @@ -1639,13 +1639,15 @@ server-save-buffers-kill-terminal
> (save-buffers-kill-emacs arg)))
> ((processp proc)
> (let ((buffers (process-get proc 'buffers)))
> - ;; If client is bufferless, emulate a normal Emacs exit
> - ;; and offer to save all buffers. Otherwise, offer to
> - ;; save only the buffers belonging to the client.
> (save-some-buffers
> arg (if buffers
> - (lambda () (memq (current-buffer) buffers))
> - t))
> + ;; Only files from emacsclient file list.
> + (lambda () (memq (current-buffer) buffers))
> + ;; No emacsclient file list: don't override
> + ;; `save-some-buffers-default-predicate' (unless
> + ;; ARGS is non-nil), since we're not killing
> + ;; Emacs (unlike `save-buffers-kill-emacs').
> + (and arg t)))
> (server-delete-client proc)))
> (t (error "Invalid client frame")))))
>
Pushed as ce54573dacaeb234ac006b71cbaafe1c543515f1.
Thanks,
João
prev parent reply other threads:[~2018-06-27 13:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-23 16:22 bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate João Távora
2018-06-24 13:37 ` Noam Postavsky
2018-06-24 20:22 ` João Távora
2018-06-24 20:46 ` Noam Postavsky
2018-06-25 11:07 ` João Távora
2018-06-26 1:53 ` Noam Postavsky
2018-06-26 19:27 ` João Távora
2018-06-27 13:20 ` João Távora [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2ksl615.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=31951-done@debbugs.gnu.org \
--cc=31951@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.