bug#33568: 27.0.50; Failing secrets tests on Cygwin

bug#33568: 27.0.50; Failing secrets tests on Cygwin

[Ken Brown]

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

Two of the secrets tests fail on Cygwin (at least in my normal working
environment) because there is no "Login" collection.  Not knowing
anything about this, I'm inclined to take the easy way out, as in the
attached patch.  Is there a better way of handling it?

Ken


In GNU Emacs 27.0.50 (build 6, x86_64-pc-cygwin, GTK+ Version 3.22.28)
  of 2018-12-01 built on moufang2
Repository revision: 070ef95c1007cb3d54e04bc337d9fb5463912cc1
Repository branch: master
Windowing system distributor 'The Cygwin/X Project', version 11.0.12002000

[-- Attachment #2: 0001-Fix-secrets-tests-on-Cygwin.patch --]
[-- Type: text/plain, Size: 1979 bytes --]

From 3a4e7bf9de834ef30aa2642ef2fc9875840201ed Mon Sep 17 00:00:00 2001
From: Ken Brown <kbrown@cornell.edu>
Date: Sat, 1 Dec 2018 17:54:59 -0500
Subject: [PATCH] Fix secrets tests on Cygwin

* test/lisp/net/secrets-tests.el (secrets-test02-collections):
(secrets-test03-items): Don't expect there to be a "Login"
collection on Cygwin.
---
 test/lisp/net/secrets-tests.el | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/test/lisp/net/secrets-tests.el b/test/lisp/net/secrets-tests.el
index de3ce731be..90728f081d 100644
--- a/test/lisp/net/secrets-tests.el
+++ b/test/lisp/net/secrets-tests.el
@@ -91,9 +91,11 @@ secrets--test-delete-all-session-items
       (progn
 	(should (secrets-open-session))
 
-	;; There must be at least the collections "Login" and "session".
-	(should (or (member "Login" (secrets-list-collections))
-                    (member "login" (secrets-list-collections))))
+	;; There must be at least the collections "Login" and "session"
+        ;; except on Cygwin, wehre there is no "Login" collection.
+        (when (not (eq system-type 'cygwin))
+	  (should (or (member "Login" (secrets-list-collections))
+                      (member "login" (secrets-list-collections)))))
 	(should (member "session" (secrets-list-collections)))
 
 	;; Create a random collection.  This asks for a password
@@ -160,9 +162,10 @@ secrets--test-delete-all-session-items
 
 	;; There shall be no items in the "session" collection.
 	(should-not (secrets-list-items "session"))
-	;; There shall be items in the "Login" collection.
-	(should (or (secrets-list-items "Login")
-                    (secrets-list-items "login")))
+	;; There shall be items in the "Login" collection except on Cygwin.
+	(when (not (eq system-type 'cygwin))
+	  (should (or (secrets-list-items "Login")
+		      (secrets-list-items "login"))))
 
 	;; Create a new item.
 	(should (setq item-path (secrets-create-item "session" "foo" "secret")))
-- 
2.17.0

bug#33568: 27.0.50; Failing secrets tests on Cygwin

[Michael Albinus]

Ken Brown <kbrown@cornell.edu> writes:

Hi Ken,

> Two of the secrets tests fail on Cygwin (at least in my normal working
> environment) because there is no "Login" collection.  Not knowing
> anything about this, I'm inclined to take the easy way out, as in the
> attached patch.  Is there a better way of handling it?

Thanks for the report. I don't know whether there is a better way; let's
explore your system.

What do you get if you call (secrets-list-collections) ? (Maybe you must
load the library `secrets' first)

> Ken

Best regards, Michael.

bug#33568: 27.0.50; Failing secrets tests on Cygwin

[Ken Brown]

On 12/2/2018 4:17 AM, Michael Albinus wrote:

Hi Michael,

> Thanks for the report. I don't know whether there is a better way; let's
> explore your system.
> 
> What do you get if you call (secrets-list-collections) ? (Maybe you must
> load the library `secrets' first)

(load "secrets")
t

(secrets-list-collections)
("session")

Ken

bug#33568: 27.0.50; Failing secrets tests on Cygwin

[Michael Albinus]

Ken Brown <kbrown@cornell.edu> writes:

> Hi Michael,

Hi Ken,

> (secrets-list-collections)
> ("session")

Hmm. There's no "Login" collection, indeed. Nor any other collection but
the temporary "session" collection. I will see whether I could
reproduce the problem locally.

> Ken

Best regards, Michael.

bug#33568: 27.0.50; Failing secrets tests on Cygwin

[Michael Albinus]

Ken Brown <kbrown@cornell.edu> writes:

> Hi Michael,

Hi Ken,

sorry for the delay. Finally, I found a machine running cygwin for my tests.

>> Thanks for the report. I don't know whether there is a better way; let's
>> explore your system.
>> 
>> What do you get if you call (secrets-list-collections) ? (Maybe you must
>> load the library `secrets' first)
>
> (load "secrets")
> t
>
> (secrets-list-collections)
> ("session")

Hmm, same here, when using the GNOME desktop. I always thought that the
"login" keyring exist per default, but it doesn't. Maybe this is due to
different invocations od gnome-keyring-daemon. On my Ubuntu 18.10
system, it is

--8<---------------cut here---------------start------------->8---
$ ps -eaf | grep gnome-keyring
albinus   6340     1  0 Dec04 ?        00:02:03 /usr/bin/gnome-keyring-daemon --daemonize --login
--8<---------------cut here---------------end--------------->8---

OTOH, on cygwin I see

--8<---------------cut here---------------start------------->8---
$ ps -eaf | grep gnome-keyring
albinmic    5676       1 ?        16:09:48 /usr/bin/gnome-keyring-daemon
--8<---------------cut here---------------end--------------->8---

I can create the "login" keyring interactively, via seahorse. But this
doesn't count.

So I have removed the respective checks in secrets-tests.el, they are
not important. Could you pls check, whether this works for you?

> Ken

Best regards, Michael.

bug#33568: 27.0.50; Failing secrets tests on Cygwin

[Ken Brown]

On 12/12/2018 4:59 AM, Michael Albinus wrote:
> So I have removed the respective checks in secrets-tests.el, they are
> not important. Could you pls check, whether this works for you?

Thanks, Michael.  All tests pass now.  Closing.

Ken