From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#34915: 27.0.50; Wdired regression with ls -F Date: Fri, 26 Apr 2019 18:07:04 +0200 Message-ID: <87r29o3g47.fsf@gmx.net> References: <871s33ugi3.fsf@tcd.ie> <87sguncsz9.fsf@gmx.net> <87d0lrcrda.fsf@tcd.ie> <87ftqncr05.fsf@rub.de> <87sgu6f0zp.fsf@gmx.net> <87d0l8hnti.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="133534"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34915@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 26 18:08:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hK3OV-000Yaz-1S for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Apr 2019 18:08:11 +0200 Original-Received: from localhost ([127.0.0.1]:49083 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hK3OU-0003qN-0i for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Apr 2019 12:08:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hK3ON-0003oC-Ku for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2019 12:08:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hK3OM-0003jB-M4 for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2019 12:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48096) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hK3OM-0003j1-HX for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2019 12:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hK3OM-0008L3-8U for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2019 12:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Apr 2019 16:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34915 X-GNU-PR-Package: emacs Original-Received: via spool by 34915-submit@debbugs.gnu.org id=B34915.155629483631991 (code B ref 34915); Fri, 26 Apr 2019 16:08:02 +0000 Original-Received: (at 34915) by debbugs.gnu.org; 26 Apr 2019 16:07:16 +0000 Original-Received: from localhost ([127.0.0.1]:33407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hK3Nb-0008Ju-In for submit@debbugs.gnu.org; Fri, 26 Apr 2019 12:07:15 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:51493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hK3Na-0008Ji-Jv for 34915@debbugs.gnu.org; Fri, 26 Apr 2019 12:07:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556294826; bh=M0zfm2n1NR5ntqhFj2na+82F7iU33vBFzmCon+5NPn8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=XXMuZUfEpsgEh8OV3SfCpLacHTxL0U/ArUvVMc2KmDxC/fAvzmwLRpeDdC54s9tYj 5tYbbpIAeC0WxvzWx6IOAodSpCFt74saxfOtYfiLofVS8znmn+BqMMwcfLpvcC63G4 0V9pRhgf9ehvcDkUTHiTI+KjXOUKT3kh4LBBBy3s= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from linux-tuxedo ([188.109.169.84]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N0oG5-1gYhYd1z3l-00wjKk; Fri, 26 Apr 2019 18:07:06 +0200 In-Reply-To: <87d0l8hnti.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 26 Apr 2019 14:56:57 +0100") X-Provags-ID: V03:K1:v/w2bPQ5Iv+Srsu9+98geBSzXl02ewattPty8ZgBRjPlnolDoYz eh3uKEPQn129gckfzJeENeaawNy+Yts6gCunuzu8gux4jzNK9s4KdG3D4zEhtUvQLnNyD/l jQ1WXa/Ob7E3QAAywBHvSwMWwZYZids36XnV+efpkdIm33xTXgWOz7nnVPvF8QSOSH9/yOa aGSBZID+ezqt5kfPmMRNw== X-UI-Out-Filterresults: notjunk:1;V03:K0:RwG45375L70=:befTvJn7VMteVCd4MIkOO6 9sztadzrZe+MmDuGQPe2tIFmgtO/dc1ZK6X3aWDoLsp3+y5GkFbo7F7104r19GFbyDUEoUOo6 1zrzqfaU8o2mn2iVZScSFA3Z0Gf7Z1S9XpzfYKXv5JVZsz7of6gI8O9eGjOsFrBlpV7Kz3As+ TQI87U3MfYTklREbRikvDWL9lIJ37AR834TCMebZd4Sc2bXQ2uN1dn3S8kP2Ac42i5ZpNsAUY eLxDSDOcZmBQeOIxTxVk6hCzQHubGivsywyZHCIP7KYS27kiXperudruK5SkyUQp/wAQzN5+z mJLDcEHJcoerG3V/dUK2D0ksBsf0jVyx0lSHnoP37SI49dWInSvN6osP2kabTN0Cs+WYkHSFt Qx5lEWPwQYV9vhqClK9PwXLGJmBwujNDGHqqQ0qDY2dePrrYhAgowIvV5IAHyu44+VctVG5Nx CYVVYkQhLIapZCdb0CVaqM3S7vikoroVEbQZYx26REPpJuQMrAfll5XRYESKrgGjmNTmTqGE5 Gqyip3xUHNX0iJhidkv9IXbHDHLn5f428DU+ZQIN7YtdAtGlQdpTfXgDUMyvmBgIBWPu8vcl5 7yjVwgeVwfffpr5790QzniidJMMbOXEL45CbZa/0uJbvpnulvORr9lCU7ryXC4bl5Tjk6pVL3 F0RjTEBfu0bfWbUfDakruYdTGqfTw0WGb0xqlIlPE9nbWbOUQ5T37afVvV29tFjv033kInFR3 rHMCUtYqu0yQQWZbmCSOVh1iQ5a3B9yWMzCF61NLLfHa+XBta97+YguavU2gPKRZ2rO8rk2C X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158300 Archived-At: On Fri, 26 Apr 2019 14:56:57 +0100 "Basil L. Contovounesios" wrote: > Stephen Berman writes: > >> On Fri, 12 Apr 2019 15:06:18 +0200 Stephen Berman wrote: >> >>> On Fri, 12 Apr 2019 13:58:25 +0100 "Basil L. Contovounesios" >>> wrote: >>> >>>> Stephen Berman writes: >>>> >>>>> On Tue, 19 Mar 2019 13:43:16 +0000 "Basil L. Contovounesios" >>>>> wrote: >>>>> >>>>>> It seems like Wdired thinks the indicators added by ls (one of */=>@|) >>>>>> are part of the file name now. >>>>> >>>>> This is indeed due to my changes. The patch below appears to fix the >>>>> problem, but I'm not sure how robust it is (I was also, and remain, >>>>> unsure about my handling of symlinks in the previous patch, but I >>>>> haven't found time to look at it more closely; at least I haven't seen >>>>> any bug reports about it so far). >>>> >>>> I can confirm your patch fixes the issue, thanks! >>> >>> Thanks for testing. If there are no objections within a few days, I'll >>> push it to master. >> >> I didn't expect "a few days" to become almost two weeks, but I've >> finally pushed the fix to master as commit 6d8e0fc5aa. I slightly >> changed the patch to account for using either the short or long form of >> the indicator switch, and I added a test. > > Thanks. I noticed an opportunity for a tiny bit of reuse: [...] I'm not sure the two uses justify a new function, but I don't oppose it. > Which makes me wonder: is there no Dired function that > wdired--restore-dired-filename-prop can reuse for finding the boundaries > of a file name? Is dired-move-to-end-of-filename not suitable? It > seems to perform similar checks for symlinks and --classify. dired-move-to-end-of-filename doesn't work in wdired-mode because the dired-filename text property it uses was removed to fix bug#32173, and wdired--restore-dired-filename-prop was added to compensate. I couldn't come up with a more elegant solution. Steve Berman