From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35771: [PATCH] Customization type of recentf-max-saved-items Date: Fri, 17 May 2019 14:13:09 +0100 Message-ID: <87r28xxlzu.fsf@tcd.ie> References: <87pnohb79x.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="183199"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35771@debbugs.gnu.org To: Dario Gjorgjevski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 17 15:14:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRcgo-000lX6-CV for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 May 2019 15:14:22 +0200 Original-Received: from localhost ([127.0.0.1]:48483 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRcgn-0007fo-B2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 May 2019 09:14:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRcgZ-0007fG-8C for bug-gnu-emacs@gnu.org; Fri, 17 May 2019 09:14:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRcgX-0001m2-Cb for bug-gnu-emacs@gnu.org; Fri, 17 May 2019 09:14:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44225) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRcgU-0001hN-27 for bug-gnu-emacs@gnu.org; Fri, 17 May 2019 09:14:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hRcgT-0001rh-Qr for bug-gnu-emacs@gnu.org; Fri, 17 May 2019 09:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 May 2019 13:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35771 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35771-submit@debbugs.gnu.org id=B35771.15580988017083 (code B ref 35771); Fri, 17 May 2019 13:14:01 +0000 Original-Received: (at 35771) by debbugs.gnu.org; 17 May 2019 13:13:21 +0000 Original-Received: from localhost ([127.0.0.1]:57763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hRcfn-0001q8-Bh for submit@debbugs.gnu.org; Fri, 17 May 2019 09:13:21 -0400 Original-Received: from mail-ed1-f68.google.com ([209.85.208.68]:36841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hRcfl-0001po-C9 for 35771@debbugs.gnu.org; Fri, 17 May 2019 09:13:18 -0400 Original-Received: by mail-ed1-f68.google.com with SMTP id a8so10544104edx.3 for <35771@debbugs.gnu.org>; Fri, 17 May 2019 06:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=QvewQA2C1v4QYdELtj6KMgpcUY8xdLzRjYT/yLh8kU4=; b=xyKz56rotEMa+BVWwdXu0vhbw6VMPydgMYPTe2hZEmjKVfxoTjBE64p/IRXEboG7Op esuCulmEvuIetV8y3Sx4UKwATQogfAV3bfpRQcmy/v9sMJYR2QuZeuCcL4Sdncq3mJmU GiBZtyEwAcr6i7YM2AjwUiZBlYW/rMMHEtogsG3qq4lAsgBzdYNPT/GnPzxZhDt0M7rg 4U/eKwE3BDCeG/Jhue80nUCppWm+6wJsc6a6v7boqOIPBU52stBTr+IHIQgiyq+suGR0 KF9cQnrK+aVPNVO+WkXO1ldcQY4UWQ4ffQbzLnfHDTLaU7YfZIgBjU/ZHZ51SeNgzMGt DwuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=QvewQA2C1v4QYdELtj6KMgpcUY8xdLzRjYT/yLh8kU4=; b=pXCza54fc4dOv2loWD1j6UeQuMuRCd8QmN2gqykgSDFv6H6cWk6uSLf8GjBjQP3vDU f9DohD2ETeSeLS9zX+03xOUsBMQj5aBwXhjnCrNV+bA4J5Oi5u1qh+lOa8DdXz7Nl9Gf fQ+cANkUchK+KcBnBH+UUkyZt7+n6yvsc9Dqg2G6Fzg33hvHcAM5b2FwZhRpE5jvlD9e HwVNgFXPtZ82QWYdC/Gt4rlQrBe7W4kFnxDlZH45rdIhkyT6Ve4g+MFZGJ62u5NQ4neJ WUGei1SZecsDE1yqKHTmpqZnzkmnuFW0txuFKpylIkcQwu7ySHqzYtVFrvGyqLu3KqSv ATnQ== X-Gm-Message-State: APjAAAWCGE/qylxEY3kvCWgKSSHJqUXW4d38QP08T2OBg1bTYwVnLzr+ 3lEZAoiPxNSQdxuHp0hlFRU2Kg== X-Google-Smtp-Source: APXvYqzkENzBaJEInsCuMzbRYS/w0jizOuR/pTjYq8jFcjznPs9RtJg7/61H7Iw+oxyyqdcjV9+Cmw== X-Received: by 2002:a17:906:2785:: with SMTP id j5mr44018355ejc.94.1558098791345; Fri, 17 May 2019 06:13:11 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:6fa:38d6:1fce:ddb3]) by smtp.gmail.com with ESMTPSA id r14sm503846edd.0.2019.05.17.06.13.10 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 17 May 2019 06:13:10 -0700 (PDT) In-Reply-To: <87pnohb79x.fsf@gmail.com> (Dario Gjorgjevski's message of "Fri, 17 May 2019 14:22:02 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159447 Archived-At: severity 35771 minor quit Dario Gjorgjevski writes: > The customization type of recentf-max-saved-items is currently defined > as integer, which does not include nil in its domain. However, setting > this variable to nil is supported in the code and also documented. Indeed. > This patch changes the customization type to explicitly allow for the > variable to be set to nil through the Customization interface and > similar. The change LGTM, thanks. > (Please note that I copied the type from save-place-limit in order to > be consistent.) (I'm curious as to why :value is set to 1 rather than the default values 20 and 400 of the user options recentf-max-saved-items and save-place-limit, respectively. Not an important issue, though.) > From a62b4c6208f9d64bc49499855e65ae9b9a55b01e Mon Sep 17 00:00:00 2001 > From: Dario Gjorgjevski > Date: Fri, 17 May 2019 11:46:54 +0200 > Subject: [PATCH] Customization type of recentf-max-saved-items See the outlines "Commit messages" and "Generating ChangeLog entries" in the file CONTRIBUTE for the preferred commit message format. In particular, it should mention the names of the file and variable changed, as well as the bug#number. The change is small enough to be exempt from copyright paperwork, but if you are interested in contributing more in the future, I recommend starting the assignment process early; see (info "(emacs) Copyright Assignment"). Thanks, -- Basil