From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Dario Gjorgjevski <dario.gjorgjevski@gmail.com>
Cc: 35771@debbugs.gnu.org
Subject: bug#35771: [PATCH] Customization type of recentf-max-saved-items
Date: Fri, 17 May 2019 14:13:09 +0100 [thread overview]
Message-ID: <87r28xxlzu.fsf@tcd.ie> (raw)
In-Reply-To: <87pnohb79x.fsf@gmail.com> (Dario Gjorgjevski's message of "Fri, 17 May 2019 14:22:02 +0200")
severity 35771 minor
quit
Dario Gjorgjevski <dario.gjorgjevski@gmail.com> writes:
> The customization type of recentf-max-saved-items is currently defined
> as integer, which does not include nil in its domain. However, setting
> this variable to nil is supported in the code and also documented.
Indeed.
> This patch changes the customization type to explicitly allow for the
> variable to be set to nil through the Customization interface and
> similar.
The change LGTM, thanks.
> (Please note that I copied the type from save-place-limit in order to
> be consistent.)
(I'm curious as to why :value is set to 1 rather than the default values
20 and 400 of the user options recentf-max-saved-items and
save-place-limit, respectively. Not an important issue, though.)
> From a62b4c6208f9d64bc49499855e65ae9b9a55b01e Mon Sep 17 00:00:00 2001
> From: Dario Gjorgjevski <dario.gjorgjevski+git@gmail.com>
> Date: Fri, 17 May 2019 11:46:54 +0200
> Subject: [PATCH] Customization type of recentf-max-saved-items
See the outlines "Commit messages" and "Generating ChangeLog entries"
in the file CONTRIBUTE for the preferred commit message format.
In particular, it should mention the names of the file and variable
changed, as well as the bug#number.
The change is small enough to be exempt from copyright paperwork,
but if you are interested in contributing more in the future,
I recommend starting the assignment process early;
see (info "(emacs) Copyright Assignment").
Thanks,
--
Basil
next prev parent reply other threads:[~2019-05-17 13:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 12:22 bug#35771: [PATCH] Customization type of recentf-max-saved-items Dario Gjorgjevski
2019-05-17 13:13 ` Basil L. Contovounesios [this message]
2019-05-17 13:33 ` Eli Zaretskii
2019-05-17 14:14 ` Basil L. Contovounesios
2019-05-17 14:39 ` Eli Zaretskii
2019-05-19 9:15 ` Dario Gjorgjevski
2019-05-23 0:21 ` Basil L. Contovounesios
2019-05-17 13:36 ` Drew Adams
2019-05-17 14:17 ` Basil L. Contovounesios
2019-05-17 15:30 ` Drew Adams
2019-05-18 16:58 ` Basil L. Contovounesios
2019-05-18 23:10 ` Drew Adams
2019-05-19 2:52 ` Basil L. Contovounesios
2019-05-22 5:28 ` Eli Zaretskii
2019-05-23 0:24 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r28xxlzu.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=35771@debbugs.gnu.org \
--cc=dario.gjorgjevski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.