From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#35737: xref--original-command Date: Fri, 24 May 2019 21:40:27 +0300 Organization: LINKOV.NET Message-ID: <87r28nenzk.fsf@mail.linkov.net> References: <87ftpgu59l.fsf@mail.linkov.net> <56943df5-f366-a8af-cb95-a40c244da837@yandex.ru> <87tvdvpgzj.fsf@mail.linkov.net> <87woiqkwok.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="67494"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 35737@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 24 20:44:38 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hUFBF-000HQZ-0t for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 May 2019 20:44:37 +0200 Original-Received: from localhost ([127.0.0.1]:58753 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUFBE-0006KR-1s for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 May 2019 14:44:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUFAk-00060u-Bk for bug-gnu-emacs@gnu.org; Fri, 24 May 2019 14:44:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hUFAj-0004wn-3F for bug-gnu-emacs@gnu.org; Fri, 24 May 2019 14:44:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33791) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hUFAi-0004wU-Vp for bug-gnu-emacs@gnu.org; Fri, 24 May 2019 14:44:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hUFAi-0000jn-Sb for bug-gnu-emacs@gnu.org; Fri, 24 May 2019 14:44:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 May 2019 18:44:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35737 X-GNU-PR-Package: emacs Original-Received: via spool by 35737-submit@debbugs.gnu.org id=B35737.15587234162771 (code B ref 35737); Fri, 24 May 2019 18:44:04 +0000 Original-Received: (at 35737) by debbugs.gnu.org; 24 May 2019 18:43:36 +0000 Original-Received: from localhost ([127.0.0.1]:47331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUFAG-0000iD-Gs for submit@debbugs.gnu.org; Fri, 24 May 2019 14:43:36 -0400 Original-Received: from ladybird.maple.relay.mailchannels.net ([23.83.214.98]:9296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hUFAE-0000i3-M7 for 35737@debbugs.gnu.org; Fri, 24 May 2019 14:43:35 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 551421A1677; Fri, 24 May 2019 18:43:33 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a67.g.dreamhost.com (100-96-11-129.trex.outbound.svc.cluster.local [100.96.11.129]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E89031A2437; Fri, 24 May 2019 18:43:29 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a67.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Fri, 24 May 2019 18:43:33 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Fearful-Juvenile: 1602a01f7d03b7bf_1558723413109_1969168816 X-MC-Loop-Signature: 1558723413108:3567421722 X-MC-Ingress-Time: 1558723413108 Original-Received: from pdx1-sub0-mail-a67.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a67.g.dreamhost.com (Postfix) with ESMTP id 7514C8068C; Fri, 24 May 2019 11:43:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=fiSt+3uQgFfBPlW/GBYuXkUbk9A=; b= 0JC5DB9n1PtXs36G+AbjP47HssDZvLZvutXKsuQy10vBvULdk8V33khb5kS5iuyF Wa1X4xxKQEfzg/JH3bUYFBgIdGDDTW5zgTEPGDY6irn0InyyuMIUS7+tqi9K4ZS4 vCjWgWMT6uot5tW56/fiVC4MDYWDs03mDZShIwuoFJU= Original-Received: from mail.jurta.org (m91-129-96-230.cust.tele2.ee [91.129.96.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a67.g.dreamhost.com (Postfix) with ESMTPSA id ADA8F80696; Fri, 24 May 2019 11:43:22 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a67 In-Reply-To: (Dmitry Gutov's message of "Fri, 24 May 2019 04:59:40 +0300") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrudduiedgudefudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirddvfedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledrleeirddvfedtpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgepud X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159725 Archived-At: >>> But please wait a little, I'd like to show a patch for bug#35702 that can >>> also provide a basic for the same distinction in functionality but without >>> this variable. >> >> OK. > > Please see the latest commits. Thanks, I tried xref revert and it works fine. Also I agree with Eli regarding the command name, documentation and NEWS. > In particular, there is now a xref-show-definitions-function. > > So in addition to display-buffer-alist, you can change it to give > xref-find-definitions a particular behavior. But I don't want to write a new function. I just need to check if the xref buffer was created by a particular command. If the solution requires writing a new function, then much easier would be to use 'advice-add': (advice-add 'xref-find-definitions :after (lambda (&rest _args) (with-current-buffer (window-buffer) (setq-local xref--original-command 'xref-find-definitions)))) > Or to propose a new default behavior, suggest a patch for > xref--show-defs-buffer. It could do its own things instead of delegating to > xref--show-xref-buffer, i.e. use a distinct new major mode and somewhat > different keymap. And also call pop-to-buffer with different arguments. If despite a chain of indirections, xref still can't distinguish different commands that created the xref buffer, I'd rather close this feature request and use 'advice-add' in customization.