all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: philip@warpmail.net (Philip K.)
Cc: 34940@debbugs.gnu.org
Subject: bug#34940: [PATCH 1/1] lisp/gnus/nnir.el: prefer $MAILDIR over $HOME/Mail as notmuch prefix
Date: Sat, 01 Jun 2019 19:09:09 +0100	[thread overview]
Message-ID: <87r28d6uuy.fsf@tcd.ie> (raw)
In-Reply-To: <87a7f3t7tp.fsf@bulbul> (Philip K.'s message of "Fri, 31 May 2019 09:13:38 +0200")

> From 09de2282a0c9dc2e74c61d2dc1b5b2abf64319bf Mon Sep 17 00:00:00 2001
> From: Philip K <philip@warpmail.net>
> Date: Fri, 31 May 2019 09:10:18 +0200
> Subject: [PATCH] lisp/gnus/nnir.el: prefer $MAILDIR over $HOME/Mail as notmuch
>  prefix
>
> ---
>  lisp/gnus/nnir.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/gnus/nnir.el b/lisp/gnus/nnir.el
> index 9d59a4db0d..b07390ec81 100644
> --- a/lisp/gnus/nnir.el
> +++ b/lisp/gnus/nnir.el
> @@ -507,7 +507,8 @@ Instead, use this:
>    :type '(repeat (string))
>    :group 'nnir)
>  
> -(defcustom nnir-notmuch-remove-prefix (concat (getenv "HOME") "/Mail/")
> +(defcustom nnir-notmuch-remove-prefix (concat (getenv "MAILDIR")
> +                                              (getenv "HOME") "/Mail/")

Shouldn't this be:

  (or (getenv "MAILDIR")
      (concat (getenv "HOME") "/Mail/"))

which BTW I think is better as:

  (or (getenv "MAILDIR")
      (expand-file-name "Mail/" (getenv "HOME")))

Thanks,

-- 
Basil





  reply	other threads:[~2019-06-01 18:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 20:49 bug#34940: [PATCH 1/1] lisp/gnus/nnir.el: prefer $MAILDIR over $HOME/Mail as notmuch prefix Philip K
2019-03-22  9:18 ` Robert Pluim
2019-05-31  7:13 ` Philip K.
2019-06-01 18:09   ` Basil L. Contovounesios [this message]
2019-06-01 18:45     ` Andreas Schwab
2019-06-22 12:55       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r28d6uuy.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=34940@debbugs.gnu.org \
    --cc=philip@warpmail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.