From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: Gnus nnir patch for Emacs 26? Date: Fri, 14 Jun 2019 01:18:39 -0700 Message-ID: <87r27weg0w.fsf@ericabrahamsen.net> References: <87tvcuscih.fsf@ericabrahamsen.net> <83y325ztr0.fsf@gnu.org> <87wohp2kl7.fsf@ericabrahamsen.net> <83v9x8ya89.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="181410"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 14 10:20:20 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbhRb-000l0u-QS for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 10:20:19 +0200 Original-Received: from localhost ([::1]:49214 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbhRa-0006Ft-Su for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 04:20:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52644) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbhRU-0006CV-14 for emacs-devel@gnu.org; Fri, 14 Jun 2019 04:20:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbhRS-00037U-Ux for emacs-devel@gnu.org; Fri, 14 Jun 2019 04:20:11 -0400 Original-Received: from [195.159.176.226] (port=53456 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbhRS-00034U-NW for emacs-devel@gnu.org; Fri, 14 Jun 2019 04:20:10 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hbhRP-000kcz-N8 for emacs-devel@gnu.org; Fri, 14 Jun 2019 10:20:07 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:KOkNoKkVJNXg49uhqG56DoPZi+g= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237581 Archived-At: Eli Zaretskii writes: >> From: Eric Abrahamsen >> Date: Thu, 13 Jun 2019 15:20:52 -0700 >> >> > If this patch indeed fixes the problem, it's okay for emacs-26, but >> > please only add that one line, don't reindent anything and don't >> > replace lambda with its fancier equivalent. Just the minimal required >> > change. >> >> Here's a proper commit with a simpler-looking version that doesn't >> re-indent everything. I've done before-and-after tests and this works >> just the same. I've also added a do not merge thing following Robert's >> pointer. >> >> How's it look? > > Fine with me, thanks. Cool, will push tomorrow. > P.S. I was wondering why we use all those wrappers around > decode-coding-string instead of calling the latter directly, but since > you are saying this code will go away in Emacs 27, this is a moot > point. I do suggest to look for such trivial wrappers on master and > eliminate them if any are still there, as a cleanup. The code in scratch/gnus-decoded will do some of that, since the point of that branch is to make sure group names are decoded strings as they enter the system, rather than decoding them as they come out of the system (ie, as they are presented to the user).