From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#14769: [PATCH] optimize `concat's literals Date: Tue, 18 Jun 2019 21:43:32 -0400 Message-ID: <87r27qwdrv.fsf@gmail.com> References: <6BF130E1-F25B-4E1B-B55D-224F0CCEC133@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="76559"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: Lars Ingebrigtsen , Stefan Monnier , 14769@debbugs.gnu.org, shigeru.fukaya@gmail.com To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 19 03:44:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hdPdx-000JnP-87 for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Jun 2019 03:44:09 +0200 Original-Received: from localhost ([::1]:34524 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdPdv-0007Fs-Sj for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Jun 2019 21:44:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56829) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdPdr-0007Fm-LW for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2019 21:44:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdPdq-0000LE-NP for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2019 21:44:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60484) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hdPdq-0000KY-H1 for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2019 21:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hdPdq-0007oZ-4Q for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2019 21:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2019 01:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14769-submit@debbugs.gnu.org id=B14769.156090862130006 (code B ref 14769); Wed, 19 Jun 2019 01:44:02 +0000 Original-Received: (at 14769) by debbugs.gnu.org; 19 Jun 2019 01:43:41 +0000 Original-Received: from localhost ([127.0.0.1]:45795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdPdV-0007nu-Gf for submit@debbugs.gnu.org; Tue, 18 Jun 2019 21:43:41 -0400 Original-Received: from mail-io1-f42.google.com ([209.85.166.42]:34821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hdPdT-0007nh-DM for 14769@debbugs.gnu.org; Tue, 18 Jun 2019 21:43:39 -0400 Original-Received: by mail-io1-f42.google.com with SMTP id m24so34518209ioo.2 for <14769@debbugs.gnu.org>; Tue, 18 Jun 2019 18:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=j4gOImgXIdvi5XWcE1QNxrxYChLZwyYPpvfK+TKDxbg=; b=hM6akhI+QnqpAKGUnlRl+RmwceKRcJhjUjCxII85GOvF5601EcAVwgBhFVYwLObXrQ +bDDdK8TzJxlNOCKWMjw5S1GB68udaeOu7m1EbabRew6c78BYboZWnMqwDU8fTDZ+Jek co+zUYMhknN/pOxIvqxnJWTN17fNRpbiy3cPBm/tS0Os+dU/k04MtY/vqB0US/AI2im4 GgnqeiD5sDX/jXTcDh6DPVr7ROYqX376gE8STvWw/+fbtWU9WC2ga9aMsQ0lIFhSMRzx FqLAmZh9x6GncZm2/uyR0QGTUPvmyJ1H3f91iIyPTq2JpTQ9J1aAk8DZOAqOJVXR1iVr YAbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=j4gOImgXIdvi5XWcE1QNxrxYChLZwyYPpvfK+TKDxbg=; b=KUE/oJvrNXFEq1MbQ3pljz7Vz+gpJrJ/94Kbc6S8CqLBgoty0oZLnxhg3AauqslaUY bcZVwDZJwfCILCIx+P9bPdb8lI3+yoL28M3v1pVMbDMAw6tlS1qJUQdNjbNJkTi3W+V1 yXpvePA19X3XI2ENpB/aUbsspcyoen6hZbzTZ9D+hHHiQc0A4PqaZdoYKc2SMY+k98/8 8BbwStU1rx9UQKYIq6Wep4uSqUkhzMvV2npnBityJB7Cytrk3u95AvHHeTJBe5mU4eI4 HCO9hp0HMrnRg9V/Tufxnc3LBIdp8mEH1+08um0OIoTqv2W37Tv0i1npuX/Fns22W6Ef eGLA== X-Gm-Message-State: APjAAAXABymXppgGTfWtw3+rzNjiBtREuqzRc1Ol6UbAqr8SboyLqpAB 3m52pwbeTlYzY08eH9O5Gbg= X-Google-Smtp-Source: APXvYqx3H/bunXwZN7BKdLd5PRUuVxXtQahsDkwrPfYf0oxGP5qTc/RLzG7WKLyXTFE5/D+lIlXhKA== X-Received: by 2002:a5e:9241:: with SMTP id z1mr22659874iop.39.1560908613938; Tue, 18 Jun 2019 18:43:33 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id y18sm20167788iob.64.2019.06.18.18.43.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Jun 2019 18:43:33 -0700 (PDT) In-Reply-To: <6BF130E1-F25B-4E1B-B55D-224F0CCEC133@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Sun, 16 Jun 2019 13:57:44 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160813 Archived-At: Mattias Engdeg=C3=A5rd writes: > + (dolist (arg (cdr form)) > + (let ((val (eval arg))) > + ;; Constant arg: concat with previous. > + (setq accum (concat accum val))))) Hmm, I think the OP's patch is careful not to concat in a loop like this: it's O(n^2). I guess for most human written code n is small enough that it doesn't matter, but I could imagine this slowing compilation of a very big rx macro.