From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#27465: 24.5; `dired-mark-unmarked-files' with non-nil UNFLAG-P Date: Sun, 21 Jul 2019 17:41:31 +0200 Message-ID: <87r26j4cpg.fsf@mouse.gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="153149"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 27465@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 21 17:42:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpDyS-000dhz-E6 for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Jul 2019 17:42:08 +0200 Original-Received: from localhost ([::1]:56526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpDyR-000164-FJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Jul 2019 11:42:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51465) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpDyO-00010B-Fz for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2019 11:42:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpDyM-0006Sy-D4 for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2019 11:42:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hpDyM-0006Sj-9w for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2019 11:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hpDyM-00038W-5O for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2019 11:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jul 2019 15:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27465 X-GNU-PR-Package: emacs Original-Received: via spool by 27465-submit@debbugs.gnu.org id=B27465.156372369712007 (code B ref 27465); Sun, 21 Jul 2019 15:42:02 +0000 Original-Received: (at 27465) by debbugs.gnu.org; 21 Jul 2019 15:41:37 +0000 Original-Received: from localhost ([127.0.0.1]:59338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpDxx-00037b-Dh for submit@debbugs.gnu.org; Sun, 21 Jul 2019 11:41:37 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:59904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpDxv-00037R-SN for 27465@debbugs.gnu.org; Sun, 21 Jul 2019 11:41:36 -0400 Original-Received: from [80.169.244.84] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpDxs-0005JJ-AS; Sun, 21 Jul 2019 17:41:34 +0200 In-Reply-To: (Drew Adams's message of "Fri, 23 Jun 2017 15:44:21 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163533 Archived-At: Drew Adams writes: > 3. Non-nil UNFLAG-P does nothing, AFAICT. It _cannot_ do anything. > Certainly it cannot unflag, which means change a deletion flag (`D') > to a space char. Why? Because the replacement is applied only to > lines that already have a space char (not a `D'). > > Its effect in that case is indeed to post a space char. But it does > so only for lines that already have a space char! > > This is the call: > > (dired-mark-if > (and > (looking-at-p " ") ; <=== Mark (with a SPC) only if already there! > (let ((fn (dired-get-filename localp t))) > (and fn (string-match-p regexp fn)))) > msg) I've now made unflag-p work on the Emacs trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no