From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master b75fb81 1/4: Extend button.el to take callback data Date: Fri, 02 Aug 2019 20:41:51 +0200 Message-ID: <87r263o1e8.fsf@mouse.gnus.org> References: <20190730132507.32385.70681@vcs0.savannah.gnu.org> <20190730132509.77D2820C0A@vcs0.savannah.gnu.org> <87lfwd2ihn.fsf@tcd.ie> <87pnlpm5x9.fsf@mouse.gnus.org> <87ef24vrpz.fsf@tcd.ie> <877e7wlv98.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="226295"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 02 20:47:33 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htcaS-000wku-H6 for ged-emacs-devel@m.gmane.org; Fri, 02 Aug 2019 20:47:32 +0200 Original-Received: from localhost ([::1]:36968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htcaQ-0001Uh-SV for ged-emacs-devel@m.gmane.org; Fri, 02 Aug 2019 14:47:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37651) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htcV8-00073Y-D0 for emacs-devel@gnu.org; Fri, 02 Aug 2019 14:42:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1htcV7-0002Pl-BR for emacs-devel@gnu.org; Fri, 02 Aug 2019 14:42:02 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:56652) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1htcV7-0002L7-4G for emacs-devel@gnu.org; Fri, 02 Aug 2019 14:42:01 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htcUy-0004uD-Lg; Fri, 02 Aug 2019 20:41:55 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 01 Aug 2019 16:44:19 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239144 Archived-At: Stefan Monnier writes: >> (make-text-button start (point) >> 'face 'rcirc-url >> 'follow-link t >> 'burron-data url >> 'action #'browse-url) > > Odd. I thought the benefit was for > > (define-button-type 'my-type 'action #'browse-url) > > [...] > > (make-text-button start (point) > 'type 'my-type > 'burron-data url) > > where a closure is not an option. Ah, yes, that seems useful. > In this for the purpose of designing new APIs, we can take it for > granted that lexical-scoping is available. It's easy enough to convert > an old package to use lexical-scoping. In this case, I just wanted to rewrite some stuff to avoid using widgets, which can be rather convoluted to reason about. But it does have callback values like this, so this brings button a feature to make conversion easier. But, yes, everything should be converted to lexical binding, and then my example use case is much less of a thing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no