all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: Alex Branham <alex.branham@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
	Marco Wahl <marcowahlsoft@gmail.com>,
	26328@debbugs.gnu.org
Subject: bug#26328: 26.0.50; checkdoc action for join lines drops final "
Date: Thu, 15 Aug 2019 20:11:19 -0400	[thread overview]
Message-ID: <87r25motp4.fsf@gmail.com> (raw)
In-Reply-To: <877e7eowe2.fsf@gmail.com> (Alex Branham's message of "Thu, 15 Aug 2019 18:13:09 -0500")

Alex Branham <alex.branham@gmail.com> writes:

> How about we just use delete-indentation along with the
> already-calculate position p that we just asked the user about? Patch
> attached.

> +		   (when (checkdoc-autofix-ask-replace
> +		          p (1+ p)
> +		          "1st line not a complete sentence.  Join these lines? "
> +		          " " t)
> +		     ;; They said yes.  We have more fill work to do...
> +		     (delete-indentation nil p (1+ p))
> +		     (setq msg nil)))))

Note that the checkdoc-autofix-ask-replace is already replacing the
newline with a space (which is kind of a strange behaviour, IMO, but
that's how it is currently), so I'm not sure it makes much sense to call
delete-indentation after.





  parent reply	other threads:[~2019-08-16  0:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01  8:51 bug#26328: 26.0.50; checkdoc action for join lines drops final " Marco Wahl
2019-07-26 10:51 ` Lars Ingebrigtsen
2019-07-28 14:05   ` Noam Postavsky
2019-07-29 11:09     ` Lars Ingebrigtsen
2019-08-15 23:13       ` Alex Branham
2019-08-15 23:18         ` Lars Ingebrigtsen
2019-08-16  0:11         ` Noam Postavsky [this message]
2019-08-16 13:24           ` Alex Branham
2019-08-16 13:42             ` Noam Postavsky
2019-08-16 13:55               ` Alex Branham
2019-08-16 14:01                 ` Noam Postavsky
2019-08-16 20:54             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r25motp4.fsf@gmail.com \
    --to=npostavs@gmail.com \
    --cc=26328@debbugs.gnu.org \
    --cc=alex.branham@gmail.com \
    --cc=larsi@gnus.org \
    --cc=marcowahlsoft@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.