From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Damien Cassou Newsgroups: gmane.emacs.bugs Subject: bug#37034: 26.2.90; checkdoc doesn't support cl-defgeneric, cl-defmethod and cl-defun Date: Fri, 16 Aug 2019 14:28:30 +0200 Message-ID: <87r25l1ehd.fsf@cassou.me> References: <877e7e280t.fsf@cassou.me> <871rxmxyvc.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="141640"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37034@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 16 14:29:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hybM2-000ain-2X for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Aug 2019 14:29:14 +0200 Original-Received: from localhost ([::1]:55160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hybM0-0004MB-MS for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Aug 2019 08:29:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57598) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hybLr-0004HG-UL for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2019 08:29:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hybLq-0001Aa-Nu for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2019 08:29:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44432) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hybLq-0001AU-Kz for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2019 08:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hybLq-0008Kz-CU for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2019 08:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Aug 2019 12:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37034 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37034-submit@debbugs.gnu.org id=B37034.156595851832020 (code B ref 37034); Fri, 16 Aug 2019 12:29:02 +0000 Original-Received: (at 37034) by debbugs.gnu.org; 16 Aug 2019 12:28:38 +0000 Original-Received: from localhost ([127.0.0.1]:53253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hybLS-0008KO-0O for submit@debbugs.gnu.org; Fri, 16 Aug 2019 08:28:38 -0400 Original-Received: from mail.choca.pics ([62.210.108.126]:49664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hybLO-0008KF-7g for 37034@debbugs.gnu.org; Fri, 16 Aug 2019 08:28:36 -0400 Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 9AABCF05329; Fri, 16 Aug 2019 14:28:32 +0200 (CEST) Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id jEfd9zyEN8Za; Fri, 16 Aug 2019 14:28:32 +0200 (CEST) Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 068B8F0532F; Fri, 16 Aug 2019 14:28:32 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id uY8dimWcOaPT; Fri, 16 Aug 2019 14:28:31 +0200 (CEST) Original-Received: from luz4 (199.138.120.78.rev.sfr.net [78.120.138.199]) by mail.choca.pics (Postfix) with ESMTPSA id BB484F05329; Fri, 16 Aug 2019 14:28:31 +0200 (CEST) In-Reply-To: <871rxmxyvc.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165200 Archived-At: Hi Alex, Alex Branham writes: > tags 37034 + patch thank you for your patch. Nevertheless, it's not going to be enough. For example, CL methods can have this signature: (cl-defmethod navigel-children ((entities list) callback) "Execute CALLBACK with the children of ENTITIES as argument." (navigel-async-mapcar entities #'navigel-children callback)) But this crashes checkdoc+patch because it expects each element of the parameter list to be a symbol which (entities list) is not. Also, CL methods accept &key and &context to specify parameters. Those should be taken care of by checkdoc in one way or another. -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill