all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Damien Cassou <damien@cassou.me>
To: Alex Branham <alex.branham@gmail.com>
Cc: 37034@debbugs.gnu.org
Subject: bug#37034: 26.2.90; checkdoc doesn't support cl-defgeneric, cl-defmethod and cl-defun
Date: Fri, 16 Aug 2019 14:28:30 +0200	[thread overview]
Message-ID: <87r25l1ehd.fsf@cassou.me> (raw)
In-Reply-To: <871rxmxyvc.fsf@gmail.com>

Hi Alex,

Alex Branham <alex.branham@gmail.com> writes:
> tags 37034 + patch

thank you for your patch. Nevertheless, it's not going to be enough. For
example, CL methods can have this signature:

(cl-defmethod navigel-children ((entities list) callback)
  "Execute CALLBACK with the children of ENTITIES as argument."
  (navigel-async-mapcar entities  #'navigel-children callback))

But this crashes checkdoc+patch because it expects each element of the
parameter list to be a symbol which (entities list) is not.

Also, CL methods accept &key and &context to specify parameters. Those
should be taken care of by checkdoc in one way or another.

-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill





  reply	other threads:[~2019-08-16 12:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15  7:38 bug#37034: 26.2.90; checkdoc doesn't support cl-defgeneric, cl-defmethod and cl-defun Damien Cassou
2019-08-15 14:54 ` Alex Branham
2019-08-16 12:28   ` Damien Cassou [this message]
2019-08-16 17:26     ` Alex Branham
2019-08-16 21:00       ` Lars Ingebrigtsen
2019-08-17 11:45         ` Damien Cassou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r25l1ehd.fsf@cassou.me \
    --to=damien@cassou.me \
    --cc=37034@debbugs.gnu.org \
    --cc=alex.branham@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.