From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= Newsgroups: gmane.emacs.devel Subject: Re: master b82adee: Invalidate dir-locals-directory-cache when writing dir-local file Date: Tue, 20 Aug 2019 09:48:26 +0200 Message-ID: <87r25g1dmd.fsf@gmail.com> References: <20190818224934.1914.38804@vcs0.savannah.gnu.org> <20190818224935.1ACDA20A0E@vcs0.savannah.gnu.org> <87o90m3x4j.fsf@mouse.gnus.org> <837e79nang.fsf@gnu.org> <87y2zp1nzk.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="6108"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Johan Claesson , Eli Zaretskii , Stefan Monnier , Emacs developers To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 20 09:52:39 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hzywZ-0001PH-CV for ged-emacs-devel@m.gmane.org; Tue, 20 Aug 2019 09:52:39 +0200 Original-Received: from localhost ([::1]:34388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzywY-0006AA-4E for ged-emacs-devel@m.gmane.org; Tue, 20 Aug 2019 03:52:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49590) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzysa-0000GV-LF for emacs-devel@gnu.org; Tue, 20 Aug 2019 03:48:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzysZ-0004cF-As for emacs-devel@gnu.org; Tue, 20 Aug 2019 03:48:32 -0400 Original-Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:50583) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hzysX-0004bK-Jr; Tue, 20 Aug 2019 03:48:29 -0400 Original-Received: by mail-wm1-x344.google.com with SMTP id v15so1724367wml.0; Tue, 20 Aug 2019 00:48:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=OnPgVLLcL5t2h2clTQihL22Fg1vgkLEKFgLHOMXbLhc=; b=m3afwE0F5drTuOW22hsmUNDT8f24rmOuOQR5E+7ki2c5vWgb3GFDe9cE0Ak+ypkVDz ZVktou1OGQX+C0c3//7SfW26lGqibHBSWpGNSkbtnLwz9QxxnrVWbJj8UA3l2Jbgxa4b 8tKc4UYyqoL5phVQHw9AxyO6ZtJAQ82KtViIWgrl5Ow7/LZHAzbW3hBRd3o0SHVlqEwb QgZ1x27YtduXrz16siZ7JBDGsnGfN7snsnPdR+wNJDhoCI7NbdnxtccX5DUgd0v+/3oS e8sgFqjjPs2dqAOShsvMy0O5srMcWuQlOYKVNUsEWc2MYzbaZIfK3Wq9QNXj4Yh765Zl jHnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=OnPgVLLcL5t2h2clTQihL22Fg1vgkLEKFgLHOMXbLhc=; b=YwZrwkfjs2gmZvO7QIS5Wjl/7xa2XOXgjv7gOLF5LqI8jbfa2yXUYjVwbkivcrMWbx dAX51eWYvAgQa2jrpNE4bICBXkH3ZGgXB8Be7nP0uqBUQEHroEJuZdtOg2FGA+hKirLW cL30n+p83gql/ako4e1470a8ys4rLIzmyz7e8QRe9Pe4LzYXM+6d1/wl7V/FBGb1A2tG s+3eY4lpfYlJNfAgVRhRqd1LhutDq2d/xZO42qvbenrQn4h/UeMfl7ziEfA96ONbhgE5 1ul+XqC24GTIs/Q/0W8FLYZN06t6rgwquVuAezpIKDf+1N90JwhKpVNL2gK4w9hsVO9a /73w== X-Gm-Message-State: APjAAAWWgNUmEJG5VC5LujT0V2vcW3jzwL19cWwmFsEB2/s/3Ch6JQQq 2fFA2+wg0MVHO94gtCHmwcU= X-Google-Smtp-Source: APXvYqxBjtk265+X8CjfyiQ3G9rQx4PEIjnBDY6njg+Xl7/dCkpufodqQ7wlCWYaihwPrJPRzso63g== X-Received: by 2002:a1c:5402:: with SMTP id i2mr24140909wmb.41.1566287308133; Tue, 20 Aug 2019 00:48:28 -0700 (PDT) Original-Received: from localhost ([185.112.167.114]) by smtp.gmail.com with ESMTPSA id b136sm37997854wme.18.2019.08.20.00.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2019 00:48:27 -0700 (PDT) In-Reply-To: (Noam Postavsky's message of "Mon, 19 Aug 2019 13:05:58 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239473 Archived-At: On Mon, 19 Aug 2019 13:05:58 -0400 Noam Postavsky wrote: > On Mon, 19 Aug 2019 at 05:52, =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec wrote: > >> >>> Oops; forgot the "Copyright-paperwork-exempt: yes", and I guess it's= too >> >>> late to amend after I've pushed? >> >> Too late. >> > >> > Yup. Hard to believe we're still stuck with this problem of "unfixable >> > commit messages" after all these years. >> >> There's "git notes", but I guess you're aware of that. >> >> : "A typical use of notes is to >> supplement a commit message without changing the commit itself." > > Although this only adds to the message, right? A few years ago, > someone proposed 'git replace --edit' for this, but I found it creates > a lot of refs which cause noticeable slowdown for all git > operations[1]. Not sure if 'git notes' would also create many refs. > Andreas Schwab mentioned something about a new git refs backend to > scale better[2]. Did anything ever come of that? > > [1]: https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg01240.html > [2]: https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg01185.html Ah, I knew the git notes suggestion seemed too obvious to be useful... It seems good for adding a pseudo-header to an occasional commit after the fact (without changing the commit object) such as here, but I'd expect you hit the same scalability issues as demonstrated in your tests with git replace, if used in bulk on a repo of this size. (I have no data to back that up, though, neither can I comment on your second question.) --=20 =C5=A0t=C4=9Bp=C3=A1n