From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37063: 26.2.90; Problems with recent CL support in checkdoc Date: Thu, 10 Oct 2019 02:21:55 +0200 Message-ID: <87r23lsb4s.fsf@gnus.org> References: <87imqw10je.fsf@cassou.me> <87sgodiv57.fsf@dick> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="210569"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37063@debbugs.gnu.org To: dick.r.chiang@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 10 02:23:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIMEZ-000sfI-Bk for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Oct 2019 02:23:11 +0200 Original-Received: from localhost ([::1]:60976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIMEY-0005SV-61 for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 20:23:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45101) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIMER-0005SK-PL for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 20:23:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIMEQ-0005kv-OU for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 20:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45707) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIMEQ-0005kr-Lk for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 20:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iIMEQ-0002tv-H0 for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 20:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Oct 2019 00:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37063 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37063-submit@debbugs.gnu.org id=B37063.157066692211033 (code B ref 37063); Thu, 10 Oct 2019 00:23:02 +0000 Original-Received: (at 37063) by debbugs.gnu.org; 10 Oct 2019 00:22:02 +0000 Original-Received: from localhost ([127.0.0.1]:54522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIMDS-0002ri-60 for submit@debbugs.gnu.org; Wed, 09 Oct 2019 20:22:02 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:47954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIMDP-0002rV-E3 for 37063@debbugs.gnu.org; Wed, 09 Oct 2019 20:21:59 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIMDL-0006Yr-IL; Thu, 10 Oct 2019 02:21:57 +0200 In-Reply-To: <87sgodiv57.fsf@dick> (dick r. chiang's message of "Mon, 30 Sep 2019 12:52:36 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168827 Archived-At: dick.r.chiang@gmail.com writes: > diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el > index 51fb75da69..6c40bdf632 100644 > --- a/lisp/emacs-lisp/checkdoc.el > +++ b/lisp/emacs-lisp/checkdoc.el > @@ -1952,11 +1952,10 @@ checkdoc-defun-info > ;; new obarray. > (if (not (listp lst)) (setq lst nil)) > (unless is-advice > - ;; lst here can be something like ((foo bar) baz) from > + ;; (car lst) can be something like ((foo bar) baz) from > ;; cl-lib methods; flatten it: > - (setq lst (flatten-tree lst)) > (while lst > - (setq ret (cons (symbol-name (car lst)) ret) > + (setq ret (cons (symbol-name (car (flatten-tree (car lst)))) ret) > lst (cdr lst))))) > (nreverse ret)))) Thank you; I've now applied your patch here since it seems to fix the use cases reported. However, I didn't include the tests in your patch, since they seemed to cover the same cases as Damien's (and they were more extensive, so I applied those instead). Besides, it doesn't look like you have copyright assignment papers on file, and for larger patches we require copyright assignments to the FSF. If you plan on submitting further patches in the future, it might be a good idea to do the paperwork now -- would you be willing to do so? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no