From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#38195: 27.0.50; `edebug-remove-instrumentation' doesn't work for adviced functions Date: Thu, 14 Nov 2019 06:20:40 +0100 Message-ID: <87r22brq3b.fsf@gnus.org> References: <87mucz98y9.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="2451"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 38195@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 14 06:21:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iV7ZC-0000Vm-39 for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Nov 2019 06:21:14 +0100 Original-Received: from localhost ([::1]:53512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iV7ZA-0005FE-VU for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Nov 2019 00:21:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57039) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iV7Z5-0005F6-3H for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 00:21:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iV7Z4-0006dm-0u for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 00:21:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51782) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iV7Z3-0006dG-TH for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 00:21:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iV7Z0-00082i-ID for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 00:21:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Nov 2019 05:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38195 X-GNU-PR-Package: emacs Original-Received: via spool by 38195-submit@debbugs.gnu.org id=B38195.157370885330875 (code B ref 38195); Thu, 14 Nov 2019 05:21:02 +0000 Original-Received: (at 38195) by debbugs.gnu.org; 14 Nov 2019 05:20:53 +0000 Original-Received: from localhost ([127.0.0.1]:60603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iV7Yq-00081u-KW for submit@debbugs.gnu.org; Thu, 14 Nov 2019 00:20:52 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:49054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iV7Yo-00081g-Cj for 38195@debbugs.gnu.org; Thu, 14 Nov 2019 00:20:51 -0500 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iV7Yf-0000XI-0S; Thu, 14 Nov 2019 06:20:43 +0100 In-Reply-To: <87mucz98y9.fsf@web.de> (Michael Heerdegen's message of "Wed, 13 Nov 2019 14:55:58 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171526 Archived-At: Michael Heerdegen writes: > Hi, > > e.g. (just a random example) > > (defun f (x) (* 2 (+ 1 x))) > > (advice-add 'f :around (lambda (orig-f x) (1+ (funcall orig-f x)))) > > Instrument `f'. Then M-x edebug-remove-instrumentation gives > > "Found no functions to remove instrumentation from". This is due to edebug-unwrap* not actually unwrapping something if it has been advised, apparently... I'm not familiar enough with how edebug really works to fix that. > BTW, another point: the user interface for edebug-remove-instrumentation > could be similar to `cancel-edebug-on-entry', i.e. it could prompt for a > function to remove instrumentation from, defaulting to all functions. Makes sense -- I've now done this. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no