all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 38354@debbugs.gnu.org
Subject: bug#38354: 27.0.50; Implement display action display-buffer-in-tab
Date: Fri, 29 Nov 2019 01:02:43 +0200	[thread overview]
Message-ID: <87r21r389g.fsf@mail.linkov.net> (raw)
In-Reply-To: <ab6bf14e-e34e-8627-eb29-afd93087e9d9@gmx.at> (martin rudalics's message of "Thu, 28 Nov 2019 10:20:59 +0100")

>>    (tab-bar-buffer-visible-in-tabs-p buffer)
>
> But this may also return non-nil when the buffer is invisible, that is
> not shown in any window.  We already have the "visible frames"
> notation, including the non-obscured frames connotation, so I'd rather
> not use the term visible in the context of tabs.

Maybe like having the terms "visible frame" and "iconified frame",
we should use the terms "current tab" and "inactive tabs".

> Wouldn't something like 'tab-bar-buffer-present-in-tabs-p' or
> 'tab-bar-buffer-in-tabs-p' be more intuitive?

Instead of suffix '-p' that assumes the function returns a boolean value,
better to return the found tab with the function name 'tab-bar-buffer-in-tab'.

>>> - to say that a buffer is actually displayed on a frame that has a
>>>    tab-bar.
>>
>> In my code I use for this:
>>
>>    (>= (length (get-buffer-window-list buffer t t)) 1)
>
> Why not simply 'get-buffer-window'?

Because actually I used more complicated logic:

  (> (length (get-buffer-window-list buffer t t)) 1)

that means don't kill the current buffer if it's also displayed
somewhere else.

> In either case what does the above "displayed" in
>
>>>> to display the buffer in an existing tab if such buffer is
>>>> already displayed in it.
>
> refer to now?  The former, the latter or their
>
>> i.e. I check these situations differently, and use 'or'
>> to combine these conditions:
>>
>>    (or (>= (length (get-buffer-window-list buffer t t)) 1)
>>        (tab-bar-buffer-visible-in-tabs-p buffer))
>>
>> Should these conditions be combined in one function
>> (if the current tab can be considered a tab as well)?
>
> 'or'?

Anyway it seems better not to use the word "displayed".

>>> And why "tabs" indiscriminately?  Don't you ever want to check for
>>> presence or visibility in a specific tab only?
>>
>> A specific tab referred by name?  Maybe such function could be useful as well.
>
> Don't you ever want to discriminate the tabs of the selected frame
> from the tabs of other frames?  Or are they all the same?

This means we need to add another dimension: first to look for the buffer
in all tabs of the selected frame, then look in tabs of other frames:
visible, iconified, or on any frame.

>>> 'display-buffer-reuse-window' together with 'reusable-frames' should
>>> have all the ingredients for this.  What is missing?
>>
>> Than we need to add 'reusable-tabs'?
>
> Why?  If a target tab (a tab with the name specified by ALIST) exists
> on any frame specified by 'reusable-frames', reuse it.  Otherwise make
> a new frame with the target tab as its only entry.

I don't understand.  Should ALIST look like this?

(push '("test1" .
        ((display-buffer-reuse-window display-buffer-in-tab)
         (reusable-frames  . visible)
         (name . "Tab1")))
      display-buffer-alist)





  reply	other threads:[~2019-11-28 23:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23 23:09 bug#38354: 27.0.50; Implement display action display-buffer-in-tab Juri Linkov
2019-11-26  9:32 ` martin rudalics
2019-11-26 22:30   ` Juri Linkov
2019-11-26 22:43   ` Juri Linkov
2019-11-27  9:49     ` martin rudalics
2019-11-27 21:37       ` Juri Linkov
2019-11-28  9:20         ` martin rudalics
2019-11-28 23:02           ` Juri Linkov [this message]
2019-11-29  9:24             ` martin rudalics
2019-12-01 22:29               ` Juri Linkov
2019-12-02  9:40                 ` martin rudalics
2019-12-02 23:43                   ` Juri Linkov
2019-12-03  9:18                     ` martin rudalics
2019-12-03 23:36                       ` Juri Linkov
2019-12-04  9:22                         ` martin rudalics
2019-12-04 22:51                           ` Juri Linkov
2019-12-05  9:05                             ` martin rudalics
2019-12-05 23:54                               ` Juri Linkov
2019-12-06  7:37                                 ` martin rudalics
2022-12-06 17:40                                   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r21r389g.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=38354@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.