From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#18969: 25.0.50; byte compiler warnings don't conform to GCS Date: Tue, 31 Dec 2019 11:34:18 +0100 Message-ID: <87r20kbx79.fsf@marxist.se> References: <87wq79ghmr.fsf@tromey.com> <2099525.NlHqIGAjEz@descartes> <87h82ff14v.fsf@marxist.se> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="205029"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: tom@tromey.com, 18969@debbugs.gnu.org To: =?UTF-8?Q?R=C3=BCdiger?= Sonderfeld Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 31 11:35:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1imErm-000rCg-Dh for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 Dec 2019 11:35:10 +0100 Original-Received: from localhost ([::1]:41024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imErl-0000V1-9V for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 Dec 2019 05:35:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57473) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imErf-0000Un-Ln for bug-gnu-emacs@gnu.org; Tue, 31 Dec 2019 05:35:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1imEre-0002QN-Hd for bug-gnu-emacs@gnu.org; Tue, 31 Dec 2019 05:35:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56030) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1imEre-0002PX-CS for bug-gnu-emacs@gnu.org; Tue, 31 Dec 2019 05:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1imEre-0002ZW-9p for bug-gnu-emacs@gnu.org; Tue, 31 Dec 2019 05:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Dec 2019 10:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18969 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18969-submit@debbugs.gnu.org id=B18969.15777884689820 (code B ref 18969); Tue, 31 Dec 2019 10:35:02 +0000 Original-Received: (at 18969) by debbugs.gnu.org; 31 Dec 2019 10:34:28 +0000 Original-Received: from localhost ([127.0.0.1]:33770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imEr6-0002YK-0S for submit@debbugs.gnu.org; Tue, 31 Dec 2019 05:34:28 -0500 Original-Received: from ted.gofardesign.uk ([67.225.143.91]:37874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imEr5-0002Y6-3o for 18969@debbugs.gnu.org; Tue, 31 Dec 2019 05:34:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0HYUDwYMjdOgnjs7om4rya68IxQ+3j6k32slVDCv7rw=; b=UqSbQ+/n+n5mN4sHLizaoYsjQw Ak5OLiS8LH8lwvcG/X14QBTT0f818UE1zsw2QF5Tl3W3oENWVU8LkX9wxDdHjLc4+Ac5UaGjDNEVX yP3pd7yJi3utqnbyAZjpUSjyKq+mjQk1Jz8064Gb0KYOHfKuET6RF1VRa2NdiueSI+BfojKZJSy4I dDRIxRxhSdBQeABuk3jCjMW5tWM1LHxvtaF8VBaMKaQ4n0CCTJ8FuIj3KsFKRTKmxzzyg9ye+Kbyi LHX8EpvULTVf7BW1gO5CRz29NfcUvZj5Gfty6cc92pM89XVcK7einhXdtD4ggXxNJm9YI1E9d4koy MgLGiWZw==; Original-Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:52194 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1imEqy-001iNW-K6; Tue, 31 Dec 2019 05:34:20 -0500 In-Reply-To: <87h82ff14v.fsf@marxist.se> (Stefan Kangas's message of "Thu, 05 Dec 2019 12:44:00 +0100") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173978 Archived-At: Stefan Kangas writes: > Tom Tromey writes: > >> I got this warning from the byte compiler: >> >> q.el:2:8:Warning: value returned from (aref v 0) is unused >> >> This doesn't fully conform to the GNU Coding Standards. >>>>>From (info "(standards) Errors") >> >> If you want to mention the column number, use one of these formats: >> >> SOURCE-FILE-NAME:LINENO:COLUMN: MESSAGE >> SOURCE-FILE-NAME:LINENO.COLUMN: MESSAGE >> >> The output here is missing a space after the ":". > > R=C3=BCdiger Sonderfeld writes: > >> On Wednesday 05 November 2014 19:58:04 Tom Tromey wrote: >>> The output here is missing a space after the ":". >> >> I wrote a quick fix for it. But I'm not sure if this is the best approa= ch: >> >> diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el >> index 392f6ee..d2bbefa 100644 >> --- a/lisp/emacs-lisp/bytecomp.el >> +++ b/lisp/emacs-lisp/bytecomp.el >> @@ -1082,7 +1082,7 @@ (defun byte-compile-warning-prefix (level entry) >> byte-compile-last-warned-form)))) >> (insert (format "\nIn %s:\n" form))) >> (when level >> - (insert (format "%s%s" file pos)))) >> + (insert (format "%s%s " file pos)))) >> (setq byte-compile-last-logged-file byte-compile-current-file >> byte-compile-last-warned-form byte-compile-current-form) >> entry) > > This was never installed at the time, but it does seem that we are > breaking against GNU Coding Standards. Does anyone object to > installing the above change? I have seen no objections within 3 weeks, so I'll go ahead and install this change on the master branch within a couple of days. Best regards, Stefan Kangas