From: Stefan Kangas <stefan@marxist.se>
To: "Rüdiger Sonderfeld" <ruediger@c-plusplus.de>
Cc: tom@tromey.com, 18969@debbugs.gnu.org
Subject: bug#18969: 25.0.50; byte compiler warnings don't conform to GCS
Date: Tue, 31 Dec 2019 11:34:18 +0100 [thread overview]
Message-ID: <87r20kbx79.fsf@marxist.se> (raw)
In-Reply-To: <87h82ff14v.fsf@marxist.se> (Stefan Kangas's message of "Thu, 05 Dec 2019 12:44:00 +0100")
Stefan Kangas <stefan@marxist.se> writes:
> Tom Tromey <tom@tromey.com> writes:
>
>> I got this warning from the byte compiler:
>>
>> q.el:2:8:Warning: value returned from (aref v 0) is unused
>>
>> This doesn't fully conform to the GNU Coding Standards.
>>>>From (info "(standards) Errors")
>>
>> If you want to mention the column number, use one of these formats:
>>
>> SOURCE-FILE-NAME:LINENO:COLUMN: MESSAGE
>> SOURCE-FILE-NAME:LINENO.COLUMN: MESSAGE
>>
>> The output here is missing a space after the ":".
>
> Rüdiger Sonderfeld <ruediger@c-plusplus.de> writes:
>
>> On Wednesday 05 November 2014 19:58:04 Tom Tromey wrote:
>>> The output here is missing a space after the ":".
>>
>> I wrote a quick fix for it. But I'm not sure if this is the best approach:
>>
>> diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
>> index 392f6ee..d2bbefa 100644
>> --- a/lisp/emacs-lisp/bytecomp.el
>> +++ b/lisp/emacs-lisp/bytecomp.el
>> @@ -1082,7 +1082,7 @@ (defun byte-compile-warning-prefix (level entry)
>> byte-compile-last-warned-form))))
>> (insert (format "\nIn %s:\n" form)))
>> (when level
>> - (insert (format "%s%s" file pos))))
>> + (insert (format "%s%s " file pos))))
>> (setq byte-compile-last-logged-file byte-compile-current-file
>> byte-compile-last-warned-form byte-compile-current-form)
>> entry)
>
> This was never installed at the time, but it does seem that we are
> breaking against GNU Coding Standards. Does anyone object to
> installing the above change?
I have seen no objections within 3 weeks, so I'll go ahead and install
this change on the master branch within a couple of days.
Best regards,
Stefan Kangas
next prev parent reply other threads:[~2019-12-31 10:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 2:58 bug#18969: 25.0.50; byte compiler warnings don't conform to GCS Tom Tromey
2014-11-06 20:27 ` Rüdiger Sonderfeld
2019-12-05 11:44 ` Stefan Kangas
2019-12-31 10:34 ` Stefan Kangas [this message]
2020-01-19 1:11 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r20kbx79.fsf@marxist.se \
--to=stefan@marxist.se \
--cc=18969@debbugs.gnu.org \
--cc=ruediger@c-plusplus.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.