From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#38918: 26.3; EBDB fails to edit (add) tags Date: Sat, 18 Jan 2020 10:37:51 -0800 Message-ID: <87r1zwpq4g.fsf@ericabrahamsen.net> References: <87d0bzcnmm.fsf@disroot.org> <87zhf3m4pe.fsf@ericabrahamsen.net> <87blri6a9j.fsf@disroot.org> <87r20en36v.fsf@ericabrahamsen.net> <87v9pqgou0.fsf@disroot.org> <8736csz841.fsf@ericabrahamsen.net> <87d0bv1mmb.fsf@disroot.org> <87h817uq0x.fsf@ericabrahamsen.net> <87muas943w.fsf@disroot.org> <87r204pplx.fsf@ericabrahamsen.net> <87sgki2r5s.fsf@disroot.org> <87o8v5lkq0.fsf@ericabrahamsen.net> <878sm468in.fsf@aia00054aia.gr> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="59786"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Jorge P. de Morais Neto" , 38918@debbugs.gnu.org To: Deus Max Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 18 19:39:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ist0E-000FWE-5o for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Jan 2020 19:39:22 +0100 Original-Received: from localhost ([::1]:43586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ist0D-0008Hn-3p for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Jan 2020 13:39:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45028) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isszv-0008Hf-2T for bug-gnu-emacs@gnu.org; Sat, 18 Jan 2020 13:39:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isszu-0007IJ-0a for bug-gnu-emacs@gnu.org; Sat, 18 Jan 2020 13:39:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36195) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1isszt-0007IC-T3 for bug-gnu-emacs@gnu.org; Sat, 18 Jan 2020 13:39:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1isszt-0002NZ-Rb for bug-gnu-emacs@gnu.org; Sat, 18 Jan 2020 13:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Jan 2020 18:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38918 X-GNU-PR-Package: emacs Original-Received: via spool by 38918-submit@debbugs.gnu.org id=B38918.15793726829024 (code B ref 38918); Sat, 18 Jan 2020 18:39:01 +0000 Original-Received: (at 38918) by debbugs.gnu.org; 18 Jan 2020 18:38:02 +0000 Original-Received: from localhost ([127.0.0.1]:42168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1issyw-0002LL-64 for submit@debbugs.gnu.org; Sat, 18 Jan 2020 13:38:02 -0500 Original-Received: from ericabrahamsen.net ([52.70.2.18]:50150 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1issys-0002Kr-UH for 38918@debbugs.gnu.org; Sat, 18 Jan 2020 13:38:00 -0500 Original-Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 02EA0FA9AC; Sat, 18 Jan 2020 18:37:52 +0000 (UTC) In-Reply-To: <878sm468in.fsf@aia00054aia.gr> (Deus Max's message of "Sat, 18 Jan 2020 18:20:48 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174827 Archived-At: On 01/18/20 18:20 PM, Deus Max wrote: > On Tue, Jan 14 2020, Eric Abrahamsen wrote: > >> Jorge P. de Morais Neto writes: >> >> >>> Besides, it seems that the function `org--tag-add-to-alist' does not >>> exist on the Org Mode version (9.1 IIRC) that comes with Emacs 26.3. I >>> think you should document that the Org Tags functionality depends on >>> recent Org Mode. Also, maybe (I don't know if this would be worth your >>> time) EBDB could provide a clear error message when the user attempts to >>> use that functionality on an old Org Mode. Currently it lets Emacs >>> complain that the symbol's value as a function is void. >> >> This is a bigger problem -- I'm committed to supporting Emacs 25. I >> think I'll just write my own function (read: copy and paste Org's) to do >> the same thing. >> >> Thanks, >> Eric > > Hi Eric, > > It's a bad practice to duplicate functions from other packages. At least > maybe you could enclose the definition in a (eval-after-load 'org ...) > construct and provide org--tag-add-to-alist only if it is not defined. > That way you will also be able to provide a message recommending an > upgrade to a more recent org-mode. I would definitely do that, except the function is "private" to begin with. I raised this on the Org mailing list, but got no response. I suppose the proper thing to do would be to contribute a public function to Org that does what I want, then also define it in EBDB, and do a `defalias' in `eval-after-load', as you describe.