all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: "積丹尼 Dan Jacobson" <jidanni@jidanni.org>
Cc: 40951@debbugs.gnu.org
Subject: bug#40951: Weird highlighting
Date: Fri, 01 May 2020 20:44:13 +0200	[thread overview]
Message-ID: <87r1w3o5qa.fsf@gmail.com> (raw)
In-Reply-To: <87368m6v1a.8.fsf@jidanni.org> ("積丹尼 Dan Jacobson"'s message of "Thu, 30 Apr 2020 01:50:25 +0800")

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

>>>>>> "KLG" == Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
> KLG> 積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:
>
> KLG> on the other hand I don't see how Gnus could distinguish between a
> KLG> verb added deliberately by the article author, and the same verb
> KLG> added automatically as part of the mail client's citation
> KLG> boilerplate.
>
> Hmmm, well don't boilerplates have some @ and/or < and > etc. in them?

If we focus solely on Gnus's message.el, message-insert-citation-line
can be relied on to use whatever was in the "From" header.  From what I
gather from RFC 5322, that should at least include an "@" sign.

That only covers Gnus's "writes:" though.  Spelunking in lisp/gnus for
other verbs featured in gnus-cite-attribution-suffix, I get the
impression that other MUAs tend to follow suit, but that might be
wishful thinking.

Assuming false negatives (failing to highlight) on articles from
"non-conforming" MUAs are less annoying than false positives
(highlighting part of a line that's not introducing a citation) on
"conforming" ones, I'm still not sure where the right "fix" would
belong.

gnus-cite-attribution-suffix's job is to match just the final verb
before the citation, so I think it's fine the way it is.  There's
probably a way to teach gnus-article-highlight-citation that it
shouldn't apply gnus-cite-attribution-face to the whole line, but I'm
not familiar enough with the code to see how to go about it.





  reply	other threads:[~2020-05-01 18:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29  0:52 bug#40951: Weird highlighting 積丹尼 Dan Jacobson
2020-04-29  7:44 ` Kévin Le Gouguec
2020-04-29 17:50   ` 積丹尼 Dan Jacobson
2020-05-01 18:44     ` Kévin Le Gouguec [this message]
2020-08-05 11:19       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1w3o5qa.fsf@gmail.com \
    --to=kevin.legouguec@gmail.com \
    --cc=40951@debbugs.gnu.org \
    --cc=jidanni@jidanni.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.