From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= Newsgroups: gmane.emacs.devel Subject: Re: git-send-email Date: Mon, 15 Jun 2020 19:59:37 +0200 Message-ID: <87r1ugb46u.fsf@gmail.com> References: <875zdteybt.fsf@runbox.com> <87368wrvf5.fsf@yahoo.com> <86k126d83n.wl-me@enzu.ru> <83pnbyckvv.fsf@gnu.org> <4923d7e98f5ed816a7569093dbc673153adcea88.camel@yandex.ru> <837dwb3zb6.fsf@gnu.org> <20200613141653.GA55972@breton.holly.idiocy.org> <835zbv3v6q.fsf@gnu.org> <20200613142329.GA56313@breton.holly.idiocy.org> <834krf3uij.fsf@gnu.org> <87r1ujatv4.fsf@igel.home> <831rmj3stn.fsf@gnu.org> <87mu57atav.fsf@igel.home> <87lfkpcn6t.fsf_-_@gmail.com> <83d0612gx3.fsf@gnu.org> <878sgobuvf.fsf@gmail.com> <837dw82xwd.fsf@gnu.org> <87pna05ogg.fsf@gmail.com> <83zh941cem.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="915"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: stefan@marxist.se, alan@idiocy.org, emacs-devel@gnu.org, schwab@linux-m68k.org, hi-angel@yandex.ru To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 15 20:00:18 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jktP8-000Y5L-7U for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Jun 2020 20:00:18 +0200 Original-Received: from localhost ([::1]:54708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jktP6-0003TY-G4 for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Jun 2020 14:00:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jktOY-0002za-K5 for emacs-devel@gnu.org; Mon, 15 Jun 2020 13:59:42 -0400 Original-Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:37753) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jktOX-0007Nq-1q; Mon, 15 Jun 2020 13:59:42 -0400 Original-Received: by mail-wr1-x432.google.com with SMTP id x13so18048538wrv.4; Mon, 15 Jun 2020 10:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=YGJB0sFhGrEnwAV75ufD5Q2uWj+e8SDOJUs9nnqlD7k=; b=TtbB/k68Ilv7cnuak//M6+94OWAmiesJEU8sgnWF6/b4LBKDtt+qgMKSCsSWAvLM9p 7WY1rE7xdneB8T4qJvwSY+ve1DIUUYx635zIaVwBBgQUqw7lYT3zJRv+zfd4+QjK3JRE BtfG1ctuHIDziFa4+t0HUnmgQgJYjUYLf3Rh9oez9pFLp3/8FCbPunFv5ucFrAFNkjET ITW+n6qL047UntFecBPwuZbrDoSlkSU+xYrBLe38fAS9FiuQJQ+3gWzzpa9g8LttTyM6 QBFUeqdgneC+Wa9P+AiWOneGu+E9Uk6L9gdPa4dsewlb6zKMueFPb3Mzt0qdT4VCXlr2 0U8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=YGJB0sFhGrEnwAV75ufD5Q2uWj+e8SDOJUs9nnqlD7k=; b=S9iQentVmLndklUMdWWUVk4RBUKjwlfoIKbQ1k3qldskBeeZpTk7HkgX3Fjy4EI9Cj xC/4kZcOxE/oPBcmm6FX6iuHHzKebkO3bA2KVPxOlN3REtbf7nIVkUmuBEtmmEueEpxj 1zrY/m89/KLYRM3jauubuKwIVfiJO4uvAVH78dklEc99t5urfrVDTAZNNXSAA4MpShTa Qh/0NRVX3RDobfU1u58k9ONPn8VkNrz15BeRWLh2m6Vyl3fPF+JSNLLH68o60nuSRpEu yarvPpz8obPPEhyeo14Gc6ncXI8Sh1zXAz3yk0+LsSyu2wqr99YfvD6teEKwmf+TFzrI JwAQ== X-Gm-Message-State: AOAM5335gW9u5ek8B2+H6GPzE3zzoS8zkEBj3rLauevpakSvBPJKwiaa wQHcO5aRxngshZ+rj4l3d8d4B5Xh+Awe9g== X-Google-Smtp-Source: ABdhPJy6C6E1cu1Sgetb+j4K1tyA+IS2wMc+4GFqpFYapuoE520eqrVWL4d1MyjWPwPLIHrZN8gmeg== X-Received: by 2002:a5d:5744:: with SMTP id q4mr29054159wrw.137.1592243978741; Mon, 15 Jun 2020 10:59:38 -0700 (PDT) Original-Received: from my-little-tumbleweed (200.143.13.109.rev.sfr.net. [109.13.143.200]) by smtp.gmail.com with ESMTPSA id d17sm26543595wrg.75.2020.06.15.10.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 10:59:38 -0700 (PDT) In-Reply-To: <83zh941cem.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 15 Jun 2020 20:12:17 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=kevin.legouguec@gmail.com; helo=mail-wr1-x432.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252275 Archived-At: Eli Zaretskii writes: > My email setup hides all X-* headers when it displays messages, > because those headers are just noise, and AFAIK are not generally > meant for human consumption. (There's a command to toggle their > display, but doing that is another nuisance. Also, a typical message > coming from debbugs has about a dozen X-* headers, so again, > discovering that one header is not easy and calls for careful reading > of boring content, better avoided.) Fair enough. Should the wave of git-send-email contributions turn out to be unstoppable, at least the existence of this header means it won't be too hard to write a function to automate this check ;) >> OTOH I also see that projects working with git-send-email seem to be >> none worse for the wear[2]. > > So do we, see CONTRIBUTE. We just ask that git-send-email be used > after formatting the patch explicitly, so that all its decorations > appear in the email body. If nothing else, this facilitates including > unrelated discussions with the patch without risking them winding up > in the repository. Mmm, now that you mention it, I'm confused. Here's what we say in CONTRIBUTE: > To email a patch you can use a shell command like 'git format-patch -1' > to create a file, and then attach the file to your email. This nicely > packages the patch's commit message and changes. To send just one > such patch without additional remarks, you can use a command like > 'git send-email --to=bug-gnu-emacs@gnu.org 0001-DESCRIPTION.patch'. I just tried to git-send-email --to=myself a patch file generated from git-format-patch, and the email I received looks just like what Konstantin sent to the bug list, i.e. - the commit's summary line in the Subject field, - the rest of the commit message at the top of the body, - some fluff between the "---\n" and "diff --git" lines (a diffstat added by git-format-patch; I could have added more comments there, like Konstantin did), - the diff, - no attachment. I must be missing something. How do our instructions differ from what Konstantin did? Indeed he ran git-send-email without running git-format-patch first, but AFAICT this additional step does not change the end result?