From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.bugs Subject: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Date: Thu, 18 Jun 2020 18:49:52 +0000 Message-ID: <87r1ucmcok.fsf@thornhill.no> References: <87bllk2pfc.fsf@thornhill.no> <87wo44mzrb.fsf@thornhill.no> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="120819"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41879@debbugs.gnu.org To: Andrii Kolomoiets Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 18 20:51:30 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlzdK-000VIr-Bk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Jun 2020 20:51:30 +0200 Original-Received: from localhost ([::1]:33350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlzdJ-0004g1-4y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Jun 2020 14:51:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlzcs-0004ej-48 for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2020 14:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42869) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jlzcr-0004ks-QI for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2020 14:51:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jlzcr-0007sP-Mt for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2020 14:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jun 2020 18:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41879 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41879-submit@debbugs.gnu.org id=B41879.159250620930193 (code B ref 41879); Thu, 18 Jun 2020 18:51:01 +0000 Original-Received: (at 41879) by debbugs.gnu.org; 18 Jun 2020 18:50:09 +0000 Original-Received: from localhost ([127.0.0.1]:54410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlzc0-0007qu-RV for submit@debbugs.gnu.org; Thu, 18 Jun 2020 14:50:09 -0400 Original-Received: from mail2.protonmail.ch ([185.70.40.22]:46167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlzby-0007qG-NV for 41879@debbugs.gnu.org; Thu, 18 Jun 2020 14:50:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592506200; bh=oodhNI5lzBHoUr6BYgMTtxJ9SYCGKomkNw5HsIff+sI=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=TNLdMsbRY/Ed2HIOzqSeigC9Snvk2/S2i0sdaKA5/6NpwfhcpxLsLl3yn00o8DURr +CvCqoulrGkGTMQvu49P5i3yQrOufLH0znwGhp7WZ/XvFVCZBAjjUu680M2IuXPzmh iI3JtSnNQ6TuU015i6b+i30Vtuo6A5eKhQ7D5J7mjNPMhfHEqbDgSxoWMQJo5vHU3y scvojZtZFAXqnH9GqCFDTT0Mh0NRJnBA+92Vy0NOI3lUdiojSNg2PrxWEitp49l2J3 JUwFpLcUdmiZLOxXev5or5SyVYH/BRasKI9YjBKx3ymroCuAAQkUY+admo8fHr/Mwe LCMxqebrP+hcQ== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182142 Archived-At: > Hi Theodor, Hi! > Please take a look at the attached patch. =20 That's very cool! I was sitting right now doing something similar, but you = beat me to it. Sorry for not getting to it faster - life happened :) I was struggling a little with the default buffer part, which you solved by= kinda not solving it. I was trying to determine in some way what buffer w= ould be reasonable to offer as default value if that predicate fails. Mayb= e it is best to just return nil there as you do.=20 Maybe just one thing. Eli addressed the docstring in one of the other func= tions as being a little ambiguous. Maybe update it to something like: "Switch to an open buffer in the current project." In addition, maybe adding a small comment above the default value predicate= , explaining the relation to the undocumentet structure used in this functi= on. Or not, maybe it is clear enough given the preceeding comment.=20 Thank you for bringing this up - and fixing it! Theo