all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: 42110@debbugs.gnu.org
Cc: Robin <robin_choudhury1@protonmail.com>, Reuben Thomas <rrt@sc3d.org>
Subject: bug#42110: Whitespace Newline Face Doesn't Disappear
Date: Sun, 28 Jun 2020 17:28:20 +0100	[thread overview]
Message-ID: <87r1tz5f4r.fsf@tcd.ie> (raw)
In-Reply-To: <TH6-LiQzBqovrHIRGat1OVqko1IXFVXQS-d5gi9_z9D5cqOFJiCU07i8JnSgWRC2lTexUmog7UOmFqmb06vfICC0dy3MO9rVHpfGdcb9kkQ=@protonmail.com> (Robin via "Bug reports for GNU Emacs, the Swiss army knife of text editors"'s message of "Sun, 28 Jun 2020 15:37:01 +0000")

found 37467 25.3
forcemerge 37467 42110
quit

> From: Robin Choudhury <robin_choudhury1@protonmail.com>
> To: bug-gnu-emacs@gnu.org
> Subject: 26.3; Whitespace Newline Face Doesn't Disappear
> -----
>
> When typing at the bottom of a document, a newline is inserted. An
> additional newline is then inserted. Upon insertion, a face higlights
> the first newline's emptiness. Typing in the second newline should make
> this face disappear. However, it remains.

Thanks, I can reproduce this in Emacs versions 25.3-28 inclusive, but
not in 24.5.  I think this is a duplicate of bug#37467, and sounds like
it might be related/due to bug#24745; CCing Reuben.

Some minor notes on your configuration:

> The whitespace configuration (13.2.2):
> (use-package whitespace
>   :ensure t
    ^^^^^^^^^
No need for this, lisp/whitespace.el is built-in.

>   :init
>   (setq prelude-whitespace nil)
>   (setq whitespace-line-column 80)
>   ;; Highlight trailing whitespace
>   (setq whitespace-style
>         ;; There's a bug in empty where the face doesn't go away after
>         ;; typing below the newline.
>         '(face trailing lines-tail indentation::space tab-mark empty))
>   :config
>   (global-whitespace-mode t))
                           ^^^
No well behaved mode function documents t as a valid argument for
enabling it.  Instead, you should write one of the following or
equivalent:

  (global-whitespace-mode)
  (global-whitespace-mode 1)

Here's a simpler reproduction recipe:

0. emacs -Q
1. C-o
2. (progn (setq whitespace-style '(face empty))
          (whitespace-mode))
3. C-x C-e
4. C-m C-m
5. asd

Expected: the yellow highlight on the empty line 6 disappears, since
line 6 is not at EOB any longer.

Observed: the empty line 6 is still highlighted with the
whitespace-empty face.

Thanks,

-- 
Basil





  reply	other threads:[~2020-06-28 16:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-28 15:37 bug#42110: Whitespace Newline Face Doesn't Disappear Robin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-06-28 16:28 ` Basil L. Contovounesios [this message]
     [not found]   ` <6DSVEaDOI_Q9I_GH8R12lTvRDtbDQ2-4su3haR_jnJeCf6nQ_xCHD0aXRdfwezFBOxGGpwpnfIUdXT-J8_5K_3T9ntDxRQKjFuRfxn9Lkso=@protonmail.com>
2020-06-28 17:21     ` Basil L. Contovounesios
2020-06-28 18:08   ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
  -- strict thread matches above, loose matches on Subject: below --
2019-09-20  5:30 bug#37467: 26.3; whitespace-mode doesn't update BOB/EOB highlights Dale Sedivec
2022-06-29 21:28 ` bug#37467: [PATCH] whitespace: Redo BoB/EoB empty line highlighting Richard Hansen
2022-09-11 11:46   ` bug#42110: Whitespace Newline Face Doesn't Disappear Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1tz5f4r.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=42110@debbugs.gnu.org \
    --cc=robin_choudhury1@protonmail.com \
    --cc=rrt@sc3d.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.