From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#40425: 26.3; eww-open-file is not working with a Tramp file name Date: Fri, 17 Jul 2020 16:39:20 +0200 Message-ID: <87r1tamciv.fsf@gnus.org> References: <864ktzebmg.fsf@duenenhof-wilhelm.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12974"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 40425@debbugs.gnu.org To: dieter@duenenhof-wilhelm.de (H. Dieter Wilhelm) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 17 16:40:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwRX1-0003CN-Db for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jul 2020 16:40:11 +0200 Original-Received: from localhost ([::1]:46314 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwRX0-0005Ee-F4 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jul 2020 10:40:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwRWs-0005D0-H6 for bug-gnu-emacs@gnu.org; Fri, 17 Jul 2020 10:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jwRWs-0003oI-6r for bug-gnu-emacs@gnu.org; Fri, 17 Jul 2020 10:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jwRWs-0000mz-4V for bug-gnu-emacs@gnu.org; Fri, 17 Jul 2020 10:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jul 2020 14:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40425 X-GNU-PR-Package: emacs Original-Received: via spool by 40425-submit@debbugs.gnu.org id=B40425.15949967752994 (code B ref 40425); Fri, 17 Jul 2020 14:40:02 +0000 Original-Received: (at 40425) by debbugs.gnu.org; 17 Jul 2020 14:39:35 +0000 Original-Received: from localhost ([127.0.0.1]:57866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwRWR-0000mE-4r for submit@debbugs.gnu.org; Fri, 17 Jul 2020 10:39:35 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:44706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jwRWN-0000m0-9m for 40425@debbugs.gnu.org; Fri, 17 Jul 2020 10:39:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JGVzurHiMpnIoSrdmf6QKUdenhYRrFbSavFB1fFPAUA=; b=Lpo0sJGSCc1mBP0jR86CLeyZDC 1UmbJSfwhNy7wxDg94Zs2TYZh/NdrPdyBZURhCtK8+dJsZyezMGZ92GHfOp/uWQW6Y5T92gFixqZl 57kqSUDvTc6b46hicpGDXOAAwNyjZVgzF1sTBAZ0S07p/dKByCit0eoY9kXtgOkqO7q8=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwRWE-00057q-0o; Fri, 17 Jul 2020 16:39:24 +0200 In-Reply-To: <864ktzebmg.fsf@duenenhof-wilhelm.de> (H. Dieter Wilhelm's message of "Sat, 04 Apr 2020 13:25:27 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183149 Archived-At: dieter@duenenhof-wilhelm.de (H. Dieter Wilhelm) writes: > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) > url-file-asynch-callback(nil nil nil > "/:/ssh:stories:/home/larsi/.emacs.d/bookiez.data" # *url-file*-73983> eww-render (nil > "file:///ssh:stories:/home/larsi/.emacs.d/bookiez.d..." nil # *eww*>)) This is due to the following patch, and the moron who committed it neglected to say what problem it was trying to fix: commit 023ec128fd95eadac7b607177969267cc8b9accf Author: Lars Magne Ingebrigtsen Date: Tue Nov 16 14:46:12 2010 +0100 Avoid interpreting file:/foo:/bar URLs via tramp. The following patch makes the test case work again... but this is basically what I added in 2010: diff --git a/lisp/url/url-file.el b/lisp/url/url-file.el index eec7cdfbe8..77495d7e57 100644 --- a/lisp/url/url-file.el +++ b/lisp/url/url-file.el @@ -110,9 +110,6 @@ url-file-build-filename ((and (string-match "\\`/[a-zA-Z]:/" file) (memq system-type '(ms-dos windows-nt))) (substring file 1)) - ;; file: URL with a file:/bar:/foo-like spec. - ((string-match "\\`/[^/]+:/" file) - (concat "/:" file)) (t file)))) *sigh* My guess is that this attempt to fix the problem of file names that contain colons without actually being tramp files? I don't quite know what the solution is here... it does seem odd for a low-level library like URL to call out to tramp -- that may even have security implications: It's very unexpected that (say) hitting a link on a web page ends up with you ssh-ing to a local machine. So in that regard I agree with my 2010 self. But it does make eww-open-file, which should accept tramp file names, very awkward to implement... Any opinions? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no