From: Lars Ingebrigtsen <larsi@gnus.org>
To: Kevin Brubeck Unhammer <unhammer@fsfe.org>
Cc: 40121@debbugs.gnu.org, Corwin Brust <corwin@bru.st>
Subject: bug#40121: 27.0.90; ERC incorrectly reuses single buffer for channels of same name on multiple networks
Date: Wed, 05 Aug 2020 11:14:18 +0200 [thread overview]
Message-ID: <87r1sle9p1.fsf@gnus.org> (raw)
In-Reply-To: <87ft91zcuu.fsf@mm.st> (Kevin Brubeck Unhammer's message of "Wed, 05 Aug 2020 11:00:25 +0200")
Kevin Brubeck Unhammer <unhammer@fsfe.org> writes:
> There's still a bug when there's two networks on the same server:port.
>
> But the fix is simple, just an `(and target …)` around the "Channel
> buffer" case, like
>
> ;; Channel buffer; check that it's from the right server.
> (and target
> (with-current-buffer (get-buffer candidate)
> (and (string= erc-session-server server)
> (erc-port-equal erc-session-port port))))
>
> I connect to several networks on the same server:port (my weechat
> instance). Without the `and target` check it'll reuse the server buffer
> from network1 when connecting to network2.
Ah, I see. I didn't even know that was possible. :-)
I've now applied your fix to Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-08-05 9:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 16:08 bug#40121: 27.0.90; ERC incorrectly reuses single buffer for channels of same name on multiple networks Corwin Brust
2020-06-22 13:33 ` Kevin Brubeck Unhammer
2020-08-02 7:44 ` Lars Ingebrigtsen
2020-08-05 9:00 ` Kevin Brubeck Unhammer
2020-08-05 9:14 ` Lars Ingebrigtsen [this message]
2020-08-05 10:37 ` Kevin Brubeck Unhammer
2020-08-05 2:34 ` Mingde (Matthew) Zeng
2020-08-05 12:53 ` Lars Ingebrigtsen
2020-08-05 13:09 ` Corwin Brust
2020-08-05 13:13 ` Amin Bandali
2020-08-05 13:26 ` Lars Ingebrigtsen
2020-08-11 18:53 ` bug#40121: [PATCHv2] erc: fix erc-reuse-buffers behavior Mingde (Matthew) Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1sle9p1.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=40121@debbugs.gnu.org \
--cc=corwin@bru.st \
--cc=unhammer@fsfe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.