From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#38294: [PATCH] Handle killing of virtual buffers in Ido Date: Fri, 14 Aug 2020 13:00:56 +0200 Message-ID: <87r1s9a3vb.fsf@gnus.org> References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> <874kpcrm5q.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="842"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Kangas , 38294@debbugs.gnu.org To: Dario Gjorgjevski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 14 13:02:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6XTV-00005b-7Q for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Aug 2020 13:02:17 +0200 Original-Received: from localhost ([::1]:52226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6XTU-0003oG-9Y for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Aug 2020 07:02:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6XTG-0003nc-Sk for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 07:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6XTG-0000QC-IY for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 07:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6XTG-0001J8-E8 for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 07:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Aug 2020 11:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38294-submit@debbugs.gnu.org id=B38294.15974028704950 (code B ref 38294); Fri, 14 Aug 2020 11:02:02 +0000 Original-Received: (at 38294) by debbugs.gnu.org; 14 Aug 2020 11:01:10 +0000 Original-Received: from localhost ([127.0.0.1]:51951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6XSQ-0001Hm-Ai for submit@debbugs.gnu.org; Fri, 14 Aug 2020 07:01:10 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:40208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6XSO-0001HX-OH for 38294@debbugs.gnu.org; Fri, 14 Aug 2020 07:01:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GXzvfBgR1ktcLf4eOsLP1ygHwkfnFGQvnsTT6y07wh4=; b=lpRGaQjt9h5gJdZf9mx1L+FPEM 3MwRweR7EG3zTN59KGYrF3DkuluJfVGFWd5DdjMYnCmYvLhQYuiMOLjpt1kSP8KUoUrJt3DlF+ORq CGxAklG2bGn4K6N7pRUwIJzuoJ4zhnUGTgGvUbwYo984tfcJ6VqcLYpuj4wezrwEKX2s=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6XSE-00011s-8e; Fri, 14 Aug 2020 13:01:01 +0200 In-Reply-To: (Dario Gjorgjevski's message of "Fri, 14 Aug 2020 11:23:43 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185093 Archived-At: Dario Gjorgjevski writes: > Hi Stefan, > >> Killing it isn't a no-op though. When you kill it, you get prompted to >> save changes, it runs hooks in the background, presumably removes it >> from active memory, other functions will no longer be able to just >> switch to it, etc., etc. Yeah, but these "virtual buffers" don't really exist, so none of that will happen, I'd have thought? > Point taken. In that case, my only complaint would be that > =E2=80=98ido-kill-buffer-at-head=E2=80=99 does treat killing a virtual bu= ffer as > removing it from =E2=80=98recentf-list=E2=80=99 (just as suggested here),= so there is > some inconsistency. However, I can live with it. Yeah, that is inconsistent: ;;; KILL CURRENT BUFFER (defun ido-kill-buffer-at-head () "Kill the buffer at the head of `ido-matches'. If cursor is not at the end of the user input, delete to end of input." [...] ;; Handle virtual buffers ((assoc buf ido-virtual-buffers) (setq recentf-list (delete (cdr (assoc buf ido-virtual-buffers)) recentf-list)) So now I'm kinda thinking that your original patch is correct. :-) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no